Experiment - monomorphic node/type/signature #58928

dragomirtitian · 2024-06-19T15:25:18Z

Experiment to make several objects monomorphic by keeping the common properties in a single object shape and moving all other properties to a separate object and using accessors to preserve compatibility with existing code.

Local improvements seem promising, building TSC/compiler: ~-20% in time with ~+10% in memory.

Code is rough around the edges, just testing out as a proof of concept.

Note: This is the result of me and @acutmore bouncing ideas about improving access to Node.kind

jakebailey · 2024-06-19T15:31:07Z

@typescript-bot perf test this

typescript-bot · 2024-06-19T15:31:10Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this`	✅ Started	👀 Results

typescript-bot · 2024-06-19T16:18:25Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{194,582k (± 0.91%)}	_{217,957k (± 0.03%)}	_{🔻+23,375k (+12.01%)}	_217,873k	_218,049k	_{p=0.005 n=6}
_{Parse Time}	_{1.57s (± 0.33%)}	_{1.67s (± 0.49%)}	_{🔻+0.09s (+ 5.93%)}	_1.66s	_1.68s	_{p=0.004 n=6}
_{Bind Time}	_{0.86s (± 1.55%)}	_{0.81s (± 1.04%)}	_{🟩-0.05s (- 6.21%)}	_0.80s	_0.82s	_{p=0.004 n=6}
_{Check Time}	_{11.20s (± 0.36%)}	_{8.67s (± 0.93%)}	_{🟩-2.53s (-22.60%)}	_8.57s	_8.78s	_{p=0.005 n=6}
_{Emit Time}	_{3.26s (± 0.69%)}	_{2.87s (± 0.51%)}	_{🟩-0.39s (-12.10%)}	_2.85s	_2.89s	_{p=0.005 n=6}
_{Total Time}	_{16.89s (± 0.29%)}	_{14.01s (± 0.59%)}	_{🟩-2.88s (-17.07%)}	_13.92s	_14.14s	_{p=0.005 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,114	_944,114	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,051	_407,051	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,218,316k (± 0.00%)}	_{1,387,661k (± 0.00%)}	_{🔻+169,345k (+13.90%)}	_1,387,617k	_1,387,712k	_{p=0.005 n=6}
_{Parse Time}	_{7.96s (± 0.46%)}	_{8.42s (± 0.48%)}	_{🔻+0.46s (+ 5.76%)}	_8.37s	_8.49s	_{p=0.005 n=6}
_{Bind Time}	_{2.23s (± 0.63%)}	_{1.91s (± 0.39%)}	_{🟩-0.32s (-14.28%)}	_1.90s	_1.92s	_{p=0.005 n=6}
_{Check Time}	_{35.82s (± 0.40%)}	_{27.74s (± 0.22%)}	_{🟩-8.07s (-22.54%)}	_27.63s	_27.81s	_{p=0.005 n=6}
_{Emit Time}	_{16.18s (± 0.53%)}	_{14.05s (± 0.29%)}	_{🟩-2.12s (-13.12%)}	_14.01s	_14.12s	_{p=0.005 n=6}
_{Total Time}	_{62.18s (± 0.26%)}	_{52.13s (± 0.17%)}	_{🟩-10.05s (-16.17%)}	_51.97s	_52.21s	_{p=0.005 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,133,539	_2,133,539	_~	_~	_~	_{p=1.000 n=6}
_Types	_926,551	_926,551	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,115,789k (± 0.01%)}	_{2,268,208k (± 0.00%)}	_{🔻+152,419k (+ 7.20%)}	_2,268,182k	_2,268,228k	_{p=0.005 n=6}
_{Parse Time}	_{7.88s (± 0.23%)}	_{9.27s (± 0.28%)}	_{🔻+1.39s (+17.64%)}	_9.24s	_9.31s	_{p=0.005 n=6}
_{Bind Time}	_{2.74s (± 0.38%)}	_{2.01s (± 0.87%)}	_{🟩-0.74s (-26.85%)}	_1.99s	_2.04s	_{p=0.004 n=6}
_{Check Time}	_{84.05s (± 0.27%)}	_{61.65s (± 0.24%)}	_{🟩-22.40s (-26.65%)}	_61.46s	_61.80s	_{p=0.005 n=6}
_{Emit Time}	_{0.16s (± 3.95%)}	_{0.17s (± 3.32%)}	_~	_0.16s	_0.17s	_{p=0.201 n=6}
_{Total Time}	_{94.84s (± 0.25%)}	_{73.09s (± 0.20%)}	_{🟩-21.74s (-22.93%)}	_72.91s	_73.21s	_{p=0.005 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,230,761	_1,240,272	_{+9,511 (+ 0.77%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,189	_261,013	_{-176 (- 0.07%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,356,206k (± 1.03%)}	_{2,678,211k (± 0.01%)}	_{🔻+322,005k (+13.67%)}	_2,677,639k	_2,678,592k	_{p=0.005 n=6}
_{Parse Time}	_{5.97s (± 0.40%)}	_{6.43s (± 0.99%)}	_{🔻+0.46s (+ 7.65%)}	_6.37s	_6.52s	_{p=0.005 n=6}
_{Bind Time}	_{2.26s (± 1.02%)}	_{2.03s (± 0.96%)}	_{🟩-0.23s (-10.32%)}	_2.01s	_2.06s	_{p=0.005 n=6}
_{Check Time}	_{39.74s (± 0.61%)}	_{32.39s (± 0.18%)}	_{🟩-7.36s (-18.51%)}	_32.33s	_32.45s	_{p=0.005 n=6}
_{Emit Time}	_{3.15s (± 4.19%)}	_{3.08s (± 0.87%)}	_~	_3.03s	_3.11s	_{p=0.470 n=6}
_{Total Time}	_{51.12s (± 0.68%)}	_{43.93s (± 0.21%)}	_{🟩-7.19s (-14.06%)}	_43.83s	_44.04s	_{p=0.005 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,230,761	_1,240,272	_{+9,511 (+ 0.77%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,189	_261,013	_{-176 (- 0.07%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,432,527k (± 0.98%)}	_{2,764,869k (± 0.02%)}	_{🔻+332,342k (+13.66%)}	_2,764,038k	_2,765,515k	_{p=0.005 n=6}
_{Parse Time}	_{6.20s (± 0.57%)}	_{6.54s (± 0.83%)}	_{🔻+0.34s (+ 5.43%)}	_6.45s	_6.60s	_{p=0.005 n=6}
_{Bind Time}	_{2.03s (± 1.22%)}	_{2.03s (± 0.51%)}	_~	_2.01s	_2.04s	_{p=1.000 n=6}
_{Check Time}	_{40.03s (± 0.32%)}	_{32.37s (± 0.20%)}	_{🟩-7.66s (-19.13%)}	_32.29s	_32.45s	_{p=0.005 n=6}
_{Emit Time}	_{3.22s (± 3.43%)}	_{3.08s (± 2.76%)}	_{🟩-0.14s (- 4.29%)}	_3.00s	_3.21s	_{p=0.031 n=6}
_{Total Time}	_{51.50s (± 0.30%)}	_{44.04s (± 0.29%)}	_{🟩-7.46s (-14.49%)}	_43.86s	_44.18s	_{p=0.005 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,573	_259,522	_{+949 (+ 0.37%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,819	_104,829	_{+10 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{428,188k (± 0.00%)}	_{495,625k (± 0.02%)}	_{🔻+67,437k (+15.75%)}	_495,502k	_495,768k	_{p=0.005 n=6}
_{Parse Time}	_{4.11s (± 0.70%)}	_{4.27s (± 0.67%)}	_{🔻+0.17s (+ 4.02%)}	_4.24s	_4.32s	_{p=0.005 n=6}
_{Bind Time}	_{1.63s (± 0.32%)}	_{1.48s (± 0.35%)}	_{🟩-0.14s (- 8.81%)}	_1.48s	_1.49s	_{p=0.004 n=6}
_{Check Time}	_{21.92s (± 0.29%)}	_{17.01s (± 0.45%)}	_{🟩-4.91s (-22.41%)}	_16.87s	_17.07s	_{p=0.005 n=6}
_{Emit Time}	_{1.72s (± 1.63%)}	_{1.68s (± 1.23%)}	_{-0.04s (- 2.22%)}	_1.65s	_1.71s	_{p=0.029 n=6}
_{Total Time}	_{29.38s (± 0.21%)}	_{24.44s (± 0.40%)}	_{🟩-4.94s (-16.80%)}	_24.27s	_24.51s	_{p=0.005 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,444k (± 0.02%)}	_{425,551k (± 0.01%)}	_{🔻+56,107k (+15.19%)}	_425,509k	_425,599k	_{p=0.005 n=6}
_{Parse Time}	_{2.76s (± 1.11%)}	_{3.12s (± 0.98%)}	_{🔻+0.36s (+12.96%)}	_3.09s	_3.17s	_{p=0.005 n=6}
_{Bind Time}	_{1.58s (± 0.87%)}	_{1.29s (± 0.40%)}	_{🟩-0.30s (-18.82%)}	_1.28s	_1.29s	_{p=0.004 n=6}
_{Check Time}	_{15.45s (± 0.44%)}	_{12.30s (± 0.34%)}	_{🟩-3.15s (-20.40%)}	_12.25s	_12.37s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.81s (± 0.39%)}	_{16.71s (± 0.36%)}	_{🟩-3.10s (-15.64%)}	_16.65s	_16.82s	_{p=0.005 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=NaN n=0}
_Symbols	₀	₀	_~	_~	_~	_{p=NaN n=0}
_Types	₀	₀	_~	_~	_~	_{p=NaN n=0}
_{Memory used}	_0k	_0k	_~	_~	_~	_{p=NaN n=0}
_{Parse Time}	_0s	_0s	_~	_~	_~	_{p=NaN n=0}
_{Bind Time}	_0s	_0s	_~	_~	_~	_{p=NaN n=0}
_{Check Time}	_0s	_0s	_~	_~	_~	_{p=NaN n=0}
_{Emit Time}	_0s	_0s	_~	_~	_~	_{p=NaN n=0}
_{Total Time}	_0s	_0s	_~	_~	_~	_{p=NaN n=0}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_266,926	_266,926	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,691	_108,691	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{411,270k (± 0.01%)}	_{464,212k (± 0.01%)}	_{🔻+52,942k (+12.87%)}	_464,168k	_464,328k	_{p=0.005 n=6}
_{Parse Time}	_{3.78s (± 0.22%)}	_{3.82s (± 0.67%)}	_{+0.04s (+ 1.10%)}	_3.78s	_3.86s	_{p=0.010 n=6}
_{Bind Time}	_{1.68s (± 0.31%)}	_{1.53s (± 0.55%)}	_{🟩-0.15s (- 9.05%)}	_1.51s	_1.53s	_{p=0.004 n=6}
_{Check Time}	_{16.77s (± 0.29%)}	_{14.04s (± 0.20%)}	_{🟩-2.73s (-16.28%)}	_14.00s	_14.07s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.22s (± 0.20%)}	_{19.38s (± 0.24%)}	_{🟩-2.84s (-12.78%)}	_19.33s	_19.46s	_{p=0.005 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_523,765	_523,765	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,055	_178,055	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{461,853k (± 0.09%)}	_{509,764k (± 0.07%)}	_{🔻+47,911k (+10.37%)}	_509,413k	_510,186k	_{p=0.005 n=6}
_{Parse Time}	_{2.64s (± 0.57%)}	_{2.90s (± 0.84%)}	_{🔻+0.26s (+10.06%)}	_2.87s	_2.94s	_{p=0.005 n=6}
_{Bind Time}	_{0.98s (± 0.56%)}	_{0.85s (± 0.48%)}	_{🟩-0.13s (-13.54%)}	_0.85s	_0.86s	_{p=0.003 n=6}
_{Check Time}	_{15.18s (± 0.41%)}	_{13.04s (± 0.29%)}	_{🟩-2.14s (-14.07%)}	_12.99s	_13.10s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{18.80s (± 0.35%)}	_{16.79s (± 0.30%)}	_{🟩-2.01s (-10.68%)}	_16.73s	_16.86s	_{p=0.005 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,279ms (± 0.67%)}	_{2,330ms (± 0.82%)}	_{+50ms (+ 2.21%)}	_2,293ms	_2,349ms	_{p=0.008 n=6}
_{Req 2 - geterr}	_{5,069ms (± 0.77%)}	_{4,282ms (± 1.34%)}	_{🟩-787ms (-15.52%)}	_4,166ms	_4,314ms	_{p=0.005 n=6}
_{Req 3 - references}	_{265ms (± 0.37%)}	_{267ms (± 0.70%)}	_~	_265ms	_270ms	_{p=0.082 n=6}
_{Req 4 - navto}	_{227ms (± 1.08%)}	_{227ms (± 0.77%)}	_~	_224ms	_229ms	_{p=0.493 n=6}
_{Req 5 - completionInfo count}	_1,357	_1,357	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{90ms (± 3.06%)}	_{84ms (± 7.70%)}	_~	_75ms	_92ms	_{p=0.165 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,394ms (± 0.46%)}	_{2,505ms (± 1.16%)}	_{🔻+111ms (+ 4.65%)}	_2,462ms	_2,546ms	_{p=0.005 n=6}
_{Req 2 - geterr}	_{3,791ms (± 0.28%)}	_{3,283ms (± 3.01%)}	_{🟩-509ms (-13.42%)}	_3,189ms	_3,385ms	_{p=0.005 n=6}
_{Req 3 - references}	_{275ms (± 0.15%)}	_{303ms (±10.57%)}	_{🔻+28ms (+ 9.99%)}	_281ms	_345ms	_{p=0.004 n=6}
_{Req 4 - navto}	_{227ms (± 0.23%)}	_{230ms (± 2.71%)}	_~	_226ms	_242ms	_{p=0.242 n=6}
_{Req 5 - completionInfo count}	_1,519	_1,519	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{69ms (± 0.75%)}	_{73ms (±10.64%)}	_~	_65ms	_82ms	_{p=0.367 n=6}
_{xstate-main-1-tsserver - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{5,189ms (± 0.44%)}	_{5,435ms (± 0.33%)}	_{🔻+246ms (+ 4.73%)}	_5,412ms	_5,462ms	_{p=0.005 n=6}
_{Req 2 - geterr}	_{1,123ms (± 0.98%)}	_{985ms (± 0.63%)}	_{🟩-138ms (-12.33%)}	_978ms	_994ms	_{p=0.005 n=6}
_{Req 3 - references}	_{76ms (± 0.99%)}	_{88ms (± 4.72%)}	_{🔻+12ms (+15.38%)}	_83ms	_95ms	_{p=0.004 n=6}
_{Req 4 - navto}	_{451ms (± 1.02%)}	_{331ms (± 0.76%)}	_{🟩-120ms (-26.63%)}	_328ms	_335ms	_{p=0.005 n=6}
_{Req 5 - completionInfo count}	_3,413	_3,413	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{837ms (± 1.47%)}	_{816ms (± 2.39%)}	_~	_801ms	_854ms	_{p=0.065 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstate-main-1-tsserver - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{157.49ms (± 0.16%)}	_{159.01ms (± 0.19%)}	_{+1.52ms (+ 0.97%)}	_157.99ms	_164.16ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{241.31ms (± 0.13%)}	_{234.00ms (± 0.15%)}	_{🟩-7.31ms (- 3.03%)}	_232.43ms	_240.65ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{236.15ms (± 0.15%)}	_{228.82ms (± 0.16%)}	_{🟩-7.33ms (- 3.11%)}	_227.29ms	_235.52ms	_{p=0.000 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{236.21ms (± 0.14%)}	_{228.64ms (± 0.16%)}	_{🟩-7.57ms (- 3.21%)}	_227.36ms	_233.70ms	_{p=0.000 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

src/services/transpile.ts

Andarist · 2024-06-19T16:56:31Z

This is the most green thing I've seen this week. Nice!!

MichaelMitchell-at · 2024-06-20T00:59:37Z

Unfortunately I didn't see a noticeable perf improvement in the Airtable code base, but did see a 5-10% increase in peak memory usage.

dragomirtitian · 2024-06-20T09:14:54Z

Unfortunately I didn't see a noticeable perf improvement in the Airtable code base, but did see a 5-10% increase in peak memory usage.

@MichaelMitchell-at i find this a bit surprising. While the % of difference varies, we've generally noticed improvements across the board. Is this a public repo? If it not, could you run the tsc on this branch through dexnode to get a report for the inline caches?

Also how did you measure the times? What is the output with - - diagnostics?

MichaelMitchell-at · 2024-06-20T16:17:59Z

Unfortunately I didn't see a noticeable perf improvement in the Airtable code base, but did see a 5-10% increase in peak memory usage.

@MichaelMitchell-at i find this a bit surprising. While the % of difference varies, we've generally noticed improvements across the board. Is this a public repo? If it not, could you run the tsc on this branch through dexnode to get a report for the inline caches?

Also how did you measure the times? What is the output with - - diagnostics?

Actually there seems to be an error with my methodology so throw out the previous result I mentioned. I can't seem to apply the patch cleanly at the moment. I'll just have to wait for this to reach nightly.

MichaelMitchell-at · 2024-06-20T17:16:28Z

Ok, I looked into it a bit more. Our custom runner uses the compiler API and that code path hasn't been updated to support the new node structure yet.

> const ts = require('./lib/typescript.js')
> ts.readConfigFile('src/tsconfig.json', ts.sys.readFile)
Uncaught Error: Debug Failure. False expression.
    at parseUpdateExpression (TypeScript/lib/typescript.js:37704:11)
    at parseUnaryExpressionOrHigher (/TypeScript/lib/typescript.js:37622:32)
    at parseBinaryExpressionOrHigher (TypeScript/lib/typescript.js:37544:25)
    at parseAssignmentExpressionOrHigher (TypeScript/lib/typescript.js:37215:18)

I should be able to get past this if I can swap out this part with a lib that can parse JSON with comments and trailing commas.

Edit: ts.transpileDeclaration has the same problem, so I just tried comparing build times without leveraging isolated declarations. Performance still seems about the same or even worse overall, particularly on smaller projects, < 10s to build. I'm running these in our CI pipeline for more consistent results. Anyway, I think I should just wait for this PR to be ready to preview and can try it out again then.

…megamorphism.

jakebailey · 2024-06-22T15:48:54Z

@typescript-bot perf test this

typescript-bot · 2024-06-22T15:48:58Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this`	✅ Started	👀 Results

typescript-bot · 2024-06-22T16:29:42Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,880k (± 0.74%)}	_{218,478k (± 0.63%)}	_{🔻+25,599k (+13.27%)}	_217,750k	_221,281k	_{p=0.005 n=6}
_{Parse Time}	_{1.57s (± 0.52%)}	_{1.63s (± 0.92%)}	_{+0.05s (+ 3.39%)}	_1.60s	_1.64s	_{p=0.005 n=6}
_{Bind Time}	_{0.85s (± 0.98%)}	_{0.81s (± 1.00%)}	_{🟩-0.04s (- 4.87%)}	_0.80s	_0.82s	_{p=0.004 n=6}
_{Check Time}	_{11.20s (± 0.56%)}	_{8.59s (± 1.04%)}	_{🟩-2.61s (-23.30%)}	_8.47s	_8.71s	_{p=0.005 n=6}
_{Emit Time}	_{3.30s (± 1.09%)}	_{2.81s (± 0.27%)}	_{🟩-0.49s (-14.75%)}	_2.80s	_2.82s	_{p=0.005 n=6}
_{Total Time}	_{16.93s (± 0.36%)}	_{13.84s (± 0.66%)}	_{🟩-3.09s (-18.26%)}	_13.73s	_13.96s	_{p=0.005 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,114	_944,114	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,051	_407,051	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,218,304k (± 0.00%)}	_{1,387,391k (± 0.00%)}	_{🔻+169,088k (+13.88%)}	_1,387,359k	_1,387,431k	_{p=0.005 n=6}
_{Parse Time}	_{7.98s (± 0.55%)}	_{8.05s (± 0.50%)}	_{+0.08s (+ 0.98%)}	_7.99s	_8.10s	_{p=0.024 n=6}
_{Bind Time}	_{2.22s (± 0.53%)}	_{1.91s (± 0.51%)}	_{🟩-0.31s (-13.82%)}	_1.90s	_1.92s	_{p=0.005 n=6}
_{Check Time}	_{35.68s (± 0.55%)}	_{27.28s (± 0.32%)}	_{🟩-8.40s (-23.55%)}	_27.16s	_27.40s	_{p=0.005 n=6}
_{Emit Time}	_{16.02s (± 0.80%)}	_{13.85s (± 0.49%)}	_{🟩-2.17s (-13.52%)}	_13.79s	_13.98s	_{p=0.005 n=6}
_{Total Time}	_{61.89s (± 0.28%)}	_{51.10s (± 0.16%)}	_{🟩-10.80s (-17.44%)}	_51.02s	_51.20s	_{p=0.005 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,134,511	_2,134,511	_~	_~	_~	_{p=1.000 n=6}
_Types	_927,068	_927,068	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,115,981k (± 0.01%)}	_{2,268,286k (± 0.00%)}	_{🔻+152,305k (+ 7.20%)}	_2,268,243k	_2,268,330k	_{p=0.005 n=6}
_{Parse Time}	_{7.85s (± 0.47%)}	_{8.97s (± 0.57%)}	_{🔻+1.12s (+14.26%)}	_8.92s	_9.05s	_{p=0.005 n=6}
_{Bind Time}	_{2.76s (± 0.81%)}	_{2.04s (± 0.78%)}	_{🟩-0.72s (-25.98%)}	_2.03s	_2.07s	_{p=0.005 n=6}
_{Check Time}	_{83.64s (± 0.46%)}	_{60.66s (± 0.47%)}	_{🟩-22.98s (-27.48%)}	_60.36s	_61.18s	_{p=0.005 n=6}
_{Emit Time}	_{0.16s (± 4.75%)}	_{0.16s (± 3.16%)}	_~	_0.16s	_0.17s	_{p=0.241 n=6}
_{Total Time}	_{94.41s (± 0.41%)}	_{71.83s (± 0.36%)}	_{🟩-22.58s (-23.91%)}	_71.60s	_72.31s	_{p=0.005 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,230,804	_1,246,592	_{+15,788 (+ 1.28%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,202	_263,541	_{+2,339 (+ 0.90%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,345,838k (± 0.05%)}	_{2,680,576k (± 0.01%)}	_{🔻+334,738k (+14.27%)}	_2,680,221k	_2,681,092k	_{p=0.005 n=6}
_{Parse Time}	_{6.01s (± 0.40%)}	_{6.19s (± 0.94%)}	_{+0.17s (+ 2.88%)}	_6.10s	_6.27s	_{p=0.005 n=6}
_{Bind Time}	_{2.26s (± 0.90%)}	_{2.06s (± 1.14%)}	_{🟩-0.20s (- 9.06%)}	_2.02s	_2.09s	_{p=0.005 n=6}
_{Check Time}	_{39.77s (± 0.39%)}	_{31.89s (± 0.43%)}	_{🟩-7.89s (-19.83%)}	_31.68s	_32.05s	_{p=0.005 n=6}
_{Emit Time}	_{3.24s (± 5.62%)}	_{3.07s (± 1.40%)}	_{🟩-0.17s (- 5.24%)}	_3.03s	_3.14s	_{p=0.037 n=6}
_{Total Time}	_{51.30s (± 0.24%)}	_{43.20s (± 0.48%)}	_{🟩-8.09s (-15.78%)}	_42.96s	_43.54s	_{p=0.005 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,230,804	_1,246,592	_{+15,788 (+ 1.28%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,202	_263,541	_{+2,339 (+ 0.90%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,422,778k (± 0.01%)}	_{2,777,844k (± 0.97%)}	_{🔻+355,066k (+14.66%)}	_2,765,961k	_2,832,701k	_{p=0.005 n=6}
_{Parse Time}	_{6.18s (± 0.77%)}	_{6.35s (± 0.89%)}	_{+0.17s (+ 2.81%)}	_6.29s	_6.44s	_{p=0.005 n=6}
_{Bind Time}	_{2.02s (± 0.40%)}	_{2.04s (± 0.40%)}	_{+0.03s (+ 1.32%)}	_2.03s	_2.05s	_{p=0.006 n=6}
_{Check Time}	_{40.12s (± 0.14%)}	_{31.84s (± 0.39%)}	_{🟩-8.29s (-20.65%)}	_31.60s	_31.92s	_{p=0.005 n=6}
_{Emit Time}	_{3.19s (± 1.81%)}	_{3.12s (± 2.29%)}	_~	_3.06s	_3.24s	_{p=0.108 n=6}
_{Total Time}	_{51.51s (± 0.26%)}	_{43.36s (± 0.32%)}	_{🟩-8.15s (-15.83%)}	_43.11s	_43.48s	_{p=0.005 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,574	_265,812	_{+7,238 (+ 2.80%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,825	_107,348	_{+2,523 (+ 2.41%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{428,178k (± 0.01%)}	_{499,567k (± 0.01%)}	_{🔻+71,389k (+16.67%)}	_499,538k	_499,615k	_{p=0.005 n=6}
_{Parse Time}	_{4.08s (± 0.34%)}	_{4.17s (± 1.06%)}	_{+0.09s (+ 2.12%)}	_4.11s	_4.24s	_{p=0.005 n=6}
_{Bind Time}	_{1.60s (± 0.83%)}	_{1.49s (± 0.69%)}	_{🟩-0.10s (- 6.57%)}	_1.48s	_1.51s	_{p=0.004 n=6}
_{Check Time}	_{21.94s (± 0.38%)}	_{16.74s (± 0.48%)}	_{🟩-5.19s (-23.67%)}	_16.64s	_16.84s	_{p=0.005 n=6}
_{Emit Time}	_{1.69s (± 1.45%)}	_{1.67s (± 1.58%)}	_~	_1.65s	_1.72s	_{p=0.062 n=6}
_{Total Time}	_{29.31s (± 0.29%)}	_{24.08s (± 0.51%)}	_{🟩-5.23s (-17.85%)}	_23.92s	_24.24s	_{p=0.005 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,562k (± 0.05%)}	_{425,386k (± 0.02%)}	_{🔻+55,825k (+15.11%)}	_425,266k	_425,443k	_{p=0.005 n=6}
_{Parse Time}	_{2.77s (± 1.29%)}	_{3.00s (± 1.32%)}	_{🔻+0.23s (+ 8.24%)}	_2.95s	_3.05s	_{p=0.005 n=6}
_{Bind Time}	_{1.58s (± 0.65%)}	_{1.28s (± 0.81%)}	_{🟩-0.31s (-19.37%)}	_1.26s	_1.29s	_{p=0.004 n=6}
_{Check Time}	_{15.47s (± 0.23%)}	_{11.99s (± 0.35%)}	_{🟩-3.48s (-22.50%)}	_11.91s	_12.03s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.83s (± 0.25%)}	_{16.27s (± 0.31%)}	_{🟩-3.56s (-17.96%)}	_16.20s	_16.33s	_{p=0.005 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁₃₉	₁₃₉	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,854,562	_2,854,562	_~	_~	_~	_{p=1.000 n=6}
_Types	_976,042	_976,042	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,045,619k (± 0.00%)}	_{3,455,715k (± 0.01%)}	_{🔻+410,097k (+13.47%)}	_3,455,517k	_3,456,128k	_{p=0.005 n=6}
_{Parse Time}	_{16.68s (± 0.11%)}	_{17.33s (± 0.38%)}	_{+0.66s (+ 3.94%)}	_17.23s	_17.42s	_{p=0.005 n=6}
_{Bind Time}	_{5.18s (± 0.31%)}	_{4.31s (± 0.35%)}	_{🟩-0.87s (-16.87%)}	_4.28s	_4.32s	_{p=0.005 n=6}
_{Check Time}	_{89.80s (± 0.21%)}	_{74.27s (± 0.40%)}	_{🟩-15.53s (-17.30%)}	_73.77s	_74.53s	_{p=0.005 n=6}
_{Emit Time}	_{29.26s (± 0.29%)}	_{27.54s (± 1.38%)}	_{🟩-1.72s (- 5.88%)}	_26.77s	_27.76s	_{p=0.005 n=6}
_{Total Time}	_{140.91s (± 0.13%)}	_{123.44s (± 0.31%)}	_{🟩-17.47s (-12.40%)}	_122.94s	_123.86s	_{p=0.005 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,117	_267,117	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,775	_108,775	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{411,507k (± 0.01%)}	_{464,374k (± 0.01%)}	_{🔻+52,867k (+12.85%)}	_464,315k	_464,477k	_{p=0.005 n=6}
_{Parse Time}	_{3.19s (± 0.38%)}	_{3.13s (± 0.27%)}	_{-0.06s (- 1.94%)}	_3.11s	_3.13s	_{p=0.004 n=6}
_{Bind Time}	_{1.41s (± 0.29%)}	_{1.29s (± 0.63%)}	_{🟩-0.12s (- 8.38%)}	_1.28s	_1.30s	_{p=0.003 n=6}
_{Check Time}	_{14.22s (± 0.14%)}	_{11.93s (± 0.53%)}	_{🟩-2.29s (-16.07%)}	_11.87s	_12.03s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{18.82s (± 0.12%)}	_{16.35s (± 0.32%)}	_{🟩-2.46s (-13.10%)}	_16.29s	_16.42s	_{p=0.005 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_525,251	_525,251	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,574	_178,574	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{462,883k (± 0.06%)}	_{510,721k (± 0.06%)}	_{🔻+47,839k (+10.33%)}	_510,404k	_511,148k	_{p=0.005 n=6}
_{Parse Time}	_{3.17s (± 0.53%)}	_{3.35s (± 1.01%)}	_{🔻+0.19s (+ 5.84%)}	_3.31s	_3.40s	_{p=0.005 n=6}
_{Bind Time}	_1.17s	_{1.07s (± 0.76%)}	_{🟩-0.10s (- 8.26%)}	_1.06s	_1.08s	_{p=0.003 n=6}
_{Check Time}	_{17.93s (± 0.39%)}	_{14.91s (± 0.29%)}	_{🟩-3.02s (-16.84%)}	_14.85s	_14.98s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.27s (± 0.34%)}	_{19.34s (± 0.30%)}	_{🟩-2.93s (-13.14%)}	_19.24s	_19.40s	_{p=0.005 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,295ms (± 0.74%)}	_{2,267ms (± 0.34%)}	_{-28ms (- 1.20%)}	_2,256ms	_2,278ms	_{p=0.031 n=6}
_{Req 2 - geterr}	_{5,081ms (± 0.40%)}	_{4,202ms (± 2.63%)}	_{🟩-879ms (-17.30%)}	_4,036ms	_4,289ms	_{p=0.005 n=6}
_{Req 3 - references}	_{264ms (± 0.32%)}	_{266ms (± 0.67%)}	_{+3ms (+ 0.95%)}	_264ms	_269ms	_{p=0.010 n=6}
_{Req 4 - navto}	_{229ms (± 0.53%)}	_{229ms (± 0.92%)}	_~	_227ms	_232ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_1,357	_1,357	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{85ms (± 6.42%)}	_{84ms (± 7.95%)}	_~	_73ms	_90ms	_{p=0.567 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,423ms (± 0.58%)}	_{2,435ms (± 0.11%)}	_~	_2,432ms	_2,439ms	_{p=0.261 n=6}
_{Req 2 - geterr}	_{3,792ms (± 0.35%)}	_{3,235ms (± 2.73%)}	_{🟩-557ms (-14.69%)}	_3,149ms	_3,324ms	_{p=0.005 n=6}
_{Req 3 - references}	_{278ms (± 0.30%)}	_{311ms (±11.03%)}	_{🔻+34ms (+12.19%)}	_278ms	_344ms	_{p=0.009 n=6}
_{Req 4 - navto}	_{226ms (± 0.48%)}	_{232ms (± 2.08%)}	_{+6ms (+ 2.73%)}	_227ms	_240ms	_{p=0.008 n=6}
_{Req 5 - completionInfo count}	_1,519	_1,519	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{73ms (± 8.47%)}	_{71ms (±10.26%)}	_~	_65ms	_82ms	_{p=0.371 n=6}
_{xstate-main-1-tsserver - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{5,182ms (± 0.44%)}	_{5,278ms (± 0.65%)}	_{+95ms (+ 1.84%)}	_5,223ms	_5,326ms	_{p=0.005 n=6}
_{Req 2 - geterr}	_{1,126ms (± 0.94%)}	_{961ms (± 0.57%)}	_{🟩-165ms (-14.63%)}	_952ms	_966ms	_{p=0.005 n=6}
_{Req 3 - references}	_{77ms (± 3.85%)}	_{89ms (± 4.52%)}	_{🔻+12ms (+15.37%)}	_86ms	_94ms	_{p=0.004 n=6}
_{Req 4 - navto}	_{458ms (± 0.97%)}	_{331ms (± 0.59%)}	_{🟩-127ms (-27.72%)}	_329ms	_334ms	_{p=0.005 n=6}
_{Req 5 - completionInfo count}	_3,413	_3,413	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{841ms (± 0.65%)}	_{813ms (± 1.56%)}	_{🟩-28ms (- 3.37%)}	_797ms	_827ms	_{p=0.005 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstate-main-1-tsserver - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{157.10ms (± 0.17%)}	_{158.58ms (± 0.18%)}	_{+1.47ms (+ 0.94%)}	_157.45ms	_162.49ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{232.57ms (± 0.14%)}	_{234.34ms (± 0.15%)}	_{+1.77ms (+ 0.76%)}	_232.98ms	_240.10ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{227.61ms (± 0.17%)}	_{229.21ms (± 0.13%)}	_{+1.60ms (+ 0.71%)}	_227.88ms	_231.89ms	_{p=0.000 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{225.93ms (± 0.17%)}	_{227.60ms (± 0.15%)}	_{+1.67ms (+ 0.74%)}	_226.24ms	_234.18ms	_{p=0.000 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

dragomirtitian · 2024-06-22T18:01:31Z

Latest perf results seemed to have clawed back most of the parser perf loss.

jakebailey · 2024-06-22T19:36:38Z

Half a gig of memory for vscode is a bit scary, though, given how close that is to the max memory limit...

…node to reduce memory usage.

dragomirtitian · 2024-06-24T11:04:53Z

@jakebailey I did some extra work. I was too eager to make everything monomorphic, a bit of polymorphism is fine. There should be 3 shapes for nodes now: Token, Identifier and Node. There is a 4th one Token with original that I might look into removing, but it doesn't seem to have much impact for now.

With these changes, at least locally the increase in mem usage goes form 13% to about 5%, while keeping the same performance profile.

jakebailey · 2024-06-24T13:36:24Z

@typescript-bot perf test this

typescript-bot · 2024-06-24T13:36:28Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this`	✅ Started	👀 Results

typescript-bot · 2024-06-24T14:17:07Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,924k (± 1.03%)}	_{204,029k (± 0.91%)}	_{🔻+10,104k (+ 5.21%)}	_202,782k	_206,426k	_{p=0.005 n=6}
_{Parse Time}	_{1.58s (± 1.03%)}	_{1.62s (± 0.64%)}	_{+0.03s (+ 2.11%)}	_1.60s	_1.63s	_{p=0.007 n=6}
_{Bind Time}	_{0.86s (± 1.20%)}	_{0.86s (± 0.60%)}	_~	_0.86s	_0.87s	_{p=0.793 n=6}
_{Check Time}	_{11.22s (± 0.24%)}	_{8.94s (± 1.08%)}	_{🟩-2.28s (-20.33%)}	_8.87s	_9.11s	_{p=0.005 n=6}
_{Emit Time}	_{3.27s (± 0.63%)}	_{3.16s (± 0.97%)}	_{🟩-0.11s (- 3.41%)}	_3.13s	_3.21s	_{p=0.005 n=6}
_{Total Time}	_{16.93s (± 0.27%)}	_{14.58s (± 0.61%)}	_{🟩-2.35s (-13.91%)}	_14.48s	_14.74s	_{p=0.005 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,114	_944,114	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,051	_407,051	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,218,281k (± 0.00%)}	_{1,295,371k (± 0.00%)}	_{🔻+77,089k (+ 6.33%)}	_1,295,310k	_1,295,431k	_{p=0.005 n=6}
_{Parse Time}	_{7.94s (± 0.30%)}	_{8.31s (± 0.97%)}	_{🔻+0.37s (+ 4.64%)}	_8.22s	_8.44s	_{p=0.005 n=6}
_{Bind Time}	_{2.23s (± 0.34%)}	_{2.07s (± 0.59%)}	_{🟩-0.15s (- 6.88%)}	_2.05s	_2.08s	_{p=0.003 n=6}
_{Check Time}	_{35.77s (± 0.27%)}	_{29.04s (± 0.36%)}	_{🟩-6.72s (-18.79%)}	_28.86s	_29.13s	_{p=0.005 n=6}
_{Emit Time}	_{16.11s (± 0.56%)}	_{14.93s (± 0.49%)}	_{🟩-1.18s (- 7.31%)}	_14.84s	_15.03s	_{p=0.005 n=6}
_{Total Time}	_{62.04s (± 0.21%)}	_{54.37s (± 0.37%)}	_{🟩-7.68s (-12.37%)}	_54.01s	_54.58s	_{p=0.005 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,135,122	_2,135,122	_~	_~	_~	_{p=1.000 n=6}
_Types	_927,182	_927,182	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,117,373k (± 0.01%)}	_{2,199,492k (± 0.00%)}	_{+82,119k (+ 3.88%)}	_2,199,411k	_2,199,584k	_{p=0.005 n=6}
_{Parse Time}	_{7.92s (± 0.35%)}	_{8.29s (± 2.32%)}	_{🔻+0.37s (+ 4.67%)}	_8.19s	_8.68s	_{p=0.005 n=6}
_{Bind Time}	_{2.77s (± 0.70%)}	_{2.71s (± 8.48%)}	_~	_2.24s	_2.82s	_{p=0.332 n=6}
_{Check Time}	_{83.86s (± 0.39%)}	_{62.40s (± 0.60%)}	_{🟩-21.46s (-25.59%)}	_62.04s	_63.08s	_{p=0.005 n=6}
_{Emit Time}	_{0.15s (± 3.53%)}	_{0.16s (± 3.16%)}	_{🔻+0.01s (+ 5.38%)}	_0.16s	_0.17s	_{p=0.038 n=6}
_{Total Time}	_{94.71s (± 0.31%)}	_{73.56s (± 0.50%)}	_{🟩-21.15s (-22.33%)}	_73.23s	_74.24s	_{p=0.005 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,230,804	_1,246,046	_{+15,242 (+ 1.24%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,202	_263,618	_{+2,416 (+ 0.92%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,356,275k (± 1.03%)}	_{2,474,466k (± 0.03%)}	_{🔻+118,192k (+ 5.02%)}	_2,473,593k	_2,475,488k	_{p=0.005 n=6}
_{Parse Time}	_{5.95s (± 0.85%)}	_{6.47s (± 1.03%)}	_{🔻+0.52s (+ 8.77%)}	_6.37s	_6.55s	_{p=0.005 n=6}
_{Bind Time}	_{2.25s (± 0.83%)}	_{2.25s (± 0.76%)}	_~	_2.23s	_2.27s	_{p=0.936 n=6}
_{Check Time}	_{39.81s (± 0.32%)}	_{33.41s (± 0.36%)}	_{🟩-6.39s (-16.06%)}	_33.30s	_33.57s	_{p=0.005 n=6}
_{Emit Time}	_{3.13s (± 1.38%)}	_{3.58s (± 1.59%)}	_{🔻+0.45s (+14.35%)}	_3.52s	_3.66s	_{p=0.005 n=6}
_{Total Time}	_{51.15s (± 0.36%)}	_{45.73s (± 0.30%)}	_{🟩-5.42s (-10.59%)}	_45.54s	_45.90s	_{p=0.005 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,230,804	_1,246,046	_{+15,242 (+ 1.24%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,202	_263,618	_{+2,416 (+ 0.92%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,422,330k (± 0.05%)}	_{2,577,288k (± 0.03%)}	_{🔻+154,958k (+ 6.40%)}	_2,576,002k	_2,578,462k	_{p=0.005 n=6}
_{Parse Time}	_{7.77s (± 0.89%)}	_{8.17s (± 0.65%)}	_{🔻+0.41s (+ 5.24%)}	_8.08s	_8.24s	_{p=0.005 n=6}
_{Bind Time}	_{2.52s (± 1.06%)}	_{2.82s (± 0.76%)}	_{🔻+0.31s (+12.12%)}	_2.80s	_2.86s	_{p=0.005 n=6}
_{Check Time}	_{49.53s (± 0.39%)}	_{41.40s (± 0.28%)}	_{🟩-8.14s (-16.43%)}	_41.19s	_41.52s	_{p=0.005 n=6}
_{Emit Time}	_{3.92s (± 3.67%)}	_{4.52s (± 3.31%)}	_{🔻+0.60s (+15.21%)}	_4.34s	_4.72s	_{p=0.005 n=6}
_{Total Time}	_{63.76s (± 0.48%)}	_{56.92s (± 0.39%)}	_{🟩-6.84s (-10.72%)}	_56.68s	_57.25s	_{p=0.005 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,574	_265,896	_{+7,322 (+ 2.83%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,825	_107,377	_{+2,552 (+ 2.43%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{428,212k (± 0.02%)}	_{459,220k (± 0.01%)}	_{🔻+31,008k (+ 7.24%)}	_459,199k	_459,271k	_{p=0.005 n=6}
_{Parse Time}	_{3.31s (± 0.60%)}	_{3.46s (± 0.75%)}	_{🔻+0.15s (+ 4.53%)}	_3.43s	_3.50s	_{p=0.005 n=6}
_{Bind Time}	_{1.31s (± 1.67%)}	_{1.30s (± 0.93%)}	_~	_1.28s	_1.31s	_{p=0.324 n=6}
_{Check Time}	_{17.74s (± 0.27%)}	_{14.40s (± 0.55%)}	_{🟩-3.34s (-18.84%)}	_14.31s	_14.52s	_{p=0.005 n=6}
_{Emit Time}	_{1.36s (± 2.21%)}	_{1.65s (± 2.02%)}	_{🔻+0.28s (+20.63%)}	_1.58s	_1.67s	_{p=0.004 n=6}
_{Total Time}	_{23.73s (± 0.33%)}	_{20.80s (± 0.34%)}	_{🟩-2.93s (-12.35%)}	_20.73s	_20.91s	_{p=0.005 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,410k (± 0.01%)}	_{390,898k (± 0.01%)}	_{🔻+21,488k (+ 5.82%)}	_390,854k	_390,974k	_{p=0.005 n=6}
_{Parse Time}	_{2.77s (± 1.06%)}	_{3.05s (± 0.88%)}	_{🔻+0.28s (+10.17%)}	_3.03s	_3.10s	_{p=0.005 n=6}
_{Bind Time}	_{1.58s (± 0.98%)}	_{1.38s (± 1.74%)}	_{🟩-0.20s (-12.55%)}	_1.37s	_1.43s	_{p=0.004 n=6}
_{Check Time}	_{15.41s (± 0.23%)}	_{12.68s (± 0.15%)}	_{🟩-2.73s (-17.69%)}	_12.66s	_12.72s	_{p=0.004 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.76s (± 0.31%)}	_{17.12s (± 0.19%)}	_{🟩-2.64s (-13.37%)}	_17.09s	_17.16s	_{p=0.005 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,880,886	_2,880,886	_~	_~	_~	_{p=1.000 n=6}
_Types	_975,501	_975,501	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,042,328k (± 0.00%)}	_{3,227,789k (± 0.00%)}	_{🔻+185,461k (+ 6.10%)}	_3,227,714k	_3,227,862k	_{p=0.005 n=6}
_{Parse Time}	_{16.73s (± 0.68%)}	_{17.61s (± 0.44%)}	_{🔻+0.89s (+ 5.29%)}	_17.50s	_17.69s	_{p=0.005 n=6}
_{Bind Time}	_{5.10s (± 0.26%)}	_{4.61s (± 1.15%)}	_{🟩-0.49s (- 9.64%)}	_4.52s	_4.67s	_{p=0.005 n=6}
_{Check Time}	_{88.86s (± 0.39%)}	_{78.07s (± 0.23%)}	_{🟩-10.79s (-12.14%)}	_77.85s	_78.35s	_{p=0.005 n=6}
_{Emit Time}	_{29.21s (± 0.50%)}	_{23.23s (± 0.37%)}	_{🟩-5.98s (-20.47%)}	_23.16s	_23.38s	_{p=0.005 n=6}
_{Total Time}	_{139.90s (± 0.35%)}	_{123.52s (± 0.12%)}	_{🟩-16.38s (-11.71%)}	_123.30s	_123.73s	_{p=0.005 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,117	_267,117	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,775	_108,775	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{411,548k (± 0.01%)}	_{434,675k (± 0.01%)}	_{🔻+23,126k (+ 5.62%)}	_434,608k	_434,733k	_{p=0.005 n=6}
_{Parse Time}	_{3.18s (± 0.65%)}	_{3.27s (± 0.23%)}	_{+0.10s (+ 2.99%)}	_3.26s	_3.28s	_{p=0.005 n=6}
_{Bind Time}	_{1.41s (± 0.53%)}	_{1.44s (± 0.52%)}	_{+0.03s (+ 1.89%)}	_1.43s	_1.45s	_{p=0.004 n=6}
_{Check Time}	_{14.19s (± 0.34%)}	_{12.72s (± 0.33%)}	_{🟩-1.47s (-10.34%)}	_12.66s	_12.79s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{18.77s (± 0.26%)}	_{17.43s (± 0.22%)}	_{🟩-1.34s (- 7.16%)}	_17.38s	_17.49s	_{p=0.005 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_525,251	_525,251	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,574	_178,574	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{462,712k (± 0.09%)}	_{484,265k (± 0.06%)}	_{🔻+21,553k (+ 4.66%)}	_484,094k	_484,872k	_{p=0.005 n=6}
_{Parse Time}	_{3.17s (± 0.61%)}	_{3.26s (± 0.71%)}	_{+0.09s (+ 2.84%)}	_3.23s	_3.29s	_{p=0.005 n=6}
_{Bind Time}	_{1.17s (± 1.16%)}	_{1.15s (± 0.45%)}	_{-0.02s (- 1.70%)}	_1.15s	_1.16s	_{p=0.006 n=6}
_{Check Time}	_{17.86s (± 0.50%)}	_{15.47s (± 0.23%)}	_{🟩-2.38s (-13.35%)}	_15.44s	_15.53s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.20s (± 0.38%)}	_{19.88s (± 0.23%)}	_{🟩-2.31s (-10.41%)}	_19.82s	_19.94s	_{p=0.005 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,290ms (± 0.81%)}	_{2,375ms (± 0.75%)}	_{+85ms (+ 3.71%)}	_2,353ms	_2,397ms	_{p=0.005 n=6}
_{Req 2 - geterr}	_{5,068ms (± 0.29%)}	_{4,364ms (± 0.26%)}	_{🟩-704ms (-13.89%)}	_4,351ms	_4,379ms	_{p=0.005 n=6}
_{Req 3 - references}	_{264ms (± 0.71%)}	_{273ms (± 0.43%)}	_{+9ms (+ 3.54%)}	_271ms	_274ms	_{p=0.005 n=6}
_{Req 4 - navto}	_{228ms (± 1.30%)}	_{238ms (± 0.65%)}	_{🔻+11ms (+ 4.62%)}	_237ms	_241ms	_{p=0.004 n=6}
_{Req 5 - completionInfo count}	_1,357	_1,357	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{87ms (± 5.20%)}	_{88ms (± 8.94%)}	_~	_78ms	_94ms	_{p=0.459 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,418ms (± 0.70%)}	_{2,517ms (± 0.72%)}	_{🔻+99ms (+ 4.10%)}	_2,495ms	_2,549ms	_{p=0.005 n=6}
_{Req 2 - geterr}	_{3,801ms (± 0.34%)}	_{3,355ms (± 0.12%)}	_{🟩-446ms (-11.73%)}	_3,349ms	_3,361ms	_{p=0.005 n=6}
_{Req 3 - references}	_{278ms (± 0.38%)}	_{290ms (± 0.29%)}	_{🔻+12ms (+ 4.32%)}	_289ms	_291ms	_{p=0.004 n=6}
_{Req 4 - navto}	_225ms	_{235ms (± 0.23%)}	_{🔻+10ms (+ 4.22%)}	_234ms	_235ms	_{p=0.002 n=6}
_{Req 5 - completionInfo count}	_1,519	_1,519	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{73ms (± 2.05%)}	_71ms	_{🟩-2ms (- 3.18%)}	_~	_~	_{p=0.003 n=6}
_{xstate-main-1-tsserver - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{5,201ms (± 0.50%)}	_{5,336ms (± 0.40%)}	_{+135ms (+ 2.60%)}	_5,318ms	_5,375ms	_{p=0.005 n=6}
_{Req 2 - geterr}	_{1,115ms (± 0.94%)}	_{974ms (± 0.34%)}	_{🟩-142ms (-12.70%)}	_970ms	_978ms	_{p=0.005 n=6}
_{Req 3 - references}	_76ms	_{98ms (± 3.70%)}	_{🔻+22ms (+28.51%)}	_96ms	_105ms	_{p=0.002 n=6}
_{Req 4 - navto}	_{456ms (± 0.18%)}	_{372ms (± 0.15%)}	_{🟩-84ms (-18.47%)}	_371ms	_372ms	_{p=0.004 n=6}
_{Req 5 - completionInfo count}	_3,413	_3,413	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{836ms (± 1.23%)}	_{822ms (± 1.36%)}	_{-14ms (- 1.71%)}	_810ms	_835ms	_{p=0.045 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstate-main-1-tsserver - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{157.09ms (± 0.18%)}	_{158.79ms (± 0.17%)}	_{+1.70ms (+ 1.08%)}	_157.67ms	_162.61ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{232.76ms (± 0.14%)}	_{234.79ms (± 0.13%)}	_{+2.03ms (+ 0.87%)}	_233.60ms	_239.68ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{226.59ms (± 0.15%)}	_{228.50ms (± 0.14%)}	_{+1.91ms (+ 0.84%)}	_227.22ms	_231.79ms	_{p=0.000 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{226.60ms (± 0.15%)}	_{228.70ms (± 0.13%)}	_{+2.09ms (+ 0.92%)}	_227.38ms	_230.95ms	_{p=0.000 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

jakebailey · 2024-06-24T14:35:05Z

Much better, though emit is now much slower on certain benchmarks. Maybe a case or two aren't monomorphic for those benchmarks?

dragomirtitian · 2024-06-24T14:46:29Z

For the extra parse time I have a pretty good idea. TextRange has too many shapes. Beyond the 3 AST nodes, we also have at least 2 if not more that come from createNodeArray making setting of positions much more expensive in some cases.

Will look into it a bit more.

typescript-bot · 2024-06-24T19:07:46Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this faster [email protected]`	✅ Started	👀 Results

typescript-bot · 2024-06-24T19:38:18Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - bun (v1.1.16, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{240,941k (± 0.78%)}	_{267,863k (± 0.91%)}	_{🔻+26,923k (+11.17%)}	_266,127k	_272,473k	_{p=0.005 n=6}
_{Parse Time}	_{1.09s (± 1.68%)}	_{1.12s (± 1.46%)}	_~	_1.11s	_1.15s	_{p=0.081 n=6}
_{Bind Time}	_{0.83s (± 1.40%)}	_{0.89s (± 2.13%)}	_{🔻+0.06s (+ 7.01%)}	_0.87s	_0.91s	_{p=0.005 n=6}
_{Check Time}	_{8.67s (± 0.58%)}	_{8.51s (± 1.73%)}	_~	_8.35s	_8.71s	_{p=0.077 n=6}
_{Emit Time}	_{2.86s (± 0.58%)}	_{2.80s (± 2.06%)}	_~	_2.73s	_2.88s	_{p=0.121 n=6}
_{Total Time}	_{13.45s (± 0.38%)}	_{13.33s (± 0.74%)}	_~	_13.24s	_13.49s	_{p=0.063 n=6}
_{angular-1 - bun (v1.1.16, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,114	_944,114	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,051	_407,051	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,280,009k (± 0.42%)}	_{1,439,785k (± 0.06%)}	_{🔻+159,776k (+12.48%)}	_1,438,296k	_1,441,038k	_{p=0.005 n=6}
_{Parse Time}	_{4.74s (± 0.65%)}	_{4.89s (± 0.60%)}	_{+0.16s (+ 3.31%)}	_4.86s	_4.93s	_{p=0.005 n=6}
_{Bind Time}	_{1.96s (± 1.24%)}	_{1.87s (± 3.66%)}	_{🟩-0.09s (- 4.60%)}	_1.77s	_1.95s	_{p=0.030 n=6}
_{Check Time}	_{29.59s (± 0.97%)}	_{25.80s (± 0.78%)}	_{🟩-3.78s (-12.78%)}	_25.57s	_26.04s	_{p=0.005 n=6}
_{Emit Time}	_{11.26s (± 0.89%)}	_{10.53s (± 2.51%)}	_{🟩-0.73s (- 6.49%)}	_10.30s	_10.91s	_{p=0.005 n=6}
_{Total Time}	_{47.53s (± 0.81%)}	_{43.09s (± 0.82%)}	_{🟩-4.44s (- 9.33%)}	_42.68s	_43.55s	_{p=0.005 n=6}
_{mui-docs - bun (v1.1.16, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,135,096	_2,135,096	_~	_~	_~	_{p=1.000 n=6}
_Types	_927,167	_927,167	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,315,693k (± 0.41%)}	_{2,424,163k (± 0.19%)}	_{🔻+108,470k (+ 4.68%)}	_2,417,659k	_2,431,760k	_{p=0.005 n=6}
_{Parse Time}	_{5.45s (± 0.42%)}	_{5.80s (± 0.32%)}	_{🔻+0.35s (+ 6.42%)}	_5.78s	_5.82s	_{p=0.005 n=6}
_{Bind Time}	_{1.52s (± 1.89%)}	_{1.72s (± 1.81%)}	_{🔻+0.20s (+13.02%)}	_1.69s	_1.77s	_{p=0.005 n=6}
_{Check Time}	_{64.78s (± 0.63%)}	_{53.41s (± 0.45%)}	_{🟩-11.38s (-17.56%)}	_53.14s	_53.79s	_{p=0.005 n=6}
_{Emit Time}	_{0.15s (± 3.52%)}	_{0.15s (± 2.69%)}	_~	_0.15s	_0.16s	_{p=0.114 n=6}
_{Total Time}	_{71.91s (± 0.52%)}	_{61.08s (± 0.39%)}	_{🟩-10.83s (-15.06%)}	_60.79s	_61.42s	_{p=0.005 n=6}
_{self-build-src - bun (v1.1.16, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,230,971	_1,246,104	_{+15,133 (+ 1.23%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,249	_263,571	_{+2,322 (+ 0.89%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{9,240,404k (± 1.28%)}	_{9,990,275k (± 3.90%)}	_{🔻+749,872k (+ 8.12%)}	_9,473,334k	_10,255,475k	_{p=0.005 n=6}
_{Parse Time}	_{4.85s (± 0.94%)}	_{5.03s (± 2.30%)}	_{+0.18s (+ 3.68%)}	_4.86s	_5.15s	_{p=0.013 n=6}
_{Bind Time}	_{2.04s (± 2.23%)}	_{2.15s (± 1.52%)}	_{🔻+0.11s (+ 5.41%)}	_2.10s	_2.20s	_{p=0.008 n=6}
_{Check Time}	_{36.98s (± 0.41%)}	_{34.73s (± 4.91%)}	_{🟩-2.26s (- 6.10%)}	_32.44s	_35.97s	_{p=0.005 n=6}
_{Emit Time}	_{2.12s (± 1.99%)}	_{2.11s (± 1.34%)}	_~	_2.08s	_2.16s	_{p=0.521 n=6}
_{Total Time}	_{46.02s (± 0.34%)}	_{44.02s (± 4.16%)}	_{🟩-2.00s (- 4.34%)}	_41.59s	_45.38s	_{p=0.005 n=6}
_{self-build-src-public-api - bun (v1.1.16, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,230,971	_1,246,104	_{+15,133 (+ 1.23%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,249	_263,571	_{+2,322 (+ 0.89%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{4,058,764k (± 0.36%)}	_{6,201,822k (± 2.52%)}	_{🔻+2,143,057k (+52.80%)}	_5,992,401k	_6,401,909k	_{p=0.005 n=6}
_{Parse Time}	_{3.91s (± 0.69%)}	_{4.17s (± 1.86%)}	_{🔻+0.26s (+ 6.56%)}	_4.06s	_4.24s	_{p=0.005 n=6}
_{Bind Time}	_{1.81s (± 2.35%)}	_{1.77s (± 1.63%)}	_~	_1.72s	_1.80s	_{p=0.109 n=6}
_{Check Time}	_{34.99s (± 0.33%)}	_{31.86s (± 0.60%)}	_{🟩-3.13s (- 8.93%)}	_31.63s	_32.16s	_{p=0.005 n=6}
_{Emit Time}	_{1.72s (± 0.70%)}	_{2.23s (± 2.29%)}	_{🔻+0.52s (+30.10%)}	_2.18s	_2.31s	_{p=0.005 n=6}
_{Total Time}	_{42.44s (± 0.24%)}	_{40.05s (± 0.63%)}	_{🟩-2.39s (- 5.64%)}	_39.74s	_40.38s	_{p=0.005 n=6}
_{self-compiler - bun (v1.1.16, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,575	_265,755	_{+7,180 (+ 2.78%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,825	_107,283	_{+2,458 (+ 2.34%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{425,676k (± 0.36%)}	_{465,396k (± 1.36%)}	_{🔻+39,720k (+ 9.33%)}	_459,666k	_474,121k	_{p=0.005 n=6}
_{Parse Time}	_{2.65s (± 1.37%)}	_{2.68s (± 0.64%)}	_~	_2.66s	_2.70s	_{p=0.144 n=6}
_{Bind Time}	_{1.32s (± 1.51%)}	_{1.45s (± 1.65%)}	_{🔻+0.13s (+ 9.97%)}	_1.43s	_1.49s	_{p=0.005 n=6}
_{Check Time}	_{16.64s (± 0.44%)}	_{16.06s (± 0.72%)}	_{🟩-0.59s (- 3.53%)}	_15.90s	_16.22s	_{p=0.005 n=6}
_{Emit Time}	_{1.02s (± 1.68%)}	_{1.10s (± 1.94%)}	_{🔻+0.08s (+ 7.83%)}	_1.08s	_1.13s	_{p=0.005 n=6}
_{Total Time}	_{21.64s (± 0.36%)}	_{21.28s (± 0.60%)}	_{-0.35s (- 1.63%)}	_21.14s	_21.44s	_{p=0.005 n=6}
_{ts-pre-modules - bun (v1.1.16, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{355,450k (± 0.37%)}	_{390,085k (± 0.25%)}	_{🔻+34,635k (+ 9.74%)}	_388,880k	_391,641k	_{p=0.005 n=6}
_{Parse Time}	_{2.33s (± 2.05%)}	_{2.37s (± 1.14%)}	_~	_2.34s	_2.41s	_{p=0.064 n=6}
_{Bind Time}	_{1.43s (± 0.93%)}	_{1.67s (± 2.92%)}	_{🔻+0.24s (+16.80%)}	_1.61s	_1.73s	_{p=0.004 n=6}
_{Check Time}	_{14.38s (± 0.41%)}	_{13.79s (± 0.59%)}	_{🟩-0.58s (- 4.07%)}	_13.72s	_13.94s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{18.13s (± 0.55%)}	_{17.83s (± 0.57%)}	_{-0.30s (- 1.67%)}	_17.75s	_18.00s	_{p=0.008 n=6}
_{vscode - bun (v1.1.16, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,881,167	_2,881,167	_~	_~	_~	_{p=1.000 n=6}
_Types	_975,641	_975,641	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,114,497k (± 0.51%)}	_{3,448,766k (± 0.46%)}	_{🔻+334,270k (+10.73%)}	_3,425,712k	_3,461,890k	_{p=0.005 n=6}
_{Parse Time}	_{10.94s (± 0.39%)}	_{10.84s (± 0.38%)}	_{-0.11s (- 0.96%)}	_10.78s	_10.90s	_{p=0.006 n=6}
_{Bind Time}	_{3.67s (± 1.66%)}	_{4.17s (± 1.26%)}	_{🔻+0.50s (+13.68%)}	_4.10s	_4.25s	_{p=0.005 n=6}
_{Check Time}	_{65.48s (± 0.55%)}	_{55.24s (± 0.30%)}	_{🟩-10.24s (-15.64%)}	_55.05s	_55.50s	_{p=0.005 n=6}
_{Emit Time}	_{20.42s (± 0.11%)}	_{18.89s (± 1.02%)}	_{🟩-1.53s (- 7.48%)}	_18.72s	_19.20s	_{p=0.005 n=6}
_{Total Time}	_{100.51s (± 0.33%)}	_{89.14s (± 0.11%)}	_{🟩-11.37s (-11.31%)}	_88.95s	_89.21s	_{p=0.005 n=6}
_{webpack - bun (v1.1.16, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,117	_267,117	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,775	_108,775	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{429,565k (± 0.17%)}	_{447,606k (± 0.76%)}	_{🔻+18,041k (+ 4.20%)}	_445,233k	_454,361k	_{p=0.005 n=6}
_{Parse Time}	_{3.79s (± 1.19%)}	_{3.95s (± 0.99%)}	_{🔻+0.16s (+ 4.22%)}	_3.90s	_4.00s	_{p=0.005 n=6}
_{Bind Time}	_{1.70s (± 1.61%)}	_{2.03s (± 2.38%)}	_{🔻+0.34s (+19.84%)}	_1.95s	_2.09s	_{p=0.005 n=6}
_{Check Time}	_{16.86s (± 0.36%)}	_{16.46s (± 0.51%)}	_{-0.39s (- 2.31%)}	_16.36s	_16.58s	_{p=0.005 n=6}
_{Emit Time}	_0.01s	_0.00s	_{🟩-0.01s (-100.00%)}	_~	_~	_{p=0.001 n=6}
_{Total Time}	_{22.35s (± 0.29%)}	_{22.45s (± 0.31%)}	_{+0.11s (+ 0.48%)}	_22.38s	_22.58s	_{p=0.037 n=6}
_{xstate-main - bun (v1.1.16, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_525,251	_525,251	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,574	_178,574	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{462,124k (± 0.45%)}	_{440,541k (± 0.60%)}	_{🟩-21,584k (- 4.67%)}	_438,169k	_445,081k	_{p=0.005 n=6}
_{Parse Time}	_{2.70s (± 1.08%)}	_{2.85s (± 1.19%)}	_{🔻+0.15s (+ 5.44%)}	_2.81s	_2.90s	_{p=0.005 n=6}
_{Bind Time}	_{1.05s (± 5.19%)}	_{1.02s (± 1.34%)}	_~	_1.01s	_1.05s	_{p=0.145 n=6}
_{Check Time}	_{15.88s (± 0.33%)}	_{15.93s (± 0.75%)}	_~	_15.76s	_16.08s	_{p=0.289 n=6}
_{Emit Time}	_0.00s	_{0.02s (±148.17%)}	_{🔻+0.02s (+ ∞%)}	_0.00s	_0.08s	_{p=0.008 n=6}
_{Total Time}	_{19.63s (± 0.45%)}	_{19.81s (± 0.53%)}	_{+0.18s (+ 0.93%)}	_19.70s	_19.99s	_{p=0.013 n=6}

System info unknown

Hosts

bun (v1.1.16, x64)

Scenarios

Compiler-Unions - bun (v1.1.16, x64)
angular-1 - bun (v1.1.16, x64)
mui-docs - bun (v1.1.16, x64)
self-build-src - bun (v1.1.16, x64)
self-build-src-public-api - bun (v1.1.16, x64)
self-compiler - bun (v1.1.16, x64)
ts-pre-modules - bun (v1.1.16, x64)
vscode - bun (v1.1.16, x64)
webpack - bun (v1.1.16, x64)
xstate-main - bun (v1.1.16, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

jakebailey · 2024-06-24T20:26:05Z

@typescript-bot perf test this faster [email protected] commits=aa249c094b9b96c86025e964469ed4c803190cca...977cbc5

typescript-bot · 2024-06-24T20:26:09Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this faster [email protected] commits=aa249c094b9b96c86025e964469ed4c803190cca...977cbc5c8a01330fb3e691d6d7601ecdcd478f38`	✅ Started	👀 Results

typescript-bot · 2024-06-24T21:01:54Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - aa249c0..977cbc5

_Metric	_aa249c0	_977cbc5	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - bun (v1.1.16, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{243,895k (± 4.02%)}	_{272,062k (± 3.75%)}	_{🔻+28,167k (+11.55%)}	_262,794k	_288,401k	_{p=0.008 n=6}
_{Parse Time}	_{1.65s (± 1.77%)}	_{1.63s (± 1.55%)}	_~	_1.60s	_1.67s	_{p=0.195 n=6}
_{Bind Time}	_{1.21s (± 0.69%)}	_{1.16s (± 1.18%)}	_{🟩-0.05s (- 4.01%)}	_1.14s	_1.18s	_{p=0.004 n=6}
_{Check Time}	_{12.61s (± 0.40%)}	_{11.39s (± 1.31%)}	_{🟩-1.22s (- 9.66%)}	_11.13s	_11.51s	_{p=0.005 n=6}
_{Emit Time}	_{4.26s (± 0.76%)}	_{3.78s (± 3.36%)}	_{🟩-0.48s (-11.31%)}	_3.69s	_4.00s	_{p=0.005 n=6}
_{Total Time}	_{19.73s (± 0.41%)}	_{17.95s (± 0.13%)}	_{🟩-1.77s (- 8.99%)}	_17.92s	_17.99s	_{p=0.005 n=6}
_{angular-1 - bun (v1.1.16, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,114	_944,114	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,051	_407,051	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,273,184k (± 0.49%)}	_{1,417,499k (± 0.18%)}	_{🔻+144,315k (+11.33%)}	_1,414,474k	_1,421,602k	_{p=0.005 n=6}
_{Parse Time}	_{5.71s (± 0.57%)}	_{5.80s (± 0.55%)}	_{+0.09s (+ 1.58%)}	_5.76s	_5.85s	_{p=0.005 n=6}
_{Bind Time}	_{2.33s (± 0.38%)}	_{2.20s (± 0.48%)}	_{🟩-0.13s (- 5.79%)}	_2.18s	_2.21s	_{p=0.005 n=6}
_{Check Time}	_{34.56s (± 0.63%)}	_{27.00s (± 1.28%)}	_{🟩-7.56s (-21.87%)}	_26.62s	_27.52s	_{p=0.005 n=6}
_{Emit Time}	_{13.55s (± 1.44%)}	_{11.50s (± 0.97%)}	_{🟩-2.05s (-15.14%)}	_11.39s	_11.64s	_{p=0.005 n=6}
_{Total Time}	_{56.15s (± 0.63%)}	_{46.49s (± 0.85%)}	_{🟩-9.65s (-17.19%)}	_46.05s	_47.15s	_{p=0.005 n=6}
_{mui-docs - bun (v1.1.16, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,135,096	_2,135,096	_~	_~	_~	_{p=1.000 n=6}
_Types	_927,167	_927,167	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,310,253k (± 0.31%)}	_{2,398,873k (± 0.14%)}	_{+88,620k (+ 3.84%)}	_2,396,113k	_2,403,729k	_{p=0.005 n=6}
_{Parse Time}	_{6.56s (± 0.54%)}	_{6.60s (± 0.45%)}	_~	_6.56s	_6.64s	_{p=0.077 n=6}
_{Bind Time}	_{1.84s (± 3.78%)}	_{1.77s (± 0.78%)}	_~	_1.76s	_1.79s	_{p=0.088 n=6}
_{Check Time}	_{76.58s (± 0.57%)}	_{59.47s (± 0.34%)}	_{🟩-17.11s (-22.34%)}	_59.13s	_59.74s	_{p=0.005 n=6}
_{Emit Time}	_0.17s	_0.17s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{85.16s (± 0.50%)}	_{68.02s (± 0.31%)}	_{🟩-17.14s (-20.13%)}	_67.69s	_68.34s	_{p=0.005 n=6}
_{self-build-src - bun (v1.1.16, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,230,692	_1,246,480	_{+15,788 (+ 1.28%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,165	_263,504	_{+2,339 (+ 0.90%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{7,591,188k (±34.53%)}	_{10,215,912k (± 3.11%)}	_{🔻+2,624,724k (+34.58%)}	_9,662,812k	_10,529,743k	_{p=0.005 n=6}
_{Parse Time}	_{4.88s (± 0.96%)}	_{4.83s (± 0.46%)}	_~	_4.80s	_4.85s	_{p=0.050 n=6}
_{Bind Time}	_{2.04s (± 2.25%)}	_{1.89s (± 1.29%)}	_{🟩-0.15s (- 7.45%)}	_1.86s	_1.92s	_{p=0.005 n=6}
_{Check Time}	_{36.24s (± 2.50%)}	_{32.23s (± 0.50%)}	_{🟩-4.01s (-11.07%)}	_32.07s	_32.52s	_{p=0.005 n=6}
_{Emit Time}	_{2.13s (± 2.34%)}	_{2.00s (± 0.89%)}	_{🟩-0.13s (- 6.32%)}	_1.97s	_2.02s	_{p=0.005 n=6}
_{Total Time}	_{45.31s (± 1.73%)}	_{40.95s (± 0.44%)}	_{🟩-4.36s (- 9.61%)}	_40.78s	_41.27s	_{p=0.005 n=6}
_{self-build-src-public-api - bun (v1.1.16, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,230,692	_1,246,480	_{+15,788 (+ 1.28%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,165	_263,504	_{+2,339 (+ 0.90%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{4,270,602k (±11.58%)}	_{4,691,201k (±11.20%)}	_{🔻+420,599k (+ 9.85%)}	_4,461,442k	_5,764,634k	_{p=0.045 n=6}
_{Parse Time}	_{4.67s (± 1.01%)}	_{4.87s (± 1.20%)}	_{🔻+0.20s (+ 4.32%)}	_4.77s	_4.94s	_{p=0.005 n=6}
_{Bind Time}	_{2.08s (± 1.86%)}	_{1.82s (± 3.98%)}	_{🟩-0.27s (-12.73%)}	_1.76s	_1.96s	_{p=0.005 n=6}
_{Check Time}	_{40.76s (± 0.25%)}	_{35.92s (± 0.37%)}	_{🟩-4.84s (-11.89%)}	_35.72s	_36.04s	_{p=0.005 n=6}
_{Emit Time}	_{2.16s (± 8.65%)}	_{2.36s (± 1.96%)}	_~	_2.27s	_2.40s	_{p=0.065 n=6}
_{Total Time}	_{49.68s (± 0.32%)}	_{44.98s (± 0.32%)}	_{🟩-4.70s (- 9.46%)}	_44.84s	_45.20s	_{p=0.005 n=6}
_{self-compiler - bun (v1.1.16, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,573	_265,811	_{+7,238 (+ 2.80%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,819	_107,342	_{+2,523 (+ 2.41%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{426,045k (± 0.47%)}	_{476,076k (± 0.15%)}	_{🔻+50,031k (+11.74%)}	_475,085k	_476,703k	_{p=0.005 n=6}
_{Parse Time}	_{2.65s (± 0.60%)}	_{2.65s (± 0.75%)}	_~	_2.62s	_2.68s	_{p=1.000 n=6}
_{Bind Time}	_{1.36s (± 2.08%)}	_{1.23s (± 2.90%)}	_{🟩-0.13s (- 9.80%)}	_1.19s	_1.29s	_{p=0.005 n=6}
_{Check Time}	_{16.66s (± 0.40%)}	_{14.33s (± 0.36%)}	_{🟩-2.33s (-13.96%)}	_14.24s	_14.37s	_{p=0.005 n=6}
_{Emit Time}	_{1.03s (± 1.33%)}	_{1.03s (± 0.95%)}	_~	_1.02s	_1.04s	_{p=0.548 n=6}
_{Total Time}	_{21.70s (± 0.28%)}	_{19.24s (± 0.37%)}	_{🟩-2.46s (-11.35%)}	_19.16s	_19.35s	_{p=0.005 n=6}
_{ts-pre-modules - bun (v1.1.16, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{354,800k (± 0.01%)}	_{401,086k (± 0.64%)}	_{🔻+46,286k (+13.05%)}	_398,940k	_405,565k	_{p=0.005 n=6}
_{Parse Time}	_{2.32s (± 0.89%)}	_{2.26s (± 0.94%)}	_{-0.06s (- 2.65%)}	_2.24s	_2.30s	_{p=0.008 n=6}
_{Bind Time}	_{1.43s (± 0.96%)}	_{1.36s (± 0.76%)}	_{🟩-0.08s (- 5.46%)}	_1.34s	_1.37s	_{p=0.004 n=6}
_{Check Time}	_{14.35s (± 0.24%)}	_{12.27s (± 0.77%)}	_{🟩-2.09s (-14.54%)}	_12.16s	_12.37s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{18.11s (± 0.32%)}	_{15.88s (± 0.70%)}	_{🟩-2.23s (-12.31%)}	_15.77s	_16.04s	_{p=0.005 n=6}
_{vscode - bun (v1.1.16, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,881,060	_2,881,060	_~	_~	_~	_{p=1.000 n=6}
_Types	_975,580	_975,580	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,119,450k (± 0.40%)}	_{3,517,210k (± 0.07%)}	_{🔻+397,760k (+12.75%)}	_3,515,391k	_3,520,506k	_{p=0.005 n=6}
_{Parse Time}	_{10.92s (± 0.40%)}	_{12.63s (±10.13%)}	_{🔻+1.71s (+15.64%)}	_10.96s	_13.47s	_{p=0.008 n=6}
_{Bind Time}	_{3.70s (± 0.84%)}	_{3.87s (± 9.90%)}	_~	_3.35s	_4.15s	_{p=0.378 n=6}
_{Check Time}	_{65.23s (± 0.44%)}	_{57.08s (±10.23%)}	_{🟩-8.15s (-12.49%)}	_49.49s	_61.17s	_{p=0.005 n=6}
_{Emit Time}	_{20.54s (± 0.51%)}	_{20.11s (± 9.86%)}	_~	_17.54s	_21.65s	_{p=0.378 n=6}
_{Total Time}	_{100.39s (± 0.22%)}	_{93.69s (±10.12%)}	_{🟩-6.70s (- 6.68%)}	_81.40s	_100.42s	_{p=0.031 n=6}
_{webpack - bun (v1.1.16, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,117	_267,117	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,775	_108,775	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{429,385k (± 0.20%)}	_{456,589k (± 0.62%)}	_{🔻+27,204k (+ 6.34%)}	_453,298k	_459,520k	_{p=0.005 n=6}
_{Parse Time}	_{2.56s (± 1.06%)}	_{2.56s (± 0.16%)}	_~	_2.56s	_2.57s	_{p=1.000 n=6}
_{Bind Time}	_{1.17s (± 1.00%)}	_{1.19s (± 1.91%)}	_~	_1.17s	_1.23s	_{p=0.119 n=6}
_{Check Time}	_{11.84s (± 0.53%)}	_{10.18s (± 0.62%)}	_{🟩-1.66s (-13.98%)}	_10.11s	_10.26s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{15.57s (± 0.52%)}	_{13.93s (± 0.43%)}	_{🟩-1.64s (-10.53%)}	_13.86s	_13.99s	_{p=0.005 n=6}
_{xstate-main - bun (v1.1.16, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_525,251	_525,251	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,574	_178,574	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{463,069k (± 0.17%)}	_{448,316k (± 0.17%)}	_{🟩-14,753k (- 3.19%)}	_447,433k	_449,223k	_{p=0.005 n=6}
_{Parse Time}	_{3.37s (± 1.67%)}	_{3.38s (± 0.45%)}	_~	_3.36s	_3.40s	_{p=1.000 n=6}
_{Bind Time}	_{1.24s (± 6.15%)}	_{1.29s (± 3.47%)}	_~	_1.20s	_1.32s	_{p=0.295 n=6}
_{Check Time}	_{19.51s (± 0.82%)}	_{17.45s (± 0.41%)}	_{🟩-2.06s (-10.53%)}	_17.36s	_17.55s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_{0.01s (±167.16%)}	_~	_0.00s	_0.02s	_{p=0.176 n=6}
_{Total Time}	_{24.12s (± 0.39%)}	_{22.12s (± 0.49%)}	_{🟩-2.00s (- 8.29%)}	_21.95s	_22.27s	_{p=0.005 n=6}

System info unknown

Hosts

bun (v1.1.16, x64)

Scenarios

Compiler-Unions - bun (v1.1.16, x64)
angular-1 - bun (v1.1.16, x64)
mui-docs - bun (v1.1.16, x64)
self-build-src - bun (v1.1.16, x64)
self-build-src-public-api - bun (v1.1.16, x64)
self-compiler - bun (v1.1.16, x64)
ts-pre-modules - bun (v1.1.16, x64)
vscode - bun (v1.1.16, x64)
webpack - bun (v1.1.16, x64)
xstate-main - bun (v1.1.16, x64)

_Benchmark	_Name	_Iterations
_Current	_977cbc5	₆
_Baseline	_aa249c0	₆

Developer Information:

Download Benchmarks

dragomirtitian · 2024-06-25T10:08:28Z

I really am not sure what to do with this particular line:

self-build-src - bun (v1.1.16, x64)

Memory used 7,591,188k (±34.53%) 10,215,912k (± 3.11%) 🔻+2,624,724k (+34.58%) 9,662,812k 10,529,743k p=0.005 n=6

The original usage already seems pathological as the same tests in node takes 2.3GB not 7.5GB, and this PR makes it much worse, but I don't really think this is truly an issue with the PR seems like an issue with bun IMO. Still 9% faster though 😅

Jarred-Sumner · 2024-06-25T11:17:47Z

Yeah 7 GB is quite high

We should add some more environment variables to test things, but I wonder if passing --smol or running bun build --compile on tsc first does it reduce memory usage meaningfully? I’m wondering if the transpiler which is run on every executed file is doing something silly or if it’s sourcemaps (or otherwise, a runtime issue). Not asking you to take any action here, sounds like this is on us to investigate

jakebailey · 2024-06-25T15:29:42Z

I’m wondering if the transpiler which is run on every executed file is doing something silly or if it’s sourcemaps (or otherwise, a runtime issue).

The benchmark in question is equivalent to running tsc -b ./src in our codebase, so only tsc.js is ever loaded (true of all benchmarks here, besides self-build-src-public-api which loads typescript.js). So something to do with transpilation or source mapping would be very surprising.

dragomirtitian · 2024-06-26T20:00:26Z

I reverted back to the fully monomorphic version and tried to reduce the memory usage on that. The critical insight came when I realized that most of the extra memory allocated was actually not in the new objects themselves, but rather in a property array that v8 uses to store dynamic properties for objects. Creating the data object with all the properties the node might have right in the node factory means that v8 will no longer create the property array thus reducing memory consumption.

The same can be applied to Type to further reduce memory, but that seems a bit more difficult since type creation is not as centralized, but I will in investigate further if the Node improvements are visible in the perf tests (as they have been locally)

@jakebailey When you get a chance can you please run the tests again?

jakebailey · 2024-06-26T21:53:18Z

@typescript-bot perf test this
@typescript-bot perf test this faster [email protected]

typescript-bot · 2024-06-26T21:53:22Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this`	✅ Started	👀 Results
`perf test this faster [email protected]`	✅ Started	👀 Results

typescript-bot · 2024-06-26T22:39:55Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,386k (± 0.98%)}	_{205,919k (± 0.67%)}	_{🔻+12,534k (+ 6.48%)}	_205,240k	_208,743k	_{p=0.005 n=6}
_{Parse Time}	_{1.58s (± 0.65%)}	_{1.63s (± 1.63%)}	_{+0.05s (+ 3.17%)}	_1.58s	_1.65s	_{p=0.014 n=6}
_{Bind Time}	_{0.85s (± 1.61%)}	_{0.82s (± 1.00%)}	_{🟩-0.04s (- 4.48%)}	_0.81s	_0.83s	_{p=0.006 n=6}
_{Check Time}	_{11.19s (± 0.37%)}	_{8.60s (± 1.44%)}	_{🟩-2.59s (-23.19%)}	_8.51s	_8.80s	_{p=0.005 n=6}
_{Emit Time}	_{3.29s (± 0.63%)}	_{2.82s (± 1.07%)}	_{🟩-0.47s (-14.16%)}	_2.78s	_2.85s	_{p=0.005 n=6}
_{Total Time}	_{16.91s (± 0.37%)}	_{13.85s (± 0.65%)}	_{🟩-3.05s (-18.06%)}	_13.77s	_13.99s	_{p=0.005 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,114	_944,114	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,050	_407,050	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,218,344k (± 0.00%)}	_{1,307,977k (± 0.00%)}	_{🔻+89,634k (+ 7.36%)}	_1,307,899k	_1,308,068k	_{p=0.005 n=6}
_{Parse Time}	_{7.99s (± 0.54%)}	_{7.88s (± 0.46%)}	_{-0.12s (- 1.44%)}	_7.84s	_7.92s	_{p=0.005 n=6}
_{Bind Time}	_{2.23s (± 0.49%)}	_{1.86s (± 0.74%)}	_{🟩-0.37s (-16.37%)}	_1.85s	_1.88s	_{p=0.004 n=6}
_{Check Time}	_{35.87s (± 0.32%)}	_{27.75s (± 0.36%)}	_{🟩-8.12s (-22.64%)}	_27.62s	_27.87s	_{p=0.005 n=6}
_{Emit Time}	_{16.13s (± 0.28%)}	_{14.15s (± 0.23%)}	_{🟩-1.99s (-12.32%)}	_14.12s	_14.21s	_{p=0.005 n=6}
_{Total Time}	_{62.23s (± 0.26%)}	_{51.64s (± 0.21%)}	_{🟩-10.59s (-17.02%)}	_51.49s	_51.77s	_{p=0.005 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,132,386	_2,132,386	_~	_~	_~	_{p=1.000 n=6}
_Types	_926,170	_926,170	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,114,946k (± 0.00%)}	_{2,199,515k (± 0.01%)}	_{+84,569k (+ 4.00%)}	_2,199,395k	_2,199,679k	_{p=0.005 n=6}
_{Parse Time}	_{7.86s (± 0.34%)}	_{8.25s (± 2.89%)}	_{🔻+0.39s (+ 4.94%)}	_8.03s	_8.57s	_{p=0.005 n=6}
_{Bind Time}	_{2.73s (± 0.30%)}	_{2.45s (±10.98%)}	_{🟩-0.28s (-10.27%)}	_2.09s	_2.64s	_{p=0.005 n=6}
_{Check Time}	_{83.37s (± 0.53%)}	_{61.31s (± 0.08%)}	_{🟩-22.06s (-26.46%)}	_61.26s	_61.39s	_{p=0.005 n=6}
_{Emit Time}	_{0.16s (± 2.52%)}	_{0.16s (± 2.52%)}	_~	_0.16s	_0.17s	_{p=1.000 n=6}
_{Total Time}	_{94.12s (± 0.46%)}	_{72.17s (± 0.12%)}	_{🟩-21.95s (-23.32%)}	_72.06s	_72.29s	_{p=0.005 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,231,623	_1,249,572	_{+17,949 (+ 1.46%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,185	_265,366	_{+4,181 (+ 1.60%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,347,670k (± 0.02%)}	_{2,515,288k (± 0.04%)}	_{🔻+167,619k (+ 7.14%)}	_2,513,743k	_2,516,381k	_{p=0.005 n=6}
_{Parse Time}	_{6.02s (± 0.53%)}	_{6.04s (± 1.16%)}	_~	_5.98s	_6.17s	_{p=0.872 n=6}
_{Bind Time}	_{2.28s (± 1.29%)}	_{1.93s (± 1.33%)}	_{🟩-0.35s (-15.55%)}	_1.91s	_1.98s	_{p=0.005 n=6}
_{Check Time}	_{40.21s (± 0.24%)}	_{33.20s (± 0.30%)}	_{🟩-7.01s (-17.43%)}	_33.08s	_33.34s	_{p=0.005 n=6}
_{Emit Time}	_{3.20s (± 3.04%)}	_{3.18s (± 2.95%)}	_~	_3.08s	_3.34s	_{p=0.689 n=6}
_{Total Time}	_{51.73s (± 0.18%)}	_{44.37s (± 0.34%)}	_{🟩-7.36s (-14.23%)}	_44.20s	_44.59s	_{p=0.005 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,231,623	_1,249,572	_{+17,949 (+ 1.46%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,185	_265,366	_{+4,181 (+ 1.60%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,423,943k (± 0.02%)}	_{2,603,797k (± 0.02%)}	_{🔻+179,855k (+ 7.42%)}	_2,603,327k	_2,604,659k	_{p=0.005 n=6}
_{Parse Time}	_{5.19s (± 1.80%)}	_{5.17s (± 0.77%)}	_~	_5.14s	_5.24s	_{p=0.261 n=6}
_{Bind Time}	_{1.71s (± 0.80%)}	_{1.64s (± 0.50%)}	_{🟩-0.07s (- 4.09%)}	_1.64s	_1.66s	_{p=0.004 n=6}
_{Check Time}	_{34.42s (± 0.34%)}	_{28.30s (± 0.12%)}	_{🟩-6.12s (-17.79%)}	_28.26s	_28.34s	_{p=0.005 n=6}
_{Emit Time}	_{2.72s (± 1.74%)}	_{2.76s (± 1.16%)}	_~	_2.72s	_2.80s	_{p=0.092 n=6}
_{Total Time}	_{44.07s (± 0.33%)}	_{37.90s (± 0.10%)}	_{🟩-6.16s (-13.99%)}	_37.84s	_37.94s	_{p=0.005 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,817	_268,646	_{+9,829 (+ 3.80%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,842	_109,209	_{🔻+4,367 (+ 4.17%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{428,226k (± 0.01%)}	_{468,120k (± 0.01%)}	_{🔻+39,893k (+ 9.32%)}	_468,082k	_468,159k	_{p=0.005 n=6}
_{Parse Time}	_{4.09s (± 0.29%)}	_{4.06s (± 1.11%)}	_~	_4.01s	_4.12s	_{p=0.333 n=6}
_{Bind Time}	_{1.61s (± 1.98%)}	_{1.45s (± 1.21%)}	_{🟩-0.17s (-10.24%)}	_1.43s	_1.48s	_{p=0.005 n=6}
_{Check Time}	_{21.95s (± 0.33%)}	_{17.73s (± 0.33%)}	_{🟩-4.22s (-19.23%)}	_17.67s	_17.81s	_{p=0.005 n=6}
_{Emit Time}	_{1.72s (± 1.19%)}	_{1.71s (± 0.96%)}	_~	_1.69s	_1.73s	_{p=0.182 n=6}
_{Total Time}	_{29.37s (± 0.23%)}	_{24.94s (± 0.19%)}	_{🟩-4.43s (-15.09%)}	_24.86s	_24.99s	_{p=0.005 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,468k (± 0.02%)}	_{396,796k (± 0.01%)}	_{🔻+27,328k (+ 7.40%)}	_396,758k	_396,817k	_{p=0.005 n=6}
_{Parse Time}	_{2.76s (± 0.94%)}	_{2.90s (± 3.45%)}	_{🔻+0.15s (+ 5.44%)}	_2.76s	_3.00s	_{p=0.016 n=6}
_{Bind Time}	_{1.58s (± 1.10%)}	_{1.30s (± 8.04%)}	_{🟩-0.28s (-17.89%)}	_1.23s	_1.44s	_{p=0.004 n=6}
_{Check Time}	_{15.44s (± 0.35%)}	_{12.29s (± 0.33%)}	_{🟩-3.15s (-20.40%)}	_12.26s	_12.37s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.78s (± 0.36%)}	_{16.50s (± 0.37%)}	_{🟩-3.28s (-16.61%)}	_16.43s	_16.61s	_{p=0.005 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,878,579	_2,878,579	_~	_~	_~	_{p=1.000 n=6}
_Types	_975,166	_975,166	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,042,131k (± 0.00%)}	_{3,254,698k (± 0.00%)}	_{🔻+212,567k (+ 6.99%)}	_3,254,611k	_3,254,742k	_{p=0.005 n=6}
_{Parse Time}	_{16.70s (± 0.27%)}	_{16.70s (± 0.44%)}	_~	_16.62s	_16.82s	_{p=0.630 n=6}
_{Bind Time}	_{5.10s (± 0.52%)}	_{4.14s (± 0.64%)}	_{🟩-0.96s (-18.82%)}	_4.10s	_4.17s	_{p=0.005 n=6}
_{Check Time}	_{89.51s (± 0.51%)}	_{74.57s (± 0.24%)}	_{🟩-14.94s (-16.69%)}	_74.35s	_74.85s	_{p=0.005 n=6}
_{Emit Time}	_{29.14s (± 0.46%)}	_{28.66s (± 1.09%)}	_{-0.47s (- 1.62%)}	_28.23s	_29.17s	_{p=0.031 n=6}
_{Total Time}	_{140.45s (± 0.29%)}	_{124.08s (± 0.21%)}	_{🟩-16.37s (-11.66%)}	_123.71s	_124.48s	_{p=0.005 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,117	_267,117	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,775	_108,775	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{411,541k (± 0.02%)}	_{437,976k (± 0.02%)}	_{🔻+26,435k (+ 6.42%)}	_437,916k	_438,105k	_{p=0.005 n=6}
_{Parse Time}	_{3.82s (± 0.68%)}	_{3.80s (± 0.62%)}	_~	_3.77s	_3.84s	_{p=0.195 n=6}
_{Bind Time}	_{1.70s (± 0.71%)}	_{1.52s (± 0.80%)}	_{🟩-0.18s (-10.61%)}	_1.50s	_1.53s	_{p=0.005 n=6}
_{Check Time}	_{16.76s (± 0.52%)}	_{14.03s (± 0.36%)}	_{🟩-2.73s (-16.26%)}	_14.00s	_14.13s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.28s (± 0.48%)}	_{19.35s (± 0.28%)}	_{🟩-2.93s (-13.14%)}	_19.31s	_19.45s	_{p=0.005 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_525,251	_525,251	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,574	_178,574	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{462,775k (± 0.09%)}	_{487,694k (± 0.07%)}	_{🔻+24,919k (+ 5.38%)}	_487,229k	_487,944k	_{p=0.005 n=6}
_{Parse Time}	_{3.19s (± 0.46%)}	_{3.20s (± 0.55%)}	_~	_3.18s	_3.23s	_{p=0.459 n=6}
_{Bind Time}	_{1.17s (± 0.35%)}	_{1.14s (± 0.48%)}	_{-0.02s (- 2.00%)}	_1.14s	_1.15s	_{p=0.003 n=6}
_{Check Time}	_{17.94s (± 0.31%)}	_{15.27s (± 0.38%)}	_{🟩-2.68s (-14.91%)}	_15.20s	_15.36s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.30s (± 0.29%)}	_{19.61s (± 0.28%)}	_{🟩-2.69s (-12.08%)}	_19.56s	_19.70s	_{p=0.005 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{3,423ms (± 0.71%)}	_{3,394ms (± 1.19%)}	_~	_3,319ms	_3,429ms	_{p=0.128 n=6}
_{Req 2 - geterr}	_{7,527ms (± 0.50%)}	_{6,178ms (± 0.40%)}	_{🟩-1,349ms (-17.93%)}	_6,156ms	_6,215ms	_{p=0.005 n=6}
_{Req 3 - references}	_{394ms (± 0.27%)}	_{398ms (± 0.86%)}	_~	_393ms	_401ms	_{p=0.061 n=6}
_{Req 4 - navto}	_{341ms (± 0.47%)}	_{348ms (± 0.81%)}	_{+7ms (+ 1.96%)}	_344ms	_352ms	_{p=0.005 n=6}
_{Req 5 - completionInfo count}	_1,357	_1,357	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{125ms (± 4.97%)}	_{122ms (± 5.23%)}	_~	_113ms	_130ms	_{p=0.332 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{3,587ms (± 1.08%)}	_{3,525ms (± 0.68%)}	_{-61ms (- 1.71%)}	_3,478ms	_3,545ms	_{p=0.031 n=6}
_{Req 2 - geterr}	_{5,545ms (± 0.79%)}	_{4,720ms (± 0.30%)}	_{🟩-825ms (-14.87%)}	_4,696ms	_4,734ms	_{p=0.005 n=6}
_{Req 3 - references}	_{416ms (± 0.43%)}	_{424ms (± 0.15%)}	_{+8ms (+ 1.92%)}	_423ms	_425ms	_{p=0.004 n=6}
_{Req 4 - navto}	_{337ms (± 0.24%)}	_{364ms (± 2.39%)}	_{🔻+27ms (+ 8.00%)}	_347ms	_371ms	_{p=0.005 n=6}
_{Req 5 - completionInfo count}	_1,519	_1,519	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{110ms (± 0.57%)}	_{117ms (± 3.01%)}	_{🔻+7ms (+ 5.91%)}	_113ms	_120ms	_{p=0.004 n=6}
_{xstate-main-1-tsserver - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{6,468ms (± 9.57%)}	_{6,227ms (± 0.30%)}	_~	_6,205ms	_6,248ms	_{p=1.000 n=6}
_{Req 2 - geterr}	_{1,635ms (± 8.31%)}	_{1,386ms (± 8.80%)}	_{🟩-249ms (-15.23%)}	_1,140ms	_1,462ms	_{p=0.045 n=6}
_{Req 3 - references}	_{107ms (± 8.25%)}	_{120ms (± 2.85%)}	_{🔻+13ms (+12.31%)}	_118ms	_127ms	_{p=0.005 n=6}
_{Req 4 - navto}	_{592ms (± 2.63%)}	_{549ms (± 3.10%)}	_{🟩-43ms (- 7.29%)}	_529ms	_573ms	_{p=0.005 n=6}
_{Req 5 - completionInfo count}	_3,413	_3,413	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{1,235ms (± 0.94%)}	_{1,311ms (± 1.27%)}	_{🔻+76ms (+ 6.15%)}	_1,286ms	_1,334ms	_{p=0.005 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstate-main-1-tsserver - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.48ms (± 0.16%)}	_{232.10ms (± 0.16%)}	_{+2.62ms (+ 1.14%)}	_229.93ms	_235.27ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{285.94ms (± 0.30%)}	_{288.01ms (± 0.28%)}	_{+2.07ms (+ 0.72%)}	_281.02ms	_296.04ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{278.01ms (± 0.28%)}	_{279.99ms (± 0.29%)}	_{+1.98ms (+ 0.71%)}	_272.92ms	_284.60ms	_{p=0.000 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{277.35ms (± 0.32%)}	_{279.19ms (± 0.32%)}	_{+1.84ms (+ 0.66%)}	_272.08ms	_290.10ms	_{p=0.000 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-06-26T22:48:18Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - bun (v1.1.17, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{241,775k (± 1.90%)}	_{270,225k (± 1.96%)}	_{🔻+28,450k (+11.77%)}	_265,049k	_278,807k	_{p=0.005 n=6}
_{Parse Time}	_{1.63s (± 1.71%)}	_{1.59s (± 1.38%)}	_{-0.04s (- 2.55%)}	_1.56s	_1.62s	_{p=0.019 n=6}
_{Bind Time}	_{1.21s (± 2.56%)}	_{1.20s (± 3.18%)}	_~	_1.16s	_1.27s	_{p=0.686 n=6}
_{Check Time}	_{12.50s (± 0.49%)}	_{12.07s (± 1.15%)}	_{🟩-0.43s (- 3.41%)}	_11.80s	_12.18s	_{p=0.005 n=6}
_{Emit Time}	_{4.25s (± 0.90%)}	_{3.88s (± 3.22%)}	_{🟩-0.36s (- 8.60%)}	_3.78s	_4.13s	_{p=0.005 n=6}
_{Total Time}	_{19.59s (± 0.36%)}	_{18.74s (± 0.32%)}	_{🟩-0.84s (- 4.30%)}	_18.68s	_18.82s	_{p=0.005 n=6}
_{angular-1 - bun (v1.1.17, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,114	_944,114	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,050	_407,050	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,272,793k (± 0.65%)}	_{1,432,217k (± 0.18%)}	_{🔻+159,423k (+12.53%)}	_1,429,819k	_1,437,188k	_{p=0.005 n=6}
_{Parse Time}	_{5.73s (± 0.52%)}	_{5.72s (± 1.27%)}	_~	_5.67s	_5.86s	_{p=0.126 n=6}
_{Bind Time}	_{2.33s (± 0.99%)}	_{2.18s (± 6.58%)}	_{🟩-0.15s (- 6.59%)}	_1.89s	_2.26s	_{p=0.005 n=6}
_{Check Time}	_{34.59s (± 0.78%)}	_{28.84s (± 0.78%)}	_{🟩-5.75s (-16.61%)}	_28.55s	_29.09s	_{p=0.005 n=6}
_{Emit Time}	_{13.63s (± 1.63%)}	_{12.40s (± 0.54%)}	_{🟩-1.23s (- 9.06%)}	_12.28s	_12.48s	_{p=0.005 n=6}
_{Total Time}	_{56.29s (± 0.79%)}	_{49.13s (± 0.28%)}	_{🟩-7.16s (-12.71%)}	_48.95s	_49.32s	_{p=0.005 n=6}
_{mui-docs - bun (v1.1.17, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,132,386	_2,132,386	_~	_~	_~	_{p=1.000 n=6}
_Types	_926,170	_926,170	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,309,534k (± 0.26%)}	_{2,435,653k (± 0.10%)}	_{🔻+126,119k (+ 5.46%)}	_2,431,385k	_2,437,918k	_{p=0.005 n=6}
_{Parse Time}	_{6.57s (± 0.33%)}	_{6.93s (± 0.36%)}	_{🔻+0.36s (+ 5.53%)}	_6.90s	_6.96s	_{p=0.005 n=6}
_{Bind Time}	_{1.86s (± 2.99%)}	_{1.93s (± 1.91%)}	_~	_1.89s	_1.98s	_{p=0.077 n=6}
_{Check Time}	_{76.52s (± 0.32%)}	_{62.23s (± 0.53%)}	_{🟩-14.28s (-18.67%)}	_61.81s	_62.75s	_{p=0.005 n=6}
_{Emit Time}	_{0.17s (± 2.98%)}	_{0.18s (± 2.96%)}	_{🔻+0.01s (+ 6.73%)}	_0.18s	_0.19s	_{p=0.013 n=6}
_{Total Time}	_{85.13s (± 0.32%)}	_{71.28s (± 0.51%)}	_{🟩-13.84s (-16.26%)}	_70.86s	_71.86s	_{p=0.005 n=6}
_{self-build-src - bun (v1.1.17, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,231,623	_1,249,572	_{+17,949 (+ 1.46%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,185	_265,366	_{+4,181 (+ 1.60%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{8,975,407k (± 1.86%)}	_{9,926,236k (± 1.90%)}	_{🔻+950,830k (+10.59%)}	_9,714,597k	_10,158,773k	_{p=0.005 n=6}
_{Parse Time}	_{4.85s (± 0.84%)}	_{4.75s (± 1.17%)}	_{-0.10s (- 2.06%)}	_4.70s	_4.83s	_{p=0.016 n=6}
_{Bind Time}	_{2.05s (± 2.44%)}	_{2.01s (± 1.26%)}	_~	_1.98s	_2.05s	_{p=0.226 n=6}
_{Check Time}	_{35.48s (± 4.16%)}	_{32.09s (± 0.27%)}	_{🟩-3.39s (- 9.55%)}	_31.98s	_32.21s	_{p=0.005 n=6}
_{Emit Time}	_{2.15s (± 3.14%)}	_{2.08s (± 1.30%)}	_~	_2.04s	_2.11s	_{p=0.198 n=6}
_{Total Time}	_{44.53s (± 3.42%)}	_{40.95s (± 0.20%)}	_{🟩-3.58s (- 8.05%)}	_40.81s	_41.04s	_{p=0.005 n=6}
_{self-build-src-public-api - bun (v1.1.17, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,231,623	_1,249,572	_{+17,949 (+ 1.46%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,185	_265,366	_{+4,181 (+ 1.60%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{4,137,311k (± 4.07%)}	_{6,075,265k (± 0.70%)}	_{🔻+1,937,953k (+46.84%)}	_6,039,228k	_6,157,816k	_{p=0.005 n=6}
_{Parse Time}	_{4.70s (± 0.60%)}	_{4.58s (± 0.76%)}	_{-0.12s (- 2.48%)}	_4.56s	_4.65s	_{p=0.005 n=6}
_{Bind Time}	_{2.11s (± 1.78%)}	_{1.97s (± 1.38%)}	_{🟩-0.14s (- 6.64%)}	_1.93s	_2.00s	_{p=0.005 n=6}
_{Check Time}	_{40.87s (± 0.23%)}	_{38.16s (± 0.77%)}	_{🟩-2.71s (- 6.63%)}	_37.60s	_38.37s	_{p=0.005 n=6}
_{Emit Time}	_{2.10s (± 2.04%)}	_{2.20s (± 1.46%)}	_{🔻+0.10s (+ 4.93%)}	_2.16s	_2.24s	_{p=0.013 n=6}
_{Total Time}	_{49.78s (± 0.21%)}	_{46.92s (± 0.46%)}	_{🟩-2.87s (- 5.76%)}	_46.53s	_47.09s	_{p=0.005 n=6}
_{self-compiler - bun (v1.1.17, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,817	_268,646	_{+9,829 (+ 3.80%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,842	_109,209	_{🔻+4,367 (+ 4.17%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{425,764k (± 0.25%)}	_{491,764k (± 0.40%)}	_{🔻+66,000k (+15.50%)}	_489,380k	_494,037k	_{p=0.005 n=6}
_{Parse Time}	_{2.66s (± 1.22%)}	_{2.60s (± 0.87%)}	_{-0.06s (- 2.13%)}	_2.57s	_2.63s	_{p=0.020 n=6}
_{Bind Time}	_{1.32s (± 2.84%)}	_{1.30s (± 1.61%)}	_~	_1.27s	_1.32s	_{p=0.375 n=6}
_{Check Time}	_{16.72s (± 0.57%)}	_{16.17s (± 0.43%)}	_{🟩-0.55s (- 3.29%)}	_16.09s	_16.27s	_{p=0.005 n=6}
_{Emit Time}	_{1.03s (± 2.45%)}	_{1.14s (± 1.90%)}	_{🔻+0.11s (+10.36%)}	_1.11s	_1.16s	_{p=0.005 n=6}
_{Total Time}	_{21.74s (± 0.51%)}	_{21.21s (± 0.46%)}	_{-0.53s (- 2.42%)}	_21.09s	_21.33s	_{p=0.005 n=6}
_{ts-pre-modules - bun (v1.1.17, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{354,934k (± 0.02%)}	_{406,772k (± 0.74%)}	_{🔻+51,839k (+14.61%)}	_403,957k	_410,271k	_{p=0.005 n=6}
_{Parse Time}	_{2.32s (± 1.04%)}	_{2.25s (± 1.89%)}	_{-0.06s (- 2.73%)}	_2.21s	_2.33s	_{p=0.045 n=6}
_{Bind Time}	_{1.43s (± 0.77%)}	_{1.44s (± 1.95%)}	_~	_1.39s	_1.47s	_{p=0.360 n=6}
_{Check Time}	_{14.31s (± 0.64%)}	_{13.26s (± 0.59%)}	_{🟩-1.05s (- 7.32%)}	_13.16s	_13.36s	_{p=0.005 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_0.00s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{18.06s (± 0.50%)}	_{16.95s (± 0.65%)}	_{🟩-1.11s (- 6.15%)}	_16.87s	_17.15s	_{p=0.005 n=6}
_{vscode - bun (v1.1.17, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,878,579	_2,878,579	_~	_~	_~	_{p=1.000 n=6}
_Types	_975,166	_975,166	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,112,750k (± 0.38%)}	_{3,558,582k (± 0.10%)}	_{🔻+445,831k (+14.32%)}	_3,553,704k	_3,563,517k	_{p=0.005 n=6}
_{Parse Time}	_{10.91s (± 0.33%)}	_{11.96s (±11.30%)}	_~	_10.71s	_13.21s	_{p=1.000 n=6}
_{Bind Time}	_{3.67s (± 1.53%)}	_{3.83s (±11.90%)}	_~	_3.33s	_4.32s	_{p=1.000 n=6}
_{Check Time}	_{65.56s (± 0.46%)}	_{58.48s (±10.98%)}	_{🟩-7.08s (-10.79%)}	_52.33s	_64.43s	_{p=0.005 n=6}
_{Emit Time}	_{20.40s (± 0.48%)}	_{19.89s (±11.07%)}	_~	_17.84s	_22.02s	_{p=1.000 n=6}
_{Total Time}	_{100.54s (± 0.32%)}	_{94.15s (±11.07%)}	_~	_84.35s	_103.80s	_{p=1.000 n=6}
_{webpack - bun (v1.1.17, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,117	_267,117	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,775	_108,775	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{429,487k (± 0.23%)}	_{464,040k (± 0.66%)}	_{🔻+34,553k (+ 8.05%)}	_458,790k	_466,187k	_{p=0.005 n=6}
_{Parse Time}	_{3.08s (± 0.84%)}	_{3.08s (± 1.00%)}	_~	_3.05s	_3.13s	_{p=0.935 n=6}
_{Bind Time}	_{1.38s (± 1.67%)}	_{1.51s (± 1.37%)}	_{🔻+0.13s (+ 9.65%)}	_1.50s	_1.55s	_{p=0.005 n=6}
_{Check Time}	_{13.70s (± 0.37%)}	_{12.73s (± 0.63%)}	_{🟩-0.97s (- 7.08%)}	_12.65s	_12.88s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{18.17s (± 0.40%)}	_{17.33s (± 0.56%)}	_{🟩-0.84s (- 4.62%)}	_17.20s	_17.48s	_{p=0.005 n=6}
_{xstate-main - bun (v1.1.17, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_525,251	_525,251	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,574	_178,574	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{464,083k (± 0.39%)}	_{452,108k (± 0.33%)}	_{-11,976k (- 2.58%)}	_450,300k	_453,920k	_{p=0.005 n=6}
_{Parse Time}	_{2.72s (± 1.25%)}	_{2.87s (± 0.92%)}	_{🔻+0.15s (+ 5.64%)}	_2.84s	_2.92s	_{p=0.005 n=6}
_{Bind Time}	_{1.00s (± 5.85%)}	_{0.99s (± 1.74%)}	_~	_0.96s	_1.01s	_{p=0.936 n=6}
_{Check Time}	_{15.87s (± 0.37%)}	_{15.37s (± 0.98%)}	_{🟩-0.50s (- 3.16%)}	_15.14s	_15.54s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_{0.01s (±63.18%)}	_{🔻+0.01s (+ ∞%)}	_0.00s	_0.02s	_{p=0.008 n=6}
_{Total Time}	_{19.59s (± 0.32%)}	_{19.23s (± 0.77%)}	_{-0.35s (- 1.80%)}	_19.05s	_19.40s	_{p=0.005 n=6}

System info unknown

Hosts

bun (v1.1.17, x64)

Scenarios

Compiler-Unions - bun (v1.1.17, x64)
angular-1 - bun (v1.1.17, x64)
mui-docs - bun (v1.1.17, x64)
self-build-src - bun (v1.1.17, x64)
self-build-src-public-api - bun (v1.1.17, x64)
self-compiler - bun (v1.1.17, x64)
ts-pre-modules - bun (v1.1.17, x64)
vscode - bun (v1.1.17, x64)
webpack - bun (v1.1.17, x64)
xstate-main - bun (v1.1.17, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

dragomirtitian · 2024-06-26T22:58:40Z

For node things look really really good: Increase of 🔻 5-7.5% in memory for a perf win of 🟩14-23%.

For bun things are more complicated:

self-build-src-public-api - bun performs much worse in terms of memory usage, and this PR makes things worse.
vscode - The best time is 87s which is very fast, but that result is not consistent

Excluding the outliers we get: Increase of 🔻 3-15% in memory for a perf win of 🟩 3-16%. A much more mixed result

…ing them to data

dragomirtitian · 2024-06-28T18:06:07Z

I moved some stuff around between node and node data. This seems to reduce some more of the extra memory that was being used.

I also experimented with reducing the size of Types, but don't think there are any easy wins there.

@jakebailey When you get a chance, can you run the tests again please?

jakebailey · 2024-06-28T18:07:22Z

@typescript-bot perf test this
@typescript-bot perf test this faster [email protected]

typescript-bot · 2024-06-28T18:07:25Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this`	✅ Started	👀 Results
`perf test this faster [email protected]`	✅ Started	👀 Results

typescript-bot · 2024-06-28T18:37:45Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - bun (v1.1.17, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{245,591k (± 4.51%)}	_{271,787k (± 1.75%)}	_{🔻+26,197k (+10.67%)}	_266,725k	_280,687k	_{p=0.008 n=6}
_{Parse Time}	_{1.08s (± 1.13%)}	_{1.07s (± 1.15%)}	_{-0.02s (- 1.84%)}	_1.06s	_1.09s	_{p=0.024 n=6}
_{Bind Time}	_{0.82s (± 0.50%)}	_{0.83s (± 2.48%)}	_~	_0.81s	_0.86s	_{p=0.405 n=6}
_{Check Time}	_{8.68s (± 0.64%)}	_{8.33s (± 1.56%)}	_{🟩-0.36s (- 4.11%)}	_8.12s	_8.51s	_{p=0.005 n=6}
_{Emit Time}	_{2.89s (± 1.17%)}	_{3.00s (± 2.74%)}	_{+0.11s (+ 3.80%)}	_2.95s	_3.16s	_{p=0.005 n=6}
_{Total Time}	_{13.49s (± 0.45%)}	_{13.23s (± 0.54%)}	_{-0.26s (- 1.90%)}	_13.16s	_13.37s	_{p=0.005 n=6}
_{angular-1 - bun (v1.1.17, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,114	_944,114	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,050	_407,050	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,274,831k (± 0.54%)}	_{1,435,731k (± 0.17%)}	_{🔻+160,900k (+12.62%)}	_1,432,805k	_1,439,052k	_{p=0.005 n=6}
_{Parse Time}	_{4.75s (± 0.18%)}	_{4.73s (± 0.28%)}	_{-0.02s (- 0.35%)}	_4.71s	_4.74s	_{p=0.040 n=6}
_{Bind Time}	_{1.95s (± 1.00%)}	_{1.91s (± 2.96%)}	_~	_1.81s	_1.97s	_{p=0.196 n=6}
_{Check Time}	_{29.67s (± 0.51%)}	_{25.10s (± 0.51%)}	_{🟩-4.57s (-15.42%)}	_24.93s	_25.32s	_{p=0.005 n=6}
_{Emit Time}	_{11.37s (± 1.50%)}	_{11.25s (± 1.44%)}	_~	_11.08s	_11.46s	_{p=0.261 n=6}
_{Total Time}	_{47.73s (± 0.56%)}	_{42.99s (± 0.37%)}	_{🟩-4.74s (- 9.94%)}	_42.67s	_43.09s	_{p=0.005 n=6}
_{mui-docs - bun (v1.1.17, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,133,039	_2,133,039	_~	_~	_~	_{p=1.000 n=6}
_Types	_926,444	_926,444	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,312,288k (± 0.44%)}	_{2,442,773k (± 0.16%)}	_{🔻+130,485k (+ 5.64%)}	_2,438,826k	_2,446,599k	_{p=0.005 n=6}
_{Parse Time}	_{5.46s (± 0.47%)}	_{5.80s (± 1.00%)}	_{🔻+0.33s (+ 6.13%)}	_5.75s	_5.91s	_{p=0.005 n=6}
_{Bind Time}	_{1.51s (± 1.42%)}	_{1.60s (± 0.39%)}	_{🔻+0.09s (+ 6.08%)}	_1.59s	_1.61s	_{p=0.004 n=6}
_{Check Time}	_{64.89s (± 0.59%)}	_{52.64s (± 0.47%)}	_{🟩-12.26s (-18.89%)}	_52.30s	_52.90s	_{p=0.005 n=6}
_{Emit Time}	_0.15s	_{0.15s (± 2.69%)}	_~	_0.15s	_0.16s	_{p=0.405 n=6}
_{Total Time}	_{72.01s (± 0.54%)}	_{60.19s (± 0.47%)}	_{🟩-11.82s (-16.42%)}	_59.82s	_60.57s	_{p=0.005 n=6}
_{self-build-src - bun (v1.1.17, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,224,331	_1,242,584	_{+18,253 (+ 1.49%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,007	_265,198	_{+4,191 (+ 1.61%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{8,894,363k (± 1.89%)}	_{10,126,558k (± 2.96%)}	_{🔻+1,232,196k (+13.85%)}	_9,682,006k	_10,561,465k	_{p=0.005 n=6}
_{Parse Time}	_{5.41s (± 1.30%)}	_{5.42s (± 1.07%)}	_~	_5.36s	_5.52s	_{p=0.684 n=6}
_{Bind Time}	_{2.48s (± 1.44%)}	_{2.61s (± 2.27%)}	_{🔻+0.13s (+ 5.31%)}	_2.53s	_2.71s	_{p=0.005 n=6}
_{Check Time}	_{43.90s (± 3.70%)}	_{39.95s (± 4.72%)}	_{🟩-3.95s (- 8.99%)}	_38.67s	_42.46s	_{p=0.031 n=6}
_{Emit Time}	_{2.61s (± 2.75%)}	_{2.81s (± 1.38%)}	_{🔻+0.19s (+ 7.39%)}	_2.74s	_2.84s	_{p=0.005 n=6}
_{Total Time}	_{54.39s (± 2.98%)}	_{50.79s (± 3.72%)}	_{🟩-3.60s (- 6.62%)}	_49.42s	_53.43s	_{p=0.031 n=6}
_{self-build-src-public-api - bun (v1.1.17, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,224,331	_1,242,584	_{+18,253 (+ 1.49%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,007	_265,198	_{+4,191 (+ 1.61%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{5,162,965k (±33.11%)}	_{5,459,368k (±12.12%)}	_~	_4,742,646k	_6,167,166k	_{p=0.066 n=6}
_{Parse Time}	_{3.97s (± 1.76%)}	_{3.87s (± 1.55%)}	_{-0.10s (- 2.60%)}	_3.79s	_3.94s	_{p=0.019 n=6}
_{Bind Time}	_{1.78s (± 0.94%)}	_{1.92s (± 2.61%)}	_{🔻+0.14s (+ 7.58%)}	_1.87s	_2.00s	_{p=0.005 n=6}
_{Check Time}	_{33.06s (± 0.90%)}	_{31.44s (± 4.52%)}	_{🟩-1.62s (- 4.91%)}	_29.50s	_32.40s	_{p=0.005 n=6}
_{Emit Time}	_{1.62s (± 4.56%)}	_{1.97s (± 2.31%)}	_{🔻+0.35s (+21.73%)}	_1.92s	_2.04s	_{p=0.005 n=6}
_{Total Time}	_{40.42s (± 0.74%)}	_{39.18s (± 3.50%)}	_{🟩-1.24s (- 3.08%)}	_37.25s	_40.21s	_{p=0.030 n=6}
_{self-compiler - bun (v1.1.17, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,166	_268,004	_{+9,838 (+ 3.81%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,689	_109,058	_{🔻+4,369 (+ 4.17%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{421,994k (± 0.96%)}	_{492,939k (± 0.25%)}	_{🔻+70,945k (+16.81%)}	_491,737k	_495,383k	_{p=0.005 n=6}
_{Parse Time}	_{3.28s (± 1.04%)}	_{3.22s (± 0.44%)}	_{-0.06s (- 1.88%)}	_3.20s	_3.24s	_{p=0.006 n=6}
_{Bind Time}	_{1.65s (± 1.97%)}	_{1.60s (± 3.06%)}	_~	_1.54s	_1.65s	_{p=0.090 n=6}
_{Check Time}	_{20.73s (± 0.53%)}	_{19.43s (± 0.38%)}	_{🟩-1.30s (- 6.27%)}	_19.35s	_19.53s	_{p=0.005 n=6}
_{Emit Time}	_{1.28s (± 1.62%)}	_{1.52s (± 1.95%)}	_{🔻+0.24s (+19.06%)}	_1.49s	_1.57s	_{p=0.005 n=6}
_{Total Time}	_{26.93s (± 0.41%)}	_{25.76s (± 0.52%)}	_{🟩-1.16s (- 4.32%)}	_25.60s	_25.92s	_{p=0.005 n=6}
_{ts-pre-modules - bun (v1.1.17, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{354,877k (± 0.04%)}	_{404,915k (± 0.57%)}	_{🔻+50,037k (+14.10%)}	_402,847k	_409,482k	_{p=0.005 n=6}
_{Parse Time}	_{2.34s (± 1.36%)}	_{2.25s (± 0.36%)}	_{🟩-0.08s (- 3.64%)}	_2.24s	_2.26s	_{p=0.005 n=6}
_{Bind Time}	_{1.45s (± 0.75%)}	_{1.47s (± 0.70%)}	_{+0.02s (+ 1.15%)}	_1.45s	_1.48s	_{p=0.032 n=6}
_{Check Time}	_{14.40s (± 0.49%)}	_{13.30s (± 0.72%)}	_{🟩-1.10s (- 7.63%)}	_13.21s	_13.44s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{18.19s (± 0.49%)}	_{17.02s (± 0.56%)}	_{🟩-1.17s (- 6.43%)}	_16.92s	_17.16s	_{p=0.005 n=6}
_{vscode - bun (v1.1.17, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,878,940	_2,878,940	_~	_~	_~	_{p=1.000 n=6}
_Types	_975,074	_975,074	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,107,604k (± 0.35%)}	_{3,565,274k (± 0.14%)}	_{🔻+457,670k (+14.73%)}	_3,559,160k	_3,569,963k	_{p=0.005 n=6}
_{Parse Time}	_{11.15s (± 0.37%)}	_{10.71s (± 1.93%)}	_{🟩-0.43s (- 3.87%)}	_10.52s	_10.94s	_{p=0.005 n=6}
_{Bind Time}	_{3.70s (± 0.99%)}	_{3.60s (± 5.95%)}	_~	_3.34s	_3.81s	_{p=1.000 n=6}
_{Check Time}	_{65.19s (± 0.35%)}	_{52.50s (± 0.50%)}	_{🟩-12.69s (-19.47%)}	_52.19s	_52.78s	_{p=0.005 n=6}
_{Emit Time}	_{19.75s (± 0.89%)}	_{19.49s (± 0.75%)}	_{-0.27s (- 1.35%)}	_19.30s	_19.64s	_{p=0.030 n=6}
_{Total Time}	_{99.79s (± 0.30%)}	_{86.29s (± 0.37%)}	_{🟩-13.50s (-13.53%)}	_85.83s	_86.68s	_{p=0.005 n=6}
_{webpack - bun (v1.1.17, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,117	_267,117	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,775	_108,775	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{429,087k (± 0.18%)}	_{463,714k (± 0.53%)}	_{🔻+34,627k (+ 8.07%)}	_460,293k	_466,592k	_{p=0.005 n=6}
_{Parse Time}	_{3.07s (± 1.17%)}	_{3.06s (± 0.71%)}	_~	_3.03s	_3.09s	_{p=0.466 n=6}
_{Bind Time}	_{1.38s (± 0.85%)}	_{1.51s (± 2.35%)}	_{🔻+0.13s (+ 9.65%)}	_1.48s	_1.58s	_{p=0.005 n=6}
_{Check Time}	_{13.77s (± 0.42%)}	_{12.73s (± 0.63%)}	_{🟩-1.04s (- 7.54%)}	_12.63s	_12.84s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{18.23s (± 0.55%)}	_{17.30s (± 0.57%)}	_{🟩-0.93s (- 5.10%)}	_17.19s	_17.44s	_{p=0.005 n=6}
_{xstate-main - bun (v1.1.17, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_525,251	_525,251	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,574	_178,574	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{462,061k (± 0.29%)}	_{453,485k (± 0.19%)}	_{-8,576k (- 1.86%)}	_452,663k	_455,076k	_{p=0.005 n=6}
_{Parse Time}	_{2.72s (± 1.48%)}	_{2.96s (± 4.71%)}	_{🔻+0.23s (+ 8.63%)}	_2.88s	_3.24s	_{p=0.005 n=6}
_{Bind Time}	_{1.04s (± 5.73%)}	_{0.98s (± 1.78%)}	_~	_0.96s	_1.01s	_{p=0.065 n=6}
_{Check Time}	_{15.86s (± 0.41%)}	_{15.70s (± 0.45%)}	_{-0.16s (- 1.01%)}	_15.62s	_15.79s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.01s	_{🔻+0.01s (+ ∞%)}	_~	_~	_{p=0.001 n=6}
_{Total Time}	_{19.63s (± 0.56%)}	_{19.64s (± 0.65%)}	_~	_19.51s	_19.86s	_{p=1.000 n=6}

System info unknown

Hosts

bun (v1.1.17, x64)

Scenarios

Compiler-Unions - bun (v1.1.17, x64)
angular-1 - bun (v1.1.17, x64)
mui-docs - bun (v1.1.17, x64)
self-build-src - bun (v1.1.17, x64)
self-build-src-public-api - bun (v1.1.17, x64)
self-compiler - bun (v1.1.17, x64)
ts-pre-modules - bun (v1.1.17, x64)
vscode - bun (v1.1.17, x64)
webpack - bun (v1.1.17, x64)
xstate-main - bun (v1.1.17, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-06-28T18:54:01Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{194,647k (± 0.92%)}	_{200,834k (± 0.95%)}	_{+6,188k (+ 3.18%)}	_199,561k	_203,385k	_{p=0.005 n=6}
_{Parse Time}	_{1.58s (± 0.48%)}	_{1.59s (± 1.26%)}	_~	_1.56s	_1.62s	_{p=0.188 n=6}
_{Bind Time}	_{0.86s (± 0.73%)}	_{0.81s (± 1.00%)}	_{🟩-0.05s (- 5.43%)}	_0.80s	_0.82s	_{p=0.004 n=6}
_{Check Time}	_{11.19s (± 0.21%)}	_{8.65s (± 0.54%)}	_{🟩-2.54s (-22.69%)}	_8.58s	_8.70s	_{p=0.005 n=6}
_{Emit Time}	_{3.28s (± 0.42%)}	_{3.04s (± 0.62%)}	_{🟩-0.24s (- 7.41%)}	_3.02s	_3.07s	_{p=0.005 n=6}
_{Total Time}	_{16.91s (± 0.17%)}	_{14.09s (± 0.27%)}	_{🟩-2.82s (-16.67%)}	_14.04s	_14.15s	_{p=0.005 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,114	_944,114	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,050	_407,050	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,218,381k (± 0.00%)}	_{1,265,388k (± 0.00%)}	_{+47,008k (+ 3.86%)}	_1,265,338k	_1,265,434k	_{p=0.005 n=6}
_{Parse Time}	_{7.96s (± 0.48%)}	_{7.72s (± 0.44%)}	_{🟩-0.24s (- 3.01%)}	_7.68s	_7.77s	_{p=0.005 n=6}
_{Bind Time}	_{2.21s (± 0.66%)}	_{1.87s (± 2.07%)}	_{🟩-0.34s (-15.30%)}	_1.85s	_1.95s	_{p=0.004 n=6}
_{Check Time}	_{35.71s (± 0.23%)}	_{27.69s (± 0.55%)}	_{🟩-8.02s (-22.45%)}	_27.53s	_27.93s	_{p=0.005 n=6}
_{Emit Time}	_{16.13s (± 0.28%)}	_{14.90s (± 0.27%)}	_{🟩-1.23s (- 7.61%)}	_14.85s	_14.95s	_{p=0.005 n=6}
_{Total Time}	_{62.01s (± 0.06%)}	_{52.19s (± 0.27%)}	_{🟩-9.82s (-15.84%)}	_51.99s	_52.34s	_{p=0.005 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,133,039	_2,133,039	_~	_~	_~	_{p=1.000 n=6}
_Types	_926,444	_926,444	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,115,366k (± 0.00%)}	_{2,167,316k (± 0.01%)}	_{+51,950k (+ 2.46%)}	_2,167,035k	_2,167,491k	_{p=0.005 n=6}
_{Parse Time}	_{7.93s (± 0.33%)}	_{7.92s (± 0.43%)}	_~	_7.87s	_7.96s	_{p=0.627 n=6}
_{Bind Time}	_{2.77s (± 0.49%)}	_{2.66s (± 1.05%)}	_{🟩-0.12s (- 4.21%)}	_2.62s	_2.69s	_{p=0.005 n=6}
_{Check Time}	_{84.20s (± 0.94%)}	_{61.73s (± 0.08%)}	_{🟩-22.46s (-26.68%)}	_61.67s	_61.80s	_{p=0.005 n=6}
_{Emit Time}	_{0.16s (± 3.95%)}	_{0.17s (± 3.32%)}	_~	_0.16s	_0.17s	_{p=0.201 n=6}
_{Total Time}	_{95.06s (± 0.85%)}	_{72.48s (± 0.09%)}	_{🟩-22.58s (-23.75%)}	_72.36s	_72.56s	_{p=0.005 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,224,331	_1,242,584	_{+18,253 (+ 1.49%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,007	_265,198	_{+4,191 (+ 1.61%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,339,130k (± 0.02%)}	_{2,424,730k (± 0.02%)}	_{+85,601k (+ 3.66%)}	_2,423,980k	_2,425,137k	_{p=0.005 n=6}
_{Parse Time}	_{6.02s (± 0.58%)}	_{5.97s (± 1.09%)}	_~	_5.89s	_6.06s	_{p=0.470 n=6}
_{Bind Time}	_{2.25s (± 1.22%)}	_{1.90s (± 0.98%)}	_{🟩-0.34s (-15.28%)}	_1.88s	_1.93s	_{p=0.005 n=6}
_{Check Time}	_{40.12s (± 0.35%)}	_{33.14s (± 0.21%)}	_{🟩-6.98s (-17.40%)}	_33.03s	_33.25s	_{p=0.005 n=6}
_{Emit Time}	_{3.13s (± 1.21%)}	_{3.36s (± 2.63%)}	_{🔻+0.23s (+ 7.23%)}	_3.22s	_3.44s	_{p=0.005 n=6}
_{Total Time}	_{51.54s (± 0.24%)}	_{44.40s (± 0.27%)}	_{🟩-7.14s (-13.86%)}	_44.24s	_44.56s	_{p=0.005 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,224,331	_1,242,584	_{+18,253 (+ 1.49%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,007	_265,198	_{+4,191 (+ 1.61%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,412,607k (± 0.04%)}	_{2,511,845k (± 0.03%)}	_{🔻+99,239k (+ 4.11%)}	_2,511,025k	_2,512,668k	_{p=0.005 n=6}
_{Parse Time}	_{5.19s (± 0.76%)}	_{5.07s (± 0.79%)}	_{-0.12s (- 2.34%)}	_5.01s	_5.12s	_{p=0.005 n=6}
_{Bind Time}	_{1.70s (± 0.48%)}	_{1.62s (± 0.50%)}	_{🟩-0.07s (- 4.32%)}	_1.61s	_1.63s	_{p=0.004 n=6}
_{Check Time}	_{34.56s (± 0.28%)}	_{28.29s (± 0.12%)}	_{🟩-6.27s (-18.15%)}	_28.23s	_28.32s	_{p=0.005 n=6}
_{Emit Time}	_{2.75s (± 2.47%)}	_{2.89s (± 1.22%)}	_{🔻+0.14s (+ 5.15%)}	_2.85s	_2.93s	_{p=0.005 n=6}
_{Total Time}	_{44.21s (± 0.35%)}	_{37.91s (± 0.17%)}	_{🟩-6.30s (-14.24%)}	_37.83s	_38.01s	_{p=0.005 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,166	_268,004	_{+9,838 (+ 3.81%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,689	_109,058	_{🔻+4,369 (+ 4.17%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{427,315k (± 0.01%)}	_{451,209k (± 0.01%)}	_{🔻+23,894k (+ 5.59%)}	_451,177k	_451,253k	_{p=0.005 n=6}
_{Parse Time}	_{4.07s (± 0.44%)}	_{4.14s (± 0.48%)}	_{+0.07s (+ 1.60%)}	_4.12s	_4.16s	_{p=0.005 n=6}
_{Bind Time}	_{1.63s (± 1.06%)}	_{1.47s (± 0.51%)}	_{🟩-0.16s (- 9.62%)}	_1.46s	_1.48s	_{p=0.004 n=6}
_{Check Time}	_{21.97s (± 0.48%)}	_{17.71s (± 0.37%)}	_{🟩-4.26s (-19.39%)}	_17.66s	_17.84s	_{p=0.005 n=6}
_{Emit Time}	_{1.72s (± 1.45%)}	_{1.78s (± 0.55%)}	_{+0.05s (+ 3.09%)}	_1.76s	_1.79s	_{p=0.004 n=6}
_{Total Time}	_{29.40s (± 0.36%)}	_{25.10s (± 0.28%)}	_{🟩-4.30s (-14.62%)}	_25.03s	_25.23s	_{p=0.005 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,521k (± 0.03%)}	_{382,750k (± 0.01%)}	_{+13,229k (+ 3.58%)}	_382,708k	_382,842k	_{p=0.005 n=6}
_{Parse Time}	_{2.31s (± 0.60%)}	_{2.31s (± 0.71%)}	_~	_2.29s	_2.33s	_{p=0.410 n=6}
_{Bind Time}	_{1.33s (± 1.48%)}	_{1.18s (± 2.10%)}	_{🟩-0.15s (-11.49%)}	_1.15s	_1.22s	_{p=0.005 n=6}
_{Check Time}	_{13.16s (± 0.24%)}	_{10.46s (± 0.24%)}	_{🟩-2.70s (-20.52%)}	_10.44s	_10.51s	_{p=0.004 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{16.80s (± 0.26%)}	_{13.96s (± 0.29%)}	_{🟩-2.84s (-16.92%)}	_13.91s	_14.00s	_{p=0.005 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,878,940	_2,878,940	_~	_~	_~	_{p=1.000 n=6}
_Types	_975,074	_975,074	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,041,776k (± 0.00%)}	_{3,152,755k (± 0.00%)}	_{+110,980k (+ 3.65%)}	_3,152,697k	_3,152,866k	_{p=0.005 n=6}
_{Parse Time}	_{13.67s (± 0.42%)}	_{13.36s (± 0.36%)}	_{-0.31s (- 2.28%)}	_13.30s	_13.42s	_{p=0.005 n=6}
_{Bind Time}	_{4.23s (± 1.79%)}	_{3.40s (± 0.73%)}	_{🟩-0.82s (-19.52%)}	_3.37s	_3.43s	_{p=0.005 n=6}
_{Check Time}	_{73.45s (± 0.21%)}	_{62.02s (± 0.13%)}	_{🟩-11.43s (-15.56%)}	_61.92s	_62.13s	_{p=0.005 n=6}
_{Emit Time}	_{24.23s (± 0.54%)}	_{25.68s (± 0.64%)}	_{🔻+1.44s (+ 5.94%)}	_25.45s	_25.85s	_{p=0.005 n=6}
_{Total Time}	_{115.58s (± 0.13%)}	_{104.46s (± 0.18%)}	_{🟩-11.12s (- 9.62%)}	_104.22s	_104.72s	_{p=0.005 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,117	_267,117	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,775	_108,775	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{411,564k (± 0.01%)}	_{424,477k (± 0.01%)}	_{+12,913k (+ 3.14%)}	_424,428k	_424,589k	_{p=0.005 n=6}
_{Parse Time}	_{3.18s (± 0.31%)}	_{3.09s (± 0.17%)}	_{-0.09s (- 2.78%)}	_3.09s	_3.10s	_{p=0.004 n=6}
_{Bind Time}	_{1.41s (± 0.94%)}	_{1.27s (± 0.59%)}	_{🟩-0.14s (- 9.70%)}	_1.26s	_1.28s	_{p=0.004 n=6}
_{Check Time}	_{14.19s (± 0.33%)}	_{11.96s (± 0.25%)}	_{🟩-2.23s (-15.74%)}	_11.92s	_12.00s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{18.78s (± 0.25%)}	_{16.32s (± 0.17%)}	_{🟩-2.46s (-13.11%)}	_16.28s	_16.36s	_{p=0.005 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_525,251	_525,251	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,574	_178,574	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{462,790k (± 0.08%)}	_{475,510k (± 0.01%)}	_{+12,720k (+ 2.75%)}	_475,472k	_475,586k	_{p=0.005 n=6}
_{Parse Time}	_{3.19s (± 0.44%)}	_{3.16s (± 0.92%)}	_~	_3.12s	_3.21s	_{p=0.064 n=6}
_{Bind Time}	_{1.17s (± 0.35%)}	_{1.15s (± 0.65%)}	_{-0.02s (- 1.99%)}	_1.14s	_1.16s	_{p=0.003 n=6}
_{Check Time}	_{17.95s (± 0.24%)}	_{15.29s (± 0.35%)}	_{🟩-2.66s (-14.84%)}	_15.20s	_15.35s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.31s (± 0.21%)}	_{19.59s (± 0.39%)}	_{🟩-2.72s (-12.18%)}	_19.51s	_19.72s	_{p=0.005 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{3,212ms (±10.48%)}	_{3,449ms (± 0.64%)}	_~	_3,409ms	_3,469ms	_{p=0.054 n=6}
_{Req 2 - geterr}	_{7,238ms (± 8.32%)}	_{6,175ms (± 0.52%)}	_~	_6,114ms	_6,208ms	_{p=0.066 n=6}
_{Req 3 - references}	_{392ms (± 0.67%)}	_{391ms (± 0.40%)}	_~	_389ms	_393ms	_{p=0.746 n=6}
_{Req 4 - navto}	_{339ms (± 0.81%)}	_{342ms (± 0.40%)}	_{+4ms (+ 1.08%)}	_341ms	_345ms	_{p=0.042 n=6}
_{Req 5 - completionInfo count}	_1,357	_1,357	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{124ms (±11.78%)}	_{122ms (±10.55%)}	_~	_110ms	_147ms	_{p=0.293 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{3,588ms (± 1.31%)}	_{3,538ms (± 1.34%)}	_~	_3,477ms	_3,597ms	_{p=0.093 n=6}
_{Req 2 - geterr}	_{5,537ms (± 0.49%)}	_{4,725ms (± 0.27%)}	_{🟩-812ms (-14.66%)}	_4,705ms	_4,736ms	_{p=0.005 n=6}
_{Req 3 - references}	_{416ms (± 0.20%)}	_{422ms (± 0.20%)}	_{+6ms (+ 1.40%)}	_421ms	_423ms	_{p=0.004 n=6}
_{Req 4 - navto}	_{338ms (± 0.68%)}	_{357ms (± 2.91%)}	_{🔻+19ms (+ 5.47%)}	_347ms	_369ms	_{p=0.005 n=6}
_{Req 5 - completionInfo count}	_1,519	_1,519	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{108ms (± 2.51%)}	_{115ms (± 5.37%)}	_{🔻+7ms (+ 6.16%)}	_105ms	_122ms	_{p=0.043 n=6}
_{xstate-main-1-tsserver - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{5,207ms (± 0.66%)}	_{5,195ms (± 0.96%)}	_~	_5,135ms	_5,281ms	_{p=0.689 n=6}
_{Req 2 - geterr}	_{1,123ms (± 0.34%)}	_{984ms (± 0.45%)}	_{🟩-139ms (-12.41%)}	_977ms	_990ms	_{p=0.005 n=6}
_{Req 3 - references}	_{77ms (± 3.56%)}	_{83ms (± 3.65%)}	_{🔻+6ms (+ 7.61%)}	_80ms	_88ms	_{p=0.019 n=6}
_{Req 4 - navto}	_{459ms (± 0.79%)}	_{378ms (± 0.74%)}	_{🟩-81ms (-17.70%)}	_373ms	_380ms	_{p=0.004 n=6}
_{Req 5 - completionInfo count}	_3,413	_3,413	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{826ms (± 1.81%)}	_{872ms (± 0.90%)}	_{🔻+45ms (+ 5.47%)}	_856ms	_878ms	_{p=0.005 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstate-main-1-tsserver - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{188.88ms (± 0.17%)}	_{190.60ms (± 0.17%)}	_{+1.72ms (+ 0.91%)}	_188.88ms	_196.42ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{284.73ms (± 0.27%)}	_{286.94ms (± 0.29%)}	_{+2.21ms (+ 0.78%)}	_279.96ms	_294.76ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{226.07ms (± 0.14%)}	_{227.92ms (± 0.18%)}	_{+1.85ms (+ 0.82%)}	_226.45ms	_233.75ms	_{p=0.000 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{276.26ms (± 0.30%)}	_{278.51ms (± 0.28%)}	_{+2.25ms (+ 0.81%)}	_271.34ms	_282.31ms	_{p=0.000 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

robpalme · 2024-06-28T19:36:31Z

Good stuff. On Node the mean averages for tsc are:

a total time win of 15.1% (ranging 9.6% to 23.7%)
a memory cost of 3.6% (ranging 2.5% to 5.6%)

...which is an exchange rate of 4.2

MichaelMitchell-at · 2024-06-28T19:46:21Z

Good stuff. On Node the mean averages for tsc are:

a total time win of 15.1% (ranging 9.6% to 23.7%)

a memory cost of 3.6% (ranging 2.5% to 5.6%)

...which is an exchange rate of 4.2

It's worth keeping in mind that if TSServer requires more than 4096 MB of memory then VSCode can no longer use its prebuilt version of Node with pointer compression, which has a significant effect on interactivity performance. So it might be worth re-measuring that exchange rate on projects that are close to reaching that threshold. I plan to do this on the Airtable monorepo (which at this point has already blown past the 4GB memory limit, but we hope to eventually bring it down), once the PR is stable.

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jun 19, 2024

jakebailey reviewed Jun 19, 2024

View reviewed changes

src/services/transpile.ts Outdated Show resolved Hide resolved

jakebailey mentioned this pull request Jun 19, 2024

Defer creation of barebonesLibSourceFile #58931

Merged

DanielRosenwasser changed the title ~~Experiment - monomorphic node/type/sigature~~ Experiment - monomorphic node/type/signature Jun 19, 2024

dragomirtitian added 2 commits June 20, 2024 14:24

monomorphic node experiment.

1d559fa

Make types and signatures monomorphic too.

14e032b

Set properties directly on data in nodefactory reducing set accessor …

977cbc5

…megamorphism.

dragomirtitian force-pushed the experiment-monomorphic-node branch from 49b3d87 to 977cbc5 Compare June 22, 2024 13:44

dragomirtitian closed this Jun 22, 2024

dragomirtitian reopened this Jun 22, 2024

Bring back separate shapes for Token and Identifier as distinct form …

ba162b8

…node to reduce memory usage.

This comment was marked as outdated.

Sign in to view

dragomirtitian added 2 commits June 26, 2024 18:27

Reduce memory usage for Node data

8b8d60b

Fix tests

b0b66c2

dragomirtitian added 5 commits June 28, 2024 14:43

Make node slightly smaller by removing original and emit node and mov…

51d635c

…ing them to data

Fix leftover debug code.

8bb31a0

Merge branch 'main' into experiment-monomorphic-node

8a43426

Fix merge issue.

da811f4

Fix tests

2766a80

Experiment - monomorphic node/type/signature #58928

Are you sure you want to change the base?

Experiment - monomorphic node/type/signature #58928

Conversation

dragomirtitian commented Jun 19, 2024 • edited Loading

jakebailey commented Jun 19, 2024

typescript-bot commented Jun 19, 2024 • edited Loading

typescript-bot commented Jun 19, 2024

tsc

tsserver

startup

Andarist commented Jun 19, 2024

MichaelMitchell-at commented Jun 20, 2024

dragomirtitian commented Jun 20, 2024

MichaelMitchell-at commented Jun 20, 2024

MichaelMitchell-at commented Jun 20, 2024 • edited Loading

jakebailey commented Jun 22, 2024

typescript-bot commented Jun 22, 2024 • edited Loading

typescript-bot commented Jun 22, 2024

tsc

tsserver

startup

dragomirtitian commented Jun 22, 2024

jakebailey commented Jun 22, 2024

dragomirtitian commented Jun 24, 2024 • edited Loading

jakebailey commented Jun 24, 2024

typescript-bot commented Jun 24, 2024 • edited Loading

typescript-bot commented Jun 24, 2024

tsc

tsserver

startup

jakebailey commented Jun 24, 2024

dragomirtitian commented Jun 24, 2024

typescript-bot commented Jun 24, 2024 • edited Loading

typescript-bot commented Jun 24, 2024

tsc

This comment was marked as outdated.

This comment was marked as outdated.

jakebailey commented Jun 24, 2024

typescript-bot commented Jun 24, 2024 • edited Loading

typescript-bot commented Jun 24, 2024

tsc

dragomirtitian commented Jun 25, 2024

Jarred-Sumner commented Jun 25, 2024 • edited Loading

jakebailey commented Jun 25, 2024

dragomirtitian commented Jun 26, 2024

jakebailey commented Jun 26, 2024

typescript-bot commented Jun 26, 2024 • edited Loading

typescript-bot commented Jun 26, 2024

tsc

tsserver

startup

typescript-bot commented Jun 26, 2024

tsc

dragomirtitian commented Jun 26, 2024 • edited Loading

dragomirtitian commented Jun 28, 2024

jakebailey commented Jun 28, 2024

typescript-bot commented Jun 28, 2024 • edited Loading

typescript-bot commented Jun 28, 2024

tsc

typescript-bot commented Jun 28, 2024

tsc

tsserver

startup

robpalme commented Jun 28, 2024

MichaelMitchell-at commented Jun 28, 2024

dragomirtitian commented Jun 19, 2024 •

edited

Loading

typescript-bot commented Jun 19, 2024 •

edited

Loading

MichaelMitchell-at commented Jun 20, 2024 •

edited

Loading

typescript-bot commented Jun 22, 2024 •

edited

Loading

dragomirtitian commented Jun 24, 2024 •

edited

Loading

typescript-bot commented Jun 24, 2024 •

edited

Loading

typescript-bot commented Jun 24, 2024 •

edited

Loading

typescript-bot commented Jun 24, 2024 •

edited

Loading

Jarred-Sumner commented Jun 25, 2024 •

edited

Loading

typescript-bot commented Jun 26, 2024 •

edited

Loading

dragomirtitian commented Jun 26, 2024 •

edited

Loading

typescript-bot commented Jun 28, 2024 •

edited

Loading