[heft-webpack5-plugin] Upgrade to webpack-dev-server 4.x #2872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartvandenende-wm
requested review from
apostolisms,
D4N14L,
halfnibble,
iclanton,
octogonz,
patmill and
sachinjoseph
as code owners
|
|
octogonz
reviewed
Aug 27, 2021
| cachedAssets: false, | ||
| colors: supportsColor | ||
| } | ||
| }, |
There was a problem hiding this comment.
Overall this LGTM.
@iclanton we good with this config change?
octogonz
approved these changes
Aug 27, 2021
iclanton
reviewed
Aug 28, 2021
...s/@rushstack/heft-webpack5-plugin/bartvandenende-wm-webpack-dev-update_2021-08-24-16-18.json
Outdated
Show resolved
Hide resolved
…wm-webpack-dev-update_2021-08-24-16-18.json Co-authored-by: Ian Clanton-Thuon <[email protected]>
octogonz
reviewed
Aug 28, 2021
...s/@rushstack/heft-webpack5-plugin/bartvandenende-wm-webpack-dev-update_2021-08-24-16-18.json
Outdated
Show resolved
Hide resolved
…wm-webpack-dev-update_2021-08-24-16-18.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates webpack-dev-server from 3.x to version 4.x to which brings official webpack 5.x support.
Details
impact
There are several breaking changes when migrating to webpack-dev-server 4.x, a full migration guide is available below:
https://github.com/webpack/webpack-dev-server/blob/master/migration-v4.md
To reduce the change impact this update has only been applied for the
heft-webpack5-pluginplugin, though per above could in theory also be ported to heft-webpack4-plugin.background
The usage of webpack-dev-server 3.x was 'mostly' compatible with webpack 5.x , but there where a number of open issues that only have only been addressed in webpack-dev-server 4.x.
It has been a longer recommendation from the webpack-dev-server team to use the 4.x beta or RC builds, though due to lack of type declarations these could not be used. As of last week the official 4.0 version has been published including the types.
what does it fix
An example of an issue that is resolved is with this upgrade is the support of HMR for projects that targeted ES5 codebase: #2818
code change
package.jsonto update webpack-dev-server and the typesHow it was tested
Running
rush installandrush rebuildto re-run all existing tests.