fix: interface properties #395
Conversation
| $missingInterfaceMemberDeclaration->parent = $parentNode; | ||
| $missingInterfaceMemberDeclaration->modifiers = $modifiers; | ||
| return $missingInterfaceMemberDeclaration; | ||
| return $this->parseRemainingPropertyDeclarationOrMissingMemberDeclaration($parentNode, $modifiers); |
There was a problem hiding this comment.
possible to add a test for this? or what is a code example that would invoke this change?
|
This change has a point, though it seems unrelated to the root cause of the bug in the linked ticket. PHP internally parses https://github.com/php/php-src/blob/PHP-8.3.1/Zend/zend_language_parser.y#L622-L638 |
|
I guess This is still a compile-time error in php 8.3 (not a parser error). My personal preference is to unify the parsing of all the class-likes into one helper method but I hadn't found it that urgent php > interface foo { public int $x; }
Fatal error: Interfaces may not include properties in php shell code on line 1
php > class Foo { case X = 123; }
Fatal error: Case can only be used in enums in php shell code on line 1 |
Using a class-like member in the wrong class-like is a compile-time error, not a parsing error. Tolerate it and parse the current/remaining statements and leave it to the applications to warn about using unexpected members in classes, traits, interfaces, or enums. (Or to tolerate them for stubs for editors/IDEs) Related to microsoft#395
Using a class-like member in the wrong class-like is a compile-time error, not a parsing error. Tolerate it and parse the current/remaining statements and leave it to the applications to warn about using unexpected members in classes, traits, interfaces, or enums. (Or to tolerate them for stubs for editors/IDEs) Related to microsoft#395
Using a class-like member in the wrong class-like is a compile-time error, not a parsing error. Tolerate it and parse the current/remaining statements and leave it to the applications to warn about using unexpected members in classes, traits, interfaces, or enums. (Or to tolerate them for stubs for editors/IDEs) Related to microsoft#395
typed interfaces property declaration as broken