Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ChakraCore] Add Linux support #18476

Merged
merged 16 commits into from
Jul 23, 2021
Merged

Conversation

Pospelove
Copy link
Contributor

@Pospelove Pospelove commented Jun 16, 2021

Describe the pull request

Linux, Windows

  • Does your PR follow the maintainer guide?

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@PhoebeHui PhoebeHui added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jun 17, 2021
@PhoebeHui
Copy link
Contributor

@Pospelove, could you apply the following patch to fix the vcpkg.json file?

format.diff (4).zip

@Pospelove Pospelove marked this pull request as ready for review June 19, 2021 22:33
@PhoebeHui
Copy link
Contributor

@Pospelove, thanks for your PR!

x64-linux in CI pipeline failed with following error, it looks clang is required to build chakracore on linux, if it could be replaced with depending on llvm?

CMake Error at scripts/cmake/vcpkg_find_acquire_program.cmake:535 (message):
  Could not find clang.  Please install it via your package manager:

      sudo apt-get install clang
Call Stack (most recent call first):

@Pospelove
Copy link
Contributor Author

@PhoebeHui It seems that ChakraCore requires clang on Linux
From instructions:

su
apt-get update
apt-get dist-upgrade
apt-get install -y git build-essential cmake clang libicu-dev

@PhoebeHui PhoebeHui added the depends:vm-update PR contains changes to the VM provisioning scripts label Jun 21, 2021
@PhoebeHui PhoebeHui removed the depends:vm-update PR contains changes to the VM provisioning scripts label Jul 5, 2021
@PhoebeHui PhoebeHui requested a review from vicroms July 5, 2021 10:11
@PhoebeHui PhoebeHui added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Jul 7, 2021
ports/chakracore/portfile.cmake Outdated Show resolved Hide resolved
@Pospelove Pospelove requested a review from vicroms July 20, 2021 06:54
@PhoebeHui
Copy link
Contributor

@Pospelove, could you update the baseline version via './vcpkg x-add-version --overwrite-version chakracore"?

@PhoebeHui PhoebeHui removed the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Jul 20, 2021
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Jul 21, 2021
@Pospelove
Copy link
Contributor Author

Pospelove commented Jul 22, 2021

PR breaks Windows build. ChakraCoreWindows.h is not installed. Please do not merge until I fix it.

@PhoebeHui PhoebeHui removed the info:reviewed Pull Request changes follow basic guidelines label Jul 22, 2021
@Pospelove
Copy link
Contributor Author

It works

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Jul 23, 2021
@vicroms vicroms merged commit cdd5189 into microsoft:master Jul 23, 2021
@Pospelove Pospelove deleted the chakra-linux branch July 23, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[chakracore] build failure (Linux)
5 participants