Fix GitHub 1401, diagnostics relative to workspace folder #3780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree company="CERN" |
- relative diagnostics files are searched in build_dir and src_dir, first existing file is returned - defaults to old behavior : `path.resolve(build_dir, file)` - `resolveDiagnostics` has been made async to not slow down IDE when testing files
fargies
force-pushed
the
1401_resolve_diagnostics
branch
from
eea34e4
to
6bf4759
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses item #1401
This changes how relative filepath in diagnostics are resolved
The following changes are proposed:
path.resolve(build_dir, file)resolveDiagnosticshas been made async to not slow down IDE when testing filesThe purpose of this change
Depending on tools, compiler and CMake invocation, diagnostics paths may be relative, but either to source directory or build directory.
This is a try and guess approach, with a preference for old behavior (returning
build_dir/file).Other Notes/Information