Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the icon for document in bottom_nav_menu.xml #43

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

anjali1361
Copy link

@anjali1361 anjali1361 commented Mar 10, 2021

Related Issuse or bug

  • added the icon for document bottom_nav_view.
  • added a file in drawable from vector assets.
  • updated code in bottom_nav_menu.xml in menu sub-folder of res directory.

Fixes: #[issue number that will be closed through this PR]

Describe the changes you've made

I have changed the icon of document section of bottom_nav_menu from that of similar to home icon.

Fill in the form: https://forms.gle/uTfMxj8282nzwPck8

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots

Original Updated
original screenshot updated screenshot

Added icon for document in drawable for bottom navigation view and modified the code in bottom_nav_menu.xml inside menu folder.
@anjali1361
Copy link
Author

how to add the screenshot?

@anjali1361
Copy link
Author

Want to add title to the toolbar next.

added title for MainAtivity.java via activity_main.xml
@mishraaditya595
Copy link
Owner

you can attach snaps of the screen in the chatbox here or you can send them in the chat section for scanit in gssoc discord server if you are a participant.

Edited to set the size of title at Actionbar in landscape mode as that in portrait mode.
Set the styles for adjusting the size of title in landscape mode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants