Update to use serverless #4
Conversation
em-c-rod
commented
Apr 19, 2022
•
em-c-rod
commented
- Check readme
- Delete unneeded files (.npmignore, package-lock.json)
- Determine if any tests or workflows are desired
Signed-off-by: yarick <[email protected]>
Signed-off-by: yarick <[email protected]>
Signed-off-by: yarick <[email protected]>
Signed-off-by: yarick <[email protected]>
Signed-off-by: yarick <[email protected]>
Signed-off-by: yarick <[email protected]>
Signed-off-by: Emily Rodriguez <[email protected]>
Signed-off-by: Emily Rodriguez <[email protected]>
Signed-off-by: Emily Rodriguez <[email protected]>
Signed-off-by: Emily Rodriguez <[email protected]>
Signed-off-by: Emily Rodriguez <[email protected]>
Signed-off-by: yarick <[email protected]>
Signed-off-by: Emily Rodriguez <[email protected]>
| "scripts": { | ||
| "make-event": "serverless generate-event -t aws:s3 > test/event.json", | ||
| "test": "serverless invoke local --function saf-lambda-function --path test/event.json", | ||
| "check": "serverless deploy list" |
There was a problem hiding this comment.
Are these three scripts helpful or confusing? Check out the readme for the documentation in the testing section.
There was a problem hiding this comment.
You aren't referencing the 'check' command at least at the version of the readme i'm seeing.
These other two scripts are fine. I would emphasize within the readme that these are optional commands one can run as part of their testing process - it should be emphasized that they are not the only means through which one should be testing things.
Signed-off-by: Emily Rodriguez <[email protected]>
Signed-off-by: Emily Rodriguez <[email protected]>
| "scripts": { | ||
| "make-event": "serverless generate-event -t aws:s3 > test/event.json", | ||
| "test": "serverless invoke local --function saf-lambda-function --path test/event.json", | ||
| "check": "serverless deploy list" |
There was a problem hiding this comment.
You aren't referencing the 'check' command at least at the version of the readme i'm seeing.
These other two scripts are fine. I would emphasize within the readme that these are optional commands one can run as part of their testing process - it should be emphasized that they are not the only means through which one should be testing things.
Signed-off-by: Emily Rodriguez <[email protected]>
Signed-off-by: Emily Rodriguez <[email protected]>
Signed-off-by: Emily Rodriguez <[email protected]>
Signed-off-by: Emily Rodriguez <[email protected]>
Signed-off-by: karikarshivani <[email protected]>
Signed-off-by: Emily Rodriguez <[email protected]>
Signed-off-by: karikarshivani <[email protected]>
Signed-off-by: Emily Rodriguez <[email protected]>
Signed-off-by: Emily Rodriguez <[email protected]>
Signed-off-by: Emily Rodriguez <[email protected]>
Signed-off-by: karikarshivani <[email protected]>
Signed-off-by: karikarshivani <[email protected]>
Signed-off-by: karikarshivani <[email protected]>
