Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clear registry before updating it with new values to clear remov… #12

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dploeger
Copy link
Contributor

…ed credentials

Fixes #11

@mkoertgen
Copy link
Owner

Thanks for the contribution @dploeger.

A small question for my understanding: When clearing the expired metrics on any observe we will probably lose track of old apps. I guess this is no problem when we rely on prometheus scraping the endpoint frequently enough, right?

@dploeger
Copy link
Contributor Author

dploeger commented Jun 3, 2024

A small question for my understanding: When clearing the expired metrics on any observe we will probably lose track of old apps. I guess this is no problem when we rely on prometheus scraping the endpoint frequently enough, right?

Yes, exactly. In my view, exporters are only responsible to return the current state of things. Prometheus is responsible for storing history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics for removed app credentials aren't removed
2 participants