Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ch01: add lemma for proof 4 #53

Merged
merged 5 commits into from
May 4, 2024
Merged

Conversation

rwst
Copy link
Contributor

@rwst rwst commented May 3, 2024

There might be improvements to prod_Icc_succ_div that I don't see. I also think this should go in mathlib to the other prod lemmata. What do you say, will you take it as is? If not, I'll try again.

Copy link
Owner

@mo271 mo271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great!

FormalBook/Ch01_Six_proofs_of_the_infinity_of_primes.lean Outdated Show resolved Hide resolved
FormalBook/Ch01_Six_proofs_of_the_infinity_of_primes.lean Outdated Show resolved Hide resolved
@mo271
Copy link
Owner

mo271 commented May 3, 2024

There might be improvements to prod_Icc_succ_div that I don't see. I also think this should go in mathlib to the other prod lemmata. What do you say, will you take it as is? If not, I'll try again.

Seems like there is Finset.prod_Ico_succ_div_top but genereally it seems like there is more lemmata for Ico than for Icc in mathlib. I don't know if this is by design or they are just missing and waiting to be added. Best ask at Zulip if you have a concrete suggestion.

rwst and others added 2 commits May 4, 2024 09:27
Co-authored-by: Moritz Firsching <[email protected]>
Co-authored-by: Moritz Firsching <[email protected]>
@mo271 mo271 merged commit c1fe976 into mo271:main May 4, 2024
2 checks passed
@mo271
Copy link
Owner

mo271 commented May 4, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants