Updating minor version - in case of regression and easier history tracking #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes for split button option text not to wrap and grow towards left.
Fixed GOP-876 uniform card margins, GOP-877 set minimum_height_for_textarea and GOP-847 file uploading component bug fix.
css changes for button padding
Accordion styles Default Slim Dark
Max height for the toast notification will not have an overflow unless specified.
1. Handled appearance of scrollbar on accordion's expansion by adjusting the height. 2. Font style changes for the shell area. 3. Fixed the colour issue for the danger action sheet.
Code review suggestion changes
1. Code review suggested changes. 2. Change in the code's header part in the documentation.
Code review suggested changes.
Code review suggestion changes
…ing_calendar_to_open_when_date_field_is_clicked_anywhere_within_it [Feature] #918 enhancement of go-date-picker
…-show-go-hint-go-from-errors
922 hide show go hint go from errors
Added app-drawer stylings
Update CSS for Drodown and add test cases
Updating version number to reflect recent changes
… across the modules (#936) * FEB_29th_selection * #GOCLD 2298 test cases * #GOCLD 2298 test cases * #GOCLD 2298 test cases
Includes Leap Day calculations fix.
* Update to major version release For easier history tracking/bug fixing. Noticed there were several file changes (1 commit) in main but not in dev... thoughts are this is related to the Activity Manager feature Persistent worked on in 2022-2023. * Making this a minor version update and not major Discussed with Jiawei
jiaweicai92
previously approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Looks good.
As most of the changes are formatting ones, a minor version bump should be sufficient.
@swimtech20
swimtech20
dismissed
jiaweicai92’s stale review
The merge-base changed after approval.
RonMichaud
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Resolves
What is the new behavior?
Does this PR introduce a breaking change?