Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix storybook-builder on Windows #2740

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

bashmish
Copy link
Member

What I did

  1. setup testing on Windows

Copy link

changeset-bot bot commented May 27, 2024

⚠️ No Changeset found

Latest commit: a137a70

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@bashmish bashmish force-pushed the fix/storybook-builder-on-windows branch from 770ba5a to 68c638f Compare May 27, 2024 14:10
@bashmish bashmish force-pushed the fix/storybook-builder-on-windows branch 6 times, most recently from 104d7a4 to bf8c3c9 Compare May 27, 2024 19:36
@bashmish bashmish force-pushed the fix/storybook-builder-on-windows branch 4 times, most recently from 84f5fdc to a536e80 Compare May 27, 2024 20:08
@bashmish bashmish force-pushed the fix/storybook-builder-on-windows branch 4 times, most recently from 040f5ce to 60434bd Compare May 27, 2024 20:35
@bashmish bashmish force-pushed the fix/storybook-builder-on-windows branch from 60434bd to 51d9704 Compare May 28, 2024 09:00
@robrez
Copy link

robrez commented May 28, 2024

I encountered the following error today while trying to convert one of my repos to use the builder. Does this PR fix this error?

Storybook failed to load the following preset: @web\storybook-framework-web-components\preset

@bashmish
Copy link
Member Author

bashmish commented May 29, 2024

@robrez it will, but I'm still busy working on that, today gonna have some focus
it's also gonna be solved in Storybook itself, in Storybook 8 to be precise, given they triaged and marked it as bug storybookjs/storybook#27227, but our builder is still on Storybook 7, so for that I'll make a workaround, stay tuned :)

@bashmish
Copy link
Member Author

bashmish commented Jun 5, 2024

Unfortunately I can't find a good workaround, so need to wait for Storybook to fix the "preset" issue first.
And as a result will park this PR until then.

Meanwhile, you can try using WSL to run Storybook of your project on Windows, it works well (I tested), but it's no suprise given it's just Ubuntu under the hood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants