Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Create a Pull Request Template #306

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Conversation

wakamsha
Copy link
Contributor

What changed / motivation ?

Pull request templates allow you to standardize what contributors include when opening pull requests in your repository.

This template is created based on embeddedartistry/templates/oss_docs/PULL_REQUEST_TEMPLATE.md, but in a more simplified form.

Linked PR / Issues

https://github.com/moneyforward/frontend-forward/issues/167

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Chore (routine task, maintenance, or non-functional change that doesn't modify src or test files)

Pre-flight checklist

References

@wakamsha wakamsha self-assigned this Jun 24, 2024
Copy link
Member

@taigakiyokawa taigakiyokawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just left a nits comment. You don't have to re-request review to me.

.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
@wakamsha wakamsha merged commit cfa0cba into main Jun 25, 2024
2 checks passed
@wakamsha wakamsha deleted the chore/pull_request_template branch June 25, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants