GODRIVER-2916 Test against updated FaaS scripts #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@prestonvasquez I tried increasing the timeout to 600 seconds, but I am still failing with this error: |
blink1073
changed the title
|
Note: I was able to start a remote cluster and connect to it with the local makefile. |
| @@ -21,7 +21,7 @@ import ( | |||
| "go.mongodb.org/mongo-driver/mongo/options" | |||
| ) | |||
|
|
|||
| const timeout = 10 * time.Second | |||
| const timeout = 600 * time.Second | |||
There was a problem hiding this comment.
Optional: consider using a smaller timeout. If there is an issue with selecting a server for an operation, it would take 10 minutes for the operation to timeout.
.evergreen/config.yml
Outdated
| @@ -163,7 +163,7 @@ functions: | |||
| # If this was a patch build, doing a fresh clone would not actually test the patch | |||
| cp -R ${PROJECT_DIRECTORY}/ $DRIVERS_TOOLS | |||
| else | |||
| git clone https://github.com/mongodb-labs/drivers-evergreen-tools.git $DRIVERS_TOOLS | |||
| git clone --branch DRIVERS-2384 https://github.com/blink1073/drivers-evergreen-tools.git $DRIVERS_TOOLS | |||
There was a problem hiding this comment.
Will this be updated once mongodb-labs/drivers-evergreen-tools PR #331 is merged ?
There was a problem hiding this comment.
Yes, I'll remove this and try a smaller timeout once that is merged.
prestonvasquez
approved these changes
Aug 4, 2023
API Change ReportNo changes found! |
prestonvasquez
approved these changes
Aug 11, 2023
qingyang-hu
pushed a commit
that referenced
this pull request
Nov 8, 2023
qingyang-hu
pushed a commit
that referenced
this pull request
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2916
Summary
Run against the updated scripts in mongodb-labs/drivers-evergreen-tools#331, which check for errors.
Background & Motivation
The script had been failing silently.