GODRIVER-2943 Re-organize client entity expected log messages #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvasquez
had a problem deploying
to
api-report
GitHub Actions
Failure
prestonvasquez
changed the title
prestonvasquez
had a problem deploying
to
api-report
GitHub Actions
Failure
prestonvasquez
had a problem deploying
to
api-report
GitHub Actions
Failure
prestonvasquez
had a problem deploying
to
api-report
GitHub Actions
Failure
prestonvasquez
had a problem deploying
to
api-report
GitHub Actions
Error
prestonvasquez
had a problem deploying
to
api-report
GitHub Actions
Error
prestonvasquez
had a problem deploying
to
api-report
GitHub Actions
Error
prestonvasquez
commented
Oct 5, 2023
| @@ -84,6 +84,28 @@ func entities(ctx context.Context) *EntityMap { | |||
| return ctx.Value(entitiesKey).(*EntityMap) | |||
| } | |||
|
|
|||
| func expectedLogMessageCount(ctx context.Context) int { | |||
| return ctx.Value(expectedLogMessageCountKey).(int) | |||
| func expectedLogMessagesCount(ctx context.Context, clientID string) int { | |||
There was a problem hiding this comment.
The UTR expects this data to be client-specific. Before this change, this data was held at the test level which is incorrect. Suggest storing log message information on the context at the client-level.
qingyang-hu
previously approved these changes
Oct 10, 2023
prestonvasquez
dismissed stale reviews from qingyang-hu and blink1073
via
171895f
API Change ReportNo changes found! |
qingyang-hu
approved these changes
Dec 7, 2023
blink1073
pushed a commit
to blink1073/mongo-go-driver
that referenced
this pull request
Dec 8, 2023
qingyang-hu
pushed a commit
that referenced
this pull request
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2943
Summary
Since logs are client-oriented, this PR proposes a method of storing the logs onto the testing context to be retrieved by a client ID, rather than aggregating all of the logs for each test case.
Background & Motivation