Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GODRIVER-2256 Replace production context.TODO() with context.Backgrou… #1417

Merged
merged 1 commit into from
Oct 12, 2023
Merged

GODRIVER-2256 Replace production context.TODO() with context.Backgrou… #1417

merged 1 commit into from
Oct 12, 2023

Conversation

ramitmittal
Copy link
Contributor

GODRIVER-2256

Summary

Replaced instance of context.TODO() with context.Background() from x/mongo/driver/topology/topology.go.

Background & Motivation

There is just one instance of context.TODO() outside of examples and tests.
Trivial but closes an issue.

@ramitmittal ramitmittal requested a review from a team as a code owner October 7, 2023 19:42
@ramitmittal ramitmittal requested review from prestonvasquez and removed request for a team October 7, 2023 19:42
matthewdale
matthewdale approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@matthewdale matthewdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@blink1073 blink1073 merged commit fcacd77 into mongodb:master Oct 12, 2023
32 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewdale matthewdale matthewdale approved these changes

@prestonvasquez prestonvasquez prestonvasquez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@ramitmittal @matthewdale @prestonvasquez @blink1073