Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GODRIVER-2939 Clarify IsDuplicateKeyError()'s docs #1418

Merged
merged 2 commits into from
Oct 18, 2023
Merged

GODRIVER-2939 Clarify IsDuplicateKeyError()'s docs #1418

merged 2 commits into from
Oct 18, 2023

Conversation

ramitmittal
Copy link
Contributor

GODRIVER-2939

Summary

Update function doc string for IsDuplicateKeyError()

Background & Motivation

The function doc string for IsDuplicateKeyError does not mention the behavior when the err argument is a BulkWriteException.

@ramitmittal ramitmittal requested a review from a team as a code owner October 9, 2023 16:31
@ramitmittal ramitmittal requested review from matthewdale and removed request for a team October 9, 2023 16:31
matthewdale
matthewdale approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@matthewdale matthewdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ramitmittal Thanks for the contribution! Looks good 👍

@blink1073 blink1073 merged commit 9b3e3c4 into mongodb:master Oct 18, 2023
31 of 36 checks passed
@ramitmittal ramitmittal deleted the GODRIVER-2939 branch October 18, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewdale matthewdale matthewdale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ramitmittal @matthewdale @blink1073