Skip to content

Commit

Permalink
MOBILE-3371 search: Remove search results count
Browse files Browse the repository at this point in the history
Given some issues with the LMS webservices (they return inconsistent totalcount depending on the page), we've decided to remove this information from the UI to avoid confusion.
  • Loading branch information
NoelDeMartin committed Oct 5, 2023
1 parent 9b04cda commit 0474d69
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 8 deletions.
1 change: 0 additions & 1 deletion scripts/langindex.json
Original file line number Diff line number Diff line change
Expand Up @@ -685,7 +685,6 @@
"addon.mod_forum.removefromfavourites": "forum",
"addon.mod_forum.reply": "forum",
"addon.mod_forum.replyplaceholder": "forum",
"addon.mod_forum.searchresults": "course",
"addon.mod_forum.subject": "forum",
"addon.mod_forum.tagarea_forum_posts": "forum",
"addon.mod_forum.thisforumhasduedate": "forum",
Expand Down
1 change: 0 additions & 1 deletion src/addons/mod/forum/lang.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@
"removefromfavourites": "Unstar this discussion",
"reply": "Reply",
"replyplaceholder": "Write your reply...",
"searchresults": "Search results: {{$a}}",
"subject": "Subject",
"tagarea_forum_posts": "Forum posts",
"thisforumhasduedate": "The due date for posting to this forum is {{$a}}.",
Expand Down
4 changes: 0 additions & 4 deletions src/addons/mod/forum/pages/search/search.html
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,6 @@ <h1 *ngIf="!forum">{{ 'addon.block_searchforums.pluginname' | translate }}</h1>
<core-search-box (onSubmit)="search($event)" (onClear)="clearSearch()" [placeholder]="'core.search' | translate"
[searchLabel]="'core.search' | translate" [autoFocus]="true" [searchArea]="searchAreaId"></core-search-box>

<div *ngIf="!resultsSource.isEmpty()" class="results-count">
{{ 'addon.mod_forum.searchresults' | translate: { $a: resultsSource.getTotalResults() } }}
</div>

<ion-list *ngIf="resultsSource.isLoaded()">
<core-search-global-search-result *ngFor="let result of resultsSource.getItems()" [result]="result" [showCourse]="false"
(onClick)="visitResult(result)">
Expand Down
3 changes: 1 addition & 2 deletions src/addons/mod/forum/tests/behat/search.feature
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,5 @@ Feature: Test Forum Search

When I set the field "Search" to "message" in the app
And I press "Search" "button" in the app
Then I should find "Search results: 2" in the app
And I should find "Test forum 1" in the app
Then I should find "Test forum 1" in the app
And I should find "Test forum 2" in the app

0 comments on commit 0474d69

Please sign in to comment.