Skip to content

Commit

Permalink
MOBILE-4459 core: Rename login-sites component to login-sites-modal
Browse files Browse the repository at this point in the history
  • Loading branch information
dpalou committed Nov 15, 2023
1 parent 112237b commit 7b4954d
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 9 deletions.
6 changes: 3 additions & 3 deletions src/core/features/login/components/components.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import { NgModule } from '@angular/core';
import { CoreSharedModule } from '@/core/shared.module';
import { CoreLoginSiteOnboardingComponent } from './site-onboarding/site-onboarding';
import { CoreLoginSiteHelpComponent } from './site-help/site-help';
import { CoreLoginSitesComponent } from './sites/sites';
import { CoreLoginSitesModalComponent } from './sites-modal/sites-modal';
import { CoreLoginMethodsComponent } from './login-methods/login-methods';
import { CoreLoginExceededAttemptsComponent } from '@features/login/components/exceeded-attempts/exceeded-attempts';

Expand All @@ -25,7 +25,7 @@ import { CoreLoginExceededAttemptsComponent } from '@features/login/components/e
CoreLoginExceededAttemptsComponent,
CoreLoginSiteOnboardingComponent,
CoreLoginSiteHelpComponent,
CoreLoginSitesComponent,
CoreLoginSitesModalComponent,
CoreLoginMethodsComponent,
],
imports: [
Expand All @@ -35,7 +35,7 @@ import { CoreLoginExceededAttemptsComponent } from '@features/login/components/e
CoreLoginExceededAttemptsComponent,
CoreLoginSiteOnboardingComponent,
CoreLoginSiteHelpComponent,
CoreLoginSitesComponent,
CoreLoginSitesModalComponent,
CoreLoginMethodsComponent,
],
})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,14 @@ import { CoreAnimations } from '@components/animations';
import { ModalController } from '@singletons';

/**
* Component that displays a "splash screen" while the app is being initialized.
* Modal that displays a list of sites to be able to enter or delete a site.
*/
@Component({
selector: 'core-login-sites',
templateUrl: 'sites.html',
selector: 'core-login-sites-modal',
templateUrl: 'sites-modal.html',
animations: [CoreAnimations.SLIDE_IN_OUT, CoreAnimations.SHOW_HIDE],
})
export class CoreLoginSitesComponent implements OnInit {
export class CoreLoginSitesModalComponent implements OnInit {

accountsList: CoreAccountsList = {
sameSite: [],
Expand Down
4 changes: 2 additions & 2 deletions src/core/features/mainmenu/components/user-menu/user-menu.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import { CoreConstants } from '@/core/constants';
import { Component, OnDestroy, OnInit } from '@angular/core';
import { CoreSite, CoreSiteInfo } from '@classes/site';
import { CoreFilter } from '@features/filter/services/filter';
import { CoreLoginSitesComponent } from '@features/login/components/sites/sites';
import { CoreLoginSitesModalComponent } from '@features/login/components/sites-modal/sites-modal';
import { CoreLoginHelper } from '@features/login/services/login-helper';
import { CoreUserAuthenticatedSupportConfig } from '@features/user/classes/support/authenticated-support-config';
import { CoreUserSupport } from '@features/user/services/support';
Expand Down Expand Up @@ -239,7 +239,7 @@ export class CoreMainMenuUserMenuComponent implements OnInit, OnDestroy {
event.stopPropagation();

const closeAll = await CoreDomUtils.openSideModal<boolean>({
component: CoreLoginSitesComponent,
component: CoreLoginSitesModalComponent,
cssClass: 'core-modal-lateral core-modal-lateral-sm',
});

Expand Down
4 changes: 4 additions & 0 deletions upgrade.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ For more information about upgrading, read the official documentation: https://m
- Starting with this release, this file will only document breaking changes for APIs exposed to site plugins. Internal changes will no longer be documented.
- CoreCache has been deprecated, use plain object as in-memory stores instead.

=== 4.4.0 ===

- Renamed CoreLoginSitesComponent to CoreLoginSitesModalComponent to make it clear that it's a modal and to avoid confusing it with the new CoreSitesListComponent.

=== 4.3.0 ===

- CoreSiteBasicInfo fullName attribute has changed to fullname and avatar to userpictureurl to match user fields.
Expand Down

0 comments on commit 7b4954d

Please sign in to comment.