Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile 4009 #3742

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Mobile 4009 #3742

merged 2 commits into from
Jul 19, 2023

Conversation

crazyserver
Copy link
Member

No description provided.

@crazyserver crazyserver mentioned this pull request Jul 17, 2023
@NoelDeMartin NoelDeMartin self-requested a review July 18, 2023 01:30
Copy link
Contributor

@NoelDeMartin NoelDeMartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acceptance tests were failing, but I'm not sure if the failures were related with these changes so I triggered them again. But if it keeps failing maybe something has introduced a regression (or most likely, the tests need to be updated for the new workflow).

src/core/components/password-modal/password-modal.ts Outdated Show resolved Hide resolved
@crazyserver
Copy link
Member Author

I've added a new function userHasAccessToCourse to let the user enter the course when offline

@NoelDeMartin NoelDeMartin merged commit 6f5b68b into moodlehq:main Jul 19, 2023
2 checks passed
@phyr0s
Copy link
Contributor

phyr0s commented Jul 31, 2023

@NoelDeMartin @crazyserver animations still broken in go back action (enter works fine no glitch) due await getting if user is guest as --> #3727

@NoelDeMartin
Copy link
Contributor

Thanks for letting us know @phyr0s. We're on low capacity at the moment because many members of the team are on holidays, but we'll take a look after the holiday period.

@NoelDeMartin
Copy link
Contributor

NoelDeMartin commented Oct 9, 2023

Hello @phyr0s, sorry for the delay in looking into this.

I'm trying to see what you mean about the animations being broken, but I'm not sure what changed on the PR where you raised the issue. I do see that the animation doesn't behave as smoothly as it should, but that already happened in the latest release so I'm not sure it's related to that commit.

Here's a video of what I see when navigating into a course, let me know if this is the problem you're talking about (when going back, it seems like course contents just disappear instead of sliding to the right):

Screencast.from.09-10-23.15.06.00.webm

@crazyserver crazyserver deleted the MOBILE-4009 branch November 14, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants