-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile 4009 #3742
Mobile 4009 #3742
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Acceptance tests were failing, but I'm not sure if the failures were related with these changes so I triggered them again. But if it keeps failing maybe something has introduced a regression (or most likely, the tests need to be updated for the new workflow).
I've added a new function userHasAccessToCourse to let the user enter the course when offline |
@NoelDeMartin @crazyserver animations still broken in go back action (enter works fine no glitch) due await getting if user is guest as --> #3727 |
Thanks for letting us know @phyr0s. We're on low capacity at the moment because many members of the team are on holidays, but we'll take a look after the holiday period. |
Hello @phyr0s, sorry for the delay in looking into this. I'm trying to see what you mean about the animations being broken, but I'm not sure what changed on the PR where you raised the issue. I do see that the animation doesn't behave as smoothly as it should, but that already happened in the latest release so I'm not sure it's related to that commit. Here's a video of what I see when navigating into a course, let me know if this is the problem you're talking about (when going back, it seems like course contents just disappear instead of sliding to the right): Screencast.from.09-10-23.15.06.00.webm |
No description provided.