Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile 3947: Pre Ionic 7 changes #3855

Merged
merged 17 commits into from
Nov 20, 2023
Merged

Conversation

crazyserver
Copy link
Member

No description provided.

@crazyserver crazyserver changed the title Mobile 3947 Mobile 3947: Pre Ionic 7 changes Nov 17, 2023
@crazyserver
Copy link
Member Author

crazyserver commented Nov 17, 2023

Hi @dpalou !

I've added here last commits from MOBILE-3947 dev: Clear file storage. But rebasing I've got conflicts on commits:

MOBILE-3947 chore: Fix some HTML strict types
MOBILE-3947 user: Fix user types on user-avatar

Both on site listing pages, so I moved the changes to site-list component.

src/core/features/settings/pages/dev/dev.ts Outdated Show resolved Hide resolved
src/core/features/settings/pages/general/general.ts Outdated Show resolved Hide resolved
src/core/services/lang.ts Outdated Show resolved Hide resolved
@crazyserver
Copy link
Member Author

Thanks Dani! I've removed the lang commit and applied the changes to the clear storage

@dpalou dpalou merged commit b81e49b into moodlehq:main Nov 20, 2023
2 checks passed
@crazyserver crazyserver deleted the MOBILE-3947 branch November 20, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants