MOBILE-3947 native: Fix chooser plugin #3863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Noel, the code looks good to me but I'm not a fan of the SitePluginsProvider part, IMO it makes the code harder to understand. If I understood it right, the only reason for having this code is to allow renaming a service for site plugins, right? Why don't we just name our service |
NoelDeMartin
force-pushed
the
MOBILE-3947
branch
from
f23fc89
to
c2b86a1
Compare
|
@dpalou Ok, I've undone all that and just named the service like we had it before. |
dpalou
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.