Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix invariants tests #595

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix invariants tests #595

wants to merge 7 commits into from

Conversation

Rubilmax
Copy link
Contributor

@Rubilmax Rubilmax marked this pull request as ready for review November 17, 2023 14:55
@Rubilmax Rubilmax marked this pull request as draft November 17, 2023 15:24
@MathisGD MathisGD marked this pull request as ready for review November 21, 2023 14:09
MathisGD
MathisGD previously approved these changes Nov 21, 2023
View reviewed changes
@MathisGD MathisGD changed the title ci(invariant): re-enable invariants in CI fix invariants tests Jan 17, 2024
@MathisGD MathisGD self-assigned this Mar 7, 2024
MathisGD
MathisGD reviewed Mar 7, 2024
View reviewed changes
test/forge/invariant/MorphoDynamicInvariantTest.sol
_weightSelector(this.setPrice.selector, 5);
_weightSelector(this.mine.selector, 100);

super.setUp();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont' get why this is put before the weightSelectors, some tests fail..

Rubilmax
Rubilmax commented Mar 8, 2024
View reviewed changes
.github/workflows/foundry.yml
invariant-runs: 0
invariant-runs: 32
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI was running for 183m before failing, perhaps we should lower these

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathisGD MathisGD MathisGD left review comments

@Jean-Grimal Jean-Grimal Jean-Grimal approved these changes

@QGarchery QGarchery Awaiting requested review from QGarchery

@MerlinEgalite MerlinEgalite Awaiting requested review from MerlinEgalite

At least 2 approving reviews are required to merge this pull request.

Assignees

@MathisGD MathisGD

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restore invariants in CI
3 participants
@Rubilmax @MathisGD @Jean-Grimal