Add additions from CADC work #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge v1.0.1 changes
Bad information in the config.cfg (a science directory that didn't exist) was causing nifsMerge to fail. I added better exception handling so hint to users why it is failing.
Users can now specify -c (eg; runNifty nifsPipeline -c ...) to download raw data from the Canadian Astronomy Data Centre. This has been tested to work from the interactive config session (runNifty nifsPipeline -i) and the fully automatic mode (runNifty nifsPipeline -c -f <PROGRAM ID>).
Rather than just choosing between Gemini and CADC downloads, --data-source adds support for more than just two data sources. To add support for a new archive at minimum nifsSort.py needs changed.
There were problems with finding the config file.
Adds CADC download option, plus fixes bugs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is to merge in bugfixes to Nifty4Gemini completed at the Canadian Astronomy Data Centre (CADC) during summer 2020. It maintains full backwards compatibility with the old Nifty4Gemini, with the addition of a new command line
-s <datasource>flag which allows data to be either downloaded from the Gemini Observatory archive or the CADC's Gemini Science Archive. It will eventually include bug fixes discovered by processing the entire Gemini NIFS archive with Nifty4Gemini.