Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Remove custom hooks from the mui-name-matches-component-name linting rule #42773

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

flaviendelangle
Copy link
Member

The config now lives on the X repo.
And these custom hooks are blocking the PigmentCSS migration on the pickers.

@flaviendelangle flaviendelangle self-assigned this Jun 27, 2024
@flaviendelangle flaviendelangle added the core Infrastructure work going on behind the scenes label Jun 27, 2024
@mui-bot
Copy link

mui-bot commented Jun 27, 2024

Netlify deploy preview

https://deploy-preview-42773--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 1a0bb04

Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Had to dig a bit more than needed to figure out what this does. If you're up for it, I'd suggest to update the README with a short description of what this rule is supposed to cover.

@flaviendelangle
Copy link
Member Author

I can add it to the README, but checking its implementation changed in #42638

@siriwatknp does it mean that the rule will stop working with useThemeProps?
We are still using useThemeProps in MUI X and we can't migrate to useDefaultProps before the next major.
Also I just migrated all the pickers to use createUseThemeProps and I see that you removed its usages in the pull request above 😬 , if you could communicate any change in DX around the Pigment CSS migration to avoid back and forth work on our side that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants