[mui-utils][test] Remove usages of deprecated react-dom APIs #42780
Conversation
aarongarciah
added
test
package: utils (private)
Netlify deploy previewhttps://deploy-preview-42780--material-ui.netlify.app/ Bundle size report |
aarongarciah
force-pushed
the
remove-react-dom-deprecated-apis
branch
from
0312f13
to
c16bd9f
Compare
aarongarciah
force-pushed
the
remove-react-dom-deprecated-apis
branch
from
c16bd9f
to
21d1ff5
Compare
| let rootNode: HTMLElement; | ||
|
|
||
| function assertPass(element: any, { shouldMount = true } = {}) { | ||
| async function assertPass(element: any, { shouldMount = true } = {}) { |
There was a problem hiding this comment.
I see, I got confused thinking await waitFor was outside of assertPass 😅
waitFor is suggested for lazy components, is React.Suspense using lazy initialization? I'm not very familiar with its implementation 🤔
There was a problem hiding this comment.
My understanding is that React.Suspense + waitFor are only required because of the "accepts lazy" test, which renders a React.lazy component. Kinda weird we use this approach when only a single test requires it, but then the assertPass abstraction falls apart.
Maybe we can simplify assertPass and just not use it for "accepts lazy". I tried to leave unnecessary changes out of this PR but it's kinda difficult with the assertPass abstraction.
packages/mui-utils/src/elementAcceptingRef/elementAcceptingRef.test.tsx
Outdated
Show resolved
Hide resolved
aarongarciah
added
the
needs cherry-pick
In preparation for #42047, we need to remove
react-domdeprecated APIs, namely,renderandunmountComponentAtNode. This PR replaces these APIs withcreateRenderer, our React Testing Library wrapper.