This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
fix .desktop support #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neteler
reviewed
Sep 1, 2019
| Comment=GIS 2.18 LTR in Docker | ||
| Exec=~/Documents/launch_scripts/docker_qgis.sh %U | ||
| Comment=QGIS 2.18 LTR in Docker | ||
| Exec=/home/norwin/bin/qgis2 %U |
There was a problem hiding this comment.
here the user name is hardcoded, could that be changed?
There was a problem hiding this comment.
That is what this PR is primarily about:
In my environment (Gnome 3.32.2), the .desktop file is not recognized when relative paths or enironment variables are in the path.
neteler
reviewed
Sep 1, 2019
| Terminal=false | ||
| Type=Application | ||
| StartupNotify=true | ||
| MimeType=text/shp; | ||
| Icon=/usr/local/qgis-icon-60x60.png | ||
| Icon=/home/norwin/src/docker-qgis2/qgis-icon-60x60.png |
There was a problem hiding this comment.
here the user name is hardcoded, could that be changed?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the docker image & the launch script!
Launching from gnome desktop was not working. Changes:
-tflag indocker runprevents from running in non-interactive shell.Calls from an interactive shell are still working according to my tests.
qgis.desktopfilesudo dockeris considered an antipattern