Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Django to version 4.2.x with Python 3.9 #321

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

f-laurens
Copy link
Contributor

@f-laurens f-laurens commented Mar 18, 2022

Bump Django to version 4.2.x with Python 3.9.
Note: Django 4.x drops support for Python 3.7 (and hence Buster). So Django 3.2.x is still used with Python 3.7.

Some other requirements also bumped for security fixes.
Note:

  • Cannot bump scipy at this point:
# Latest scipy compatible with snips-nlu
scipy==1.6.2
  • Cannot bump future at this point:
    snips-nlu 0.20.2.1 depends on future<0.18 and >=0.16

@lgtm-com
Copy link

lgtm-com bot commented Mar 18, 2022

This pull request fixes 3 alerts when merging 9035f1d into 4012a0d - view on LGTM.com

fixed alerts:

  • 2 for Wrong number of arguments in a call
  • 1 for Uncontrolled command line

@lgtm-com
Copy link

lgtm-com bot commented Mar 22, 2022

This pull request fixes 3 alerts when merging d94d8ae into 4012a0d - view on LGTM.com

fixed alerts:

  • 2 for Wrong number of arguments in a call
  • 1 for Uncontrolled command line

@pguyot pguyot marked this pull request as draft April 16, 2022 10:37
@pguyot
Copy link
Collaborator

pguyot commented Apr 16, 2022

Unless I'm mistaken, if we merge this we will break deployed Nabaztags running pynab on Buster (almost everyone except some power users). So we probably should make this PR a draft until we have a working Buster to Bullseye migration procedure.

@f-laurens
Copy link
Contributor Author

f-laurens commented Apr 16, 2022

if we merge this we will break deployed Nabaztags running pynab on Buster

This should not break since this still installs Django 3.2.x if Python 3.7 (e.g. Buster); Django 4.2.x is installed only if Python 3.9 (e.g. Bullseye).

@pguyot
Copy link
Collaborator

pguyot commented Apr 16, 2022

Nice, didn't look deep enough.
However, it means we support two different versions of django...

@f-laurens
Copy link
Contributor Author

However, it means we support two different versions of django...

Hence my cautious note above that this PR might be suitable only when Pynab drops support for Raspbian (Buster) altogether.

@f-laurens f-laurens changed the title Bump Django to version 4.0.3 with Python 3.9 Bump Django to version 4.0.4 with Python 3.9 Apr 23, 2022
@lgtm-com
Copy link

lgtm-com bot commented Apr 23, 2022

This pull request fixes 3 alerts when merging 39dc94a into 814b6e1 - view on LGTM.com

fixed alerts:

  • 2 for Wrong number of arguments in a call
  • 1 for Uncontrolled command line

@lgtm-com
Copy link

lgtm-com bot commented May 22, 2022

This pull request fixes 3 alerts when merging e7f6b80 into d869ca7 - view on LGTM.com

fixed alerts:

  • 2 for Wrong number of arguments in a call
  • 1 for Uncontrolled command line

@lgtm-com
Copy link

lgtm-com bot commented Jun 1, 2022

This pull request fixes 2 alerts when merging a0664fb into 629a061 - view on LGTM.com

fixed alerts:

  • 1 for Wrong number of arguments in a call
  • 1 for Uncontrolled command line

@github-actions github-actions bot removed the web label Jun 11, 2022
@f-laurens f-laurens changed the title Bump Django to version 4.0.4 with Python 3.9 Bump Django to version 4.0.x with Python 3.9 Jul 6, 2022
@f-laurens f-laurens marked this pull request as ready for review November 24, 2022 15:57
@f-laurens f-laurens changed the title Bump Django to version 4.0.x with Python 3.9 Bump Django to version 4.2.x with Python 3.9 Oct 16, 2023
@f-laurens
Copy link
Contributor Author

Note: zero_raspios and zero2_64_raspios checks will fail till PR #455 is successfully merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants