Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aspect ratio feature. Resolves #74 #133

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Aspect ratio feature. Resolves #74 #133

wants to merge 5 commits into from

Conversation

ghost
Copy link

@ghost ghost commented May 17, 2020

I added aspect ratio feature #74, but not fixed size selection. Implementation is a bit finicky when move selection is used — if cursor isn't near corner of selection and you try to move selection, it'll jump. <- Fixed in latest commit

I moved also from SlopStartMove::update clipping of rectangle to SlopEndDrag::onEnter, so selection always yields correct coordinates.

@jbirnick
Copy link

Pls add this.

@naelstrof
Copy link
Owner

I have to add it to maim too for it to work correctly. I might be able to take a look in the next week or so.

@kkartaltepe
Copy link

kkartaltepe commented Jul 18, 2021

This is helpful without being implemented into maim (as it seems it took more than a week to carry through). For example I would like to use slop to input mappings for a drawing tablet with correct aspect ratio.

@jbirnick
Copy link

@kkartaltepe That's exactly my usecase too!

@zortax
Copy link

zortax commented Dec 7, 2021

@naelstrof would you mind looking into this again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants