Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDSC 3074: legend element #1385

Merged
merged 5 commits into from
May 11, 2021
Merged

Conversation

Chauncy-S
Copy link
Contributor

Overview

What is the feature?

Please summarize the feature or fix.

What is the Solution?

Summarize what you changed.

  • Added the Legend element inside the Fieldset element to label the Fieldset element for it to be 508 compliant.

What areas of the application does this impact?

List impacted areas.

  • I changed the ContactInfo.js file located within /earthdata-search/static/src/js/components/ContactInfo/

Testing

Reproduction steps

  • Environment for testing:
  • Collection to test with:
  1. Step 1
  2. Step 2...

Attachments

Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.

Checklist

  • [ n/a] I have added automated tests that prove my fix is effective or that my feature works
  • [ y] New and existing unit tests pass locally with my changes
  • [ y] I have performed a self-review of my own code
  • [ n/a] I have commented my code, particularly in hard-to-understand areas
  • [ n/a] I have made corresponding changes to the documentation
  • [ y] My changes generate no new warnings

@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #1385 (b1340bb) into master (45463dc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1385   +/-   ##
=======================================
  Coverage   84.61%   84.61%           
=======================================
  Files         651      651           
  Lines       15823    15823           
  Branches     3782     3782           
=======================================
  Hits        13388    13388           
  Misses       2087     2087           
  Partials      348      348           
Impacted Files Coverage Δ
...tatic/src/js/components/ContactInfo/ContactInfo.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45463dc...b1340bb. Read the comment docs.

@trevorlang trevorlang self-requested a review May 11, 2021 16:19
@macrouch macrouch merged commit 0a43f1f into nasa:master May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants