Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add features: pause and resume recording video #789

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

digitalmidges
Copy link

Add 2 new features:
Pause video recording and Resume video recording

@alaegin
Copy link

alaegin commented Apr 21, 2021

@natario1 Hello!
How about integrating these changes into the library? We need it.
The MediaRecorder methods pause and resume have the api24 requirement but it's possible to add such requirement to library methods so we don't need to upgrade minSdkVersion.

What do you think?

@natario1
Copy link
Owner

I have nothing against the feature, but this PR has too much clutter, unneeded changes, no javadocs, no docs, no tests, no PR description about design decisions (e.g. I changed this to this and used this to solve that problem because...), no reference issue / discussion. I can't afford to take care of any of this. The less lines you change, more polished you present it, more test coverage you add... more likely I can actually take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants