Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0127 recording ui #142

Open
wants to merge 17 commits into
base: 0127-improve-distance-estimation
Choose a base branch
from
Open

0127 recording ui #142

wants to merge 17 commits into from

Conversation

Steppschuh
Copy link
Contributor

For #127

@Steppschuh Steppschuh added the sample app Sample App label Nov 14, 2018
@Steppschuh Steppschuh self-assigned this Nov 14, 2018
@Steppschuh Steppschuh added this to To do in Sample App via automation Nov 14, 2018
@codecov-io
Copy link

codecov-io commented Nov 14, 2018 •
edited
Loading

Codecov Report

Merging #142 into 0127-improve-distance-estimation will decrease coverage by 0.08%.
The diff coverage is 0%.

Impacted file tree graph

@@                          Coverage Diff                           @@
##             0127-improve-distance-estimation     #142      +/-   ##
======================================================================
- Coverage                                38.2%   38.12%   -0.09%     
  Complexity                                239      239              
======================================================================
  Files                                      45       45              
  Lines                                    1424     1427       +3     
  Branches                                  133      133              
======================================================================
  Hits                                      544      544              
- Misses                                    828      831       +3     
  Partials                                   52       52
Impacted Files Coverage Δ Complexity Δ
...doorpositioning/testutil/benchmark/DeviceInfo.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...doorpositioning/testutil/benchmark/BeaconInfo.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...sitioning/testutil/benchmark/RssiMeasurements.java 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a38f1ba...d0ffe98. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Feb 6, 2019 •
edited by codecov bot
Loading

Codecov Report

Merging #142 into 0127-improve-distance-estimation will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                          Coverage Diff                           @@
##             0127-improve-distance-estimation     #142      +/-   ##
======================================================================
- Coverage                               38.20%   38.19%   -0.02%     
- Complexity                                239      241       +2     
======================================================================
  Files                                      45       45              
  Lines                                    1424     1427       +3     
  Branches                                  133      133              
======================================================================
+ Hits                                      544      545       +1     
- Misses                                    828      830       +2     
  Partials                                   52       52
Impacted Files Coverage Δ Complexity Δ
...doorpositioning/testutil/benchmark/BeaconInfo.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...doorpositioning/testutil/benchmark/DeviceInfo.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...sitioning/testutil/benchmark/RssiMeasurements.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...con/distance/PathLossBeaconDistanceCalculator.java 59.09% <0.00%> (+4.54%) 8.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a38f1ba...6e153ba. Read the comment docs.

marvinmirtschin
marvinmirtschin requested changes Sep 2, 2019
View reviewed changes
app/src/main/java/com/nexenio/bleindoorpositioningdemo/RecordingActivity.java Outdated

Log.i(TAG, "RSSI measurements:\n" + rssiMeasurements);

// TODO: persist JSON file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve TODOs.

@marvinmirtschin marvinmirtschin self-assigned this Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinmirtschin marvinmirtschin Awaiting requested review from marvinmirtschin

Assignees

@Steppschuh Steppschuh

@marvinmirtschin marvinmirtschin

Labels
sample app Sample App
Projects
Sample App
  
To do
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Steppschuh @codecov-io @marvinmirtschin