Warn on old server version #762
Open
+46
−133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for neo4j-graph-data-science-client canceled.
|
FlorentinD
force-pushed
the
min-server-version-warn
branch
from
829e195
to
d2b59a5
Compare
Mats-SX
approved these changes
Oct 4, 2024
| @@ -20,7 +20,7 @@ | |||
| from graphdatascience.session.dbms_connection_info import DbmsConnectionInfo | |||
|
|
|||
| # Should mirror the latest GDS server version under development. | |||
| DEFAULT_SERVER_VERSION = ServerVersion(2, 6, 0) | |||
| DEFAULT_SERVER_VERSION = ServerVersion(2, 10, 0) | |||
There was a problem hiding this comment.
under development
We are developing 2.12.0 of the plugin now. 2.11.0 is the latest stable.
Should this be 2.12 or 2.11?
There was a problem hiding this comment.
now with monthly updates, this can get quite annoying to update.
As its only a version for unit-testing we could also just use a very high number
FlorentinD
force-pushed
the
min-server-version-warn
branch
from
d2b59a5
to
a6c3198
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.