Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing spec for interrupts and exceptions #206

Open
wants to merge 3 commits into
base: 4.4
Choose a base branch
from

Conversation

mrhardikjoshi
Copy link
Member

No description provided.

@@ -16,7 +16,7 @@ def initialize(channel, channel_pool, logger, &on_pool_shutdown)
@server_version = channel.attributes[:server_version]
@protocol = Messaging::BoltProtocol.for_channel(channel)
@channel_pool = channel_pool
@on_pool_shutdow = on_pool_shutdown
@on_pool_shutdown = on_pool_shutdown
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed typo here and below

Copy link
Member Author

@mrhardikjoshi mrhardikjoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TO DO: This spec doesn't pass in jruby because the DriverInternalDataAccessor was written considering CRuby implementation of this gem. it needs to be updated to work with jruby as well

@mrhardikjoshi mrhardikjoshi added the Not Ready Work in progress. label Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Not Ready Work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant