Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable25] fix: Avoid conflicts on deck attachments folder name #5707

Open
wants to merge 5 commits into
base: stable25
Choose a base branch
from

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Mar 27, 2024

Backport of #5703

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Signed-off-by: Julius Härtl <[email protected]>
Copy link
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 79470 was 68024 (+16.82%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

Copy link

cypress bot commented Mar 28, 2024

Passing run #1849 ↗︎

0 6 0 0 Flakiness 0

Details:

Merge 7e9f942 into 6dee849...
Project: Deck Commit: 1190377730 ℹ️
Status: Passed Duration: 01:37 💡
Started: Mar 28, 2024 9:22 AM Ended: Mar 28, 2024 9:23 AM

Review all test suite changes for PR #5707 ↗︎

Signed-off-by: Luka Trovic <[email protected]>
@luka-nextcloud luka-nextcloud marked this pull request as ready for review May 23, 2024 17:15
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With doubt on the query count change.

@@ -1 +1 @@
68024
79470
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weirdly high, innit?

Signed-off-by: Luka Trovic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🧭 Planning evaluation (don't pick)
Development

Successfully merging this pull request may close these issues.

None yet

3 participants