Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add forbidden_filename_characters to JSConfig for use in frontend libraries #45374

Merged
merged 1 commit into from
May 16, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented May 16, 2024

Summary

Add the filename restrictions to our JS config so we can create a common frontend library function to check filename validity (de-duplicate code).

Checklist

…tend libraries

Add the filename restrictions to our JS config so we can create a common frontend library
function to check filename validity (de-duplicate code).

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
Copy link
Contributor Author

susnux commented May 16, 2024

/backport to stable29

@susnux susnux added this to the Nextcloud 30 milestone May 16, 2024
@susnux susnux requested review from a team, szaimen and sorbaugh and removed request for ShGKme, a team and sorbaugh May 16, 2024 14:45
Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, didnt test it

@susnux susnux requested review from GretaD, a team, yemkareems and sorbaugh and removed request for szaimen, a team and sorbaugh May 16, 2024 14:45
@nickvergessen nickvergessen removed their request for review May 16, 2024 14:50
@susnux susnux requested a review from st3iny May 16, 2024 15:02
@susnux susnux enabled auto-merge May 16, 2024 15:45
@susnux susnux merged commit b1f9c4b into master May 16, 2024
155 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants