Status page: display peers IPs only to admins #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngoduykhanh
reviewed
Jan 9, 2024
Comment on lines
+984
to
+987
| if isAdmin(c) { | ||
| pVm.Endpoint = devices[i].Peers[j].Endpoint.String() | ||
| } | ||
|
|
There was a problem hiding this comment.
I actually don't want to dive into the user privilege topic. As this is a read-only operation, I'd like to keep it simple, and available to any user who can access the status page.
There was a problem hiding this comment.
It's a privacy concern in this case. The example scenario is a manager that should be able to manage configs, but shouldn't be able to see where the clients are connecting from. (it's even possible to track their movements by their IP)
IP is mostly a debug tool, useful for the WG server admin.
So I don't think displaying the IP to everyone with gui access is a right thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.