Make sure init.sh is executable #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngoduykhanh
reviewed
Jan 9, 2024
| @@ -71,6 +71,7 @@ RUN mkdir -p db | |||
| COPY --from=builder --chown=wgui:wgui /build/wg-ui . | |||
| RUN chmod +x wg-ui | |||
| COPY init.sh . | |||
| RUN chmod +x init.sh | |||
There was a problem hiding this comment.
Why do we need this? The init.sh file is configured to be executed by any user already.
There was a problem hiding this comment.
If the repo is cloned or edited on windows, the flag is lost, and it's quite hard to get it back
Also prevents similar potential issues, like copy or archive without permissions
There was a problem hiding this comment.
ah ok, that makes sense. thank you for your explanation
ngoduykhanh
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.