Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for notes about clients #527

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Support for notes about clients #527

merged 2 commits into from
Jan 9, 2024

Conversation

0xCA
Copy link
Contributor

@0xCA 0xCA commented Jan 9, 2024 •
edited
Loading

image

Setting in Web UI, multiline is supported

image

Note in the wg.conf

image

There is no note for this client, nothing is written

  • Finally no more notes in the name
  • Notes are only visible for admins and managers
  • You can search by notes

@0xCA 0xCA marked this pull request as ready for review January 9, 2024 14:43
@ngoduykhanh
Copy link
Owner

LGTM. Thank you for adding it.

@ngoduykhanh ngoduykhanh merged commit ecea82d into ngoduykhanh:master Jan 9, 2024
1 check passed
@nebulosa2007
Copy link
Contributor

Great work! Tested already.
It would be great if between DNS enabled and IP Allocation a note (or just the first line of the note) will be displayed on the "user square".

  • You can search by notes

Also noticed that search by notes is case sensitive, while search by other fields are not. I think it should be altered for convinience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@0xCA @ngoduykhanh @nebulosa2007