Enable usage of python 3 #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajsite
requested review from
cglzaguilar,
sanmut and
spathiwa
as code owners
rajsite
commented
Feb 11, 2020
rajsite
commented
Feb 11, 2020
spathiwa
approved these changes
Feb 12, 2020
sanmut
approved these changes
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some change to the Travis build agents was causing installation of the Python-based httpbin server (used for testing the http client) to fail and causes all of our Travis CI builds to fail with message:
This failure revealed that that our usage of tox to create a virtualenv is not recommended on TravisCI. The travis.yml was modified to avoid tox by running commands directly (where Travis has already configured a virtualenv).
As part of this change I enabled the use of python 3 as python 2 is deprecated as of Jan 1, 2020.
To enable python 3 usage I had to upgrade our CPPLINT version where I switched to the version maintained on https://github.com/cpplint/cpplint.
These changes currently enable developers to use either python 2 or python 3 (in particular the appveyor windows build still uses python 2).