Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Is type checking for the code generator worth it #1526

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[RFC] Is type checking for the code generator worth it #1526

wants to merge 2 commits into from

Conversation

texasaggie97-zz
Copy link
Contributor

  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

Add type hinting and checking for a subset of the code generator.

In particular, look at metadata_add_all.py and nimi_python_types.py for the major changes.

Given how much needed to be torqued around to make this work, is it worth it to finish the rest of the code generator?

NOTE This does not add type checking or hinting to the public API.

List issues fixed by this Pull Request below, if any.

What testing has been done?

Add mypy in build_test tox environment

@marcoskirsch
Copy link
Member

test this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoskirsch marcoskirsch Awaiting requested review from marcoskirsch marcoskirsch is a code owner

@sbethur sbethur Awaiting requested review from sbethur

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@texasaggie97-zz @marcoskirsch