Fix missing mmol unit conversion for lastEnacted.bg in openaps.js #8234
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
The OpenAPS pill always shows enacted bg in mg/dl and does not convert units to mmol/l when mmol/l is the chosen user setting.
After some troubleshooting together with @bjornoleh and @JeremyStorring today we found out that there currently is no mmol units conversion in the code for prop.lastEnacted.bg. All other bg conversions in openaps.js works as expected.
Solution:
This PR adds the units conversion for prop.lastEnacted.bg, and resolves the issue.
Testing
The issue was identified while using iAPS as devicestatus uploader, and the code change have been tested to work with iAPS as uploader, but are most likely relevant for openAPS uploads in general (not tested).
Please review when suitable for you, and get back with any questions @sulkaharo @bewest