You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
max_iob: 9// if max_iob is not provided, will default to zero
max_iob: 9 // if max_iob is not provided, will default to zero
The openaps/oref0 default is zero:
max_iob: 0 // if max_iob is not provided, will default to zero
Expected behavior
Our code base should match orenaps/oref0 unless there are good reasons not to. In this case, there is no reason to divert from orenaps/oref0.
The text was updated successfully, but these errors were encountered:
bjornoleh
changed the title
The default value for max_iob in profile/index.js#L11 is set to 9, should be zero.
Several oref0 profile defaults diverge from openaps/oref0
Jun 9, 2024
Describe the bug
Several oref0 profile defaults diverge from openaps/oref0
One example is the default value for max_iob in profile/index.js#L11 is set to 9, and should be zero.
Please note this has no effect in Trio since it is not set identically in Trio defaults, but it should be cleaned up:
trio-oref/lib/profile/index.js
Line 11 in d1dfb70
The openaps/oref0 default is zero:
Expected behavior
Our code base should match orenaps/oref0 unless there are good reasons not to. In this case, there is no reason to divert from orenaps/oref0.
The text was updated successfully, but these errors were encountered: