Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several oref0 profile defaults diverge from openaps/oref0 #27

Open
bjornoleh opened this issue Jun 9, 2024 · 0 comments · May be fixed by #28
Open

Several oref0 profile defaults diverge from openaps/oref0 #27

bjornoleh opened this issue Jun 9, 2024 · 0 comments · May be fixed by #28
Assignees
Labels
bug Something isn't working

Comments

@bjornoleh
Copy link
Contributor

bjornoleh commented Jun 9, 2024

Describe the bug
Several oref0 profile defaults diverge from openaps/oref0

One example is the default value for max_iob in profile/index.js#L11 is set to 9, and should be zero.

Please note this has no effect in Trio since it is not set identically in Trio defaults, but it should be cleaned up:

max_iob: 9 // if max_iob is not provided, will default to zero

max_iob: 9 // if max_iob is not provided, will default to zero

The openaps/oref0 default is zero:

max_iob: 0 // if max_iob is not provided, will default to zero 

Expected behavior
Our code base should match orenaps/oref0 unless there are good reasons not to. In this case, there is no reason to divert from orenaps/oref0.

@bjornoleh bjornoleh added the bug Something isn't working label Jun 9, 2024
@bjornoleh bjornoleh changed the title The default value for max_iob in profile/index.js#L11 is set to 9, should be zero. Several oref0 profile defaults diverge from openaps/oref0 Jun 9, 2024
@bjornoleh bjornoleh linked a pull request Jun 9, 2024 that will close this issue
@bjornoleh bjornoleh linked a pull request Jun 9, 2024 that will close this issue
@bjornoleh bjornoleh self-assigned this Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

1 participant