Harmonise profile defaults with openaps/oref0 #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adresses observations made in #27, where several oref0 profile defaults were found to diverge from openaps/oref0.
Harmonised with openaps/oref0:
max_iob: 0 // if max_iob is not provided, will default to zero
, max_daily_safety_multiplier: 3
, current_basal_safety_multiplier: 4
, autosens_max: 1.2
, autosens_min: 0.7
Moving these lines to harmonise the relative position in the file:
Will keep these defaults different from openaps/oref0:
)
Not included from openaps/oref0:
Other profile variables related to dynamic ISF and
smb_delivery_ratio
which diverge from openaps/oref0 are kept:Removed this redundant comment:
// autoISF variables