fix: set wsl.useWindowsDriver when the nvidia-ctk is enabled #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
ereslibre
force-pushed
the
use-windows-driver
branch
from
02f4967
to
97fa52c
Compare
|
I just tested this following NixOS/nixpkgs#312253 and can confirm it works fine with config.hardware.nvidia-container-toolkit.enable. However, I don't think this should be limited only to wsl.docker-desktop.enable, since Podman users, for example, may want this feature by default without having to install Docker on their system. |
ereslibre
force-pushed
the
use-windows-driver
branch
from
97fa52c
to
179a541
Compare
|
Thanks a lot for checking @loicreynier! Good point, I have updated the PR to take into account |
|
Looks good to me! Tested on a Podman setup and works as expected. |
ereslibre
force-pushed
the
use-windows-driver
branch
from
179a541
to
db74ebe
Compare
This improves the user experience as whenever the user enables the `config.hardware.nvidia-container-toolkit.enable` option, they cannot use their Nvidia GPU's within the Docker containers because of missing libraries. This gets fixed by setting `wsl.useWindowsDriver` explicitly when the user requests to enable GPU support on Docker containers. Issue and fix provided by @qwqawawow Related: nix-community#433 Related: NVIDIA/nvidia-container-toolkit#452
ereslibre
force-pushed
the
use-windows-driver
branch
from
db74ebe
to
5069440
Compare
573
added a commit
to 573/nix-config-1
that referenced
this pull request
May 24, 2024
- Update neovim-nightly-flake - Update docker used in Nixos-WSL to use v25 and nvidia-container-toolkit (nix-community/NixOS-WSL#478) - reorganize emacs-novelist (still WIP) as scaffold to analyse extraPackages further
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the user experience as whenever the user enables the
config.hardware.nvidia-container-toolkit.enableoption, they cannot use their Nvidia GPU's within the Docker containers because of missing libraries.This gets fixed by setting
wsl.useWindowsDriverexplicitly when the user requests to enable GPU support on Docker containers.Issue and fix provided by @qwqawawow
Related: #433
Related: NVIDIA/nvidia-container-toolkit#452
Note: unsure if this is the right approach for this project. I am the maintainer of the CDI-generation for NixOS, and we got a couple of reports that users could not use their GPU's inside Docker containers.
I cannot test it since I don't use NixOS-WSL, but I thought it would be good to improve the user experience here a bit if possible.
Thanks :)