chore: hardware.opengl -> hardware.graphics
#503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+2
to
+5
| imports = lib.optionals (lib.versionOlder lib.version "24.11pre") [ | ||
| (lib.mkAliasOptionModule [ "hardware" "graphics" "enable" ] [ "hardware" "opengl" "enable" ]) | ||
| (lib.mkAliasOptionModule [ "hardware" "graphics" "extraPackages" ] [ "hardware" "opengl" "extraPackages" ]) | ||
| ]; |
There was a problem hiding this comment.
You are sure that this is not causing more problems?
There was a problem hiding this comment.
the worst one i could think of is 24.05 users thinking hardware.graphics is an actual option when it's not - but other than that, no
what's basically the same exact method is also used here in nixos-hardware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of NixOS/nixpkgs#320228,
hardware.openglwas renamed tohardware.graphics, causing definitions of the former to trigger an evaluation warning on the current nixos-unstable channel. Aliases are applied conditionally for these new options to continue supporting 24.05edit: fixes #498