Xonsh #5494
Open
Xonsh #5494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yajo
reviewed
Jun 17, 2024
modules/programs/xonsh.nix
Outdated
| finalPackage = lib.mkOption { | ||
| type = types.package; | ||
| internal = true; | ||
| description = "Package that will actually gat installed"; |
There was a problem hiding this comment.
Suggested change
| description = "Package that will actually gat installed"; | |
| description = "Package that will actually get installed"; |
modules/programs/xonsh.nix
Outdated
Comment on lines
43
to
49
| home = { | ||
| packages = [ cfg.finalPackage ]; | ||
| file.".xonshrc" = { | ||
| enable = cfg.xonshrc != ""; | ||
| text = cfg.xonshrc; | ||
| }; | ||
| }; |
There was a problem hiding this comment.
I think it's better to respect XDG.
Suggested change
| home = { | |
| packages = [ cfg.finalPackage ]; | |
| file.".xonshrc" = { | |
| enable = cfg.xonshrc != ""; | |
| text = cfg.xonshrc; | |
| }; | |
| }; | |
| home.packages = [ cfg.finalPackage ]; | |
| xdg.configFile."xonsh/rc.xsh" = { | |
| enable = cfg.xonshrc != ""; | |
| text = cfg.xonshrc; | |
| }; |
Another option is how #5160 does it: split by files. It's directly supported by xonsh.
Which one is better? I don't know, but you and @inmaldrerah should probably join efforts.
Thanks both!
inmaldrerah
reviewed
Jun 18, 2024
modules/programs/xonsh.nix
Outdated
| cfg.package.override (old: { inherit (cfg) extraPackages; }); | ||
| }; | ||
| }; | ||
| xdg.configFile."xonsh/rc.xsh" = { |
There was a problem hiding this comment.
This xdg.configFile."xonsh/rc.xsh" entry should be in the previous config block.
pasqui23
force-pushed
the
xonsh
branch
3 times, most recently
from
f340f89
to
456cc84
Compare
6 tasks
pasqui23
force-pushed
the
xonsh
branch
3 times, most recently
from
42b47ba
to
5f24d60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.allornix develop --ignore-environment .#allusing Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC