Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ hgemm/bugfix ] Consider small hgemm case @open sesame 05/13 21:35 #2577

Closed
wants to merge 1 commit into from
Closed

[ hgemm/bugfix ] Consider small hgemm case @open sesame 05/13 21:35 #2577

wants to merge 1 commit into from

Conversation

skykongkong8
Copy link
Member

@skykongkong8 skykongkong8 commented May 9, 2024 •
edited
Loading

  • Small means, for here, is smaller than: (4x4) * (4x4)
  • With hard-coded sized (4x4, 8x8, ...) kernel hgemm, matrix length that are smaller than unit vector length might fail.
  • Toss such case to fallback. Such small sized gemm will take a few nanoseconds and therefore negligible.

Self evaluation:

  1. Build test: [X]Passed [ ]Failed [ ]Skipped
  2. Run test: [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: skykongkong8 [email protected]

@taos-ci
Copy link
Collaborator

taos-ci commented May 9, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2577. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

@skykongkong8 skykongkong8 changed the title [ Wait for #2573] Consider small hgemm case [ Wait for #2573] [ hgemm ]Consider small hgemm case May 9, 2024
@skykongkong8 skykongkong8 changed the title [ Wait for #2573] [ hgemm ]Consider small hgemm case [ Wait for #2573] [ hgemm ] Consider small hgemm case May 9, 2024
taos-ci
taos-ci approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skykongkong8, 💯 All CI checkers are successfully verified. Thanks.

taos-ci
taos-ci approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skykongkong8, 💯 All CI checkers are successfully verified. Thanks.

@skykongkong8 skykongkong8 changed the title [ Wait for #2573] [ hgemm ] Consider small hgemm case [ Wait for #2573 ] [ hgemm ] Consider small hgemm case May 10, 2024
@skykongkong8 skykongkong8 changed the title [ Wait for #2573 ] [ hgemm ] Consider small hgemm case [ hgemm ] Consider small hgemm case May 13, 2024
@skykongkong8
[ hgemm ] Consider tiny gemm case
81f30a3 
- Current hard-coded lenght kernel hgemm, matrix length that are smaller than unit vector length might fail.
- Toss such case to fallback. Such small sized hgemm will take a few nanosecond latency, therefore negligible.

**Self evaluation:**
1. Build test:     [X]Passed [ ]Failed [ ]Skipped
2. Run test:     [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: skykongkong8 <[email protected]>
taos-ci
taos-ci approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skykongkong8, 💯 All CI checkers are successfully verified. Thanks.

@skykongkong8 skykongkong8 changed the title [ hgemm ] Consider small hgemm case [ hgemm/bugfix ] Consider small hgemm case May 13, 2024
@skykongkong8 skykongkong8 changed the title [ hgemm/bugfix ] Consider small hgemm case [ hgemm/bugfix ] Consider small hgemm case @open sesame 05/13 21:35 May 13, 2024
taos-ci
taos-ci approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skykongkong8, 💯 All CI checkers are successfully verified. Thanks.

SeoHyungjun
SeoHyungjun approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@SeoHyungjun SeoHyungjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skykongkong8
Copy link
Member Author

With different commit this PR seems to be no longer needed. Close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeoHyungjun SeoHyungjun SeoHyungjun approved these changes

@taos-ci taos-ci taos-ci approved these changes

@myungjoo myungjoo Awaiting requested review from myungjoo myungjoo is a code owner

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@jaeyun-jung jaeyun-jung Awaiting requested review from jaeyun-jung jaeyun-jung is a code owner

@leemgs leemgs Awaiting requested review from leemgs leemgs is a code owner

@wooksong wooksong Awaiting requested review from wooksong wooksong is a code owner

@helloahn helloahn Awaiting requested review from helloahn helloahn is a code owner

@kparichay kparichay Awaiting requested review from kparichay kparichay is a code owner

@gichan-jang gichan-jang Awaiting requested review from gichan-jang gichan-jang is a code owner

@anyj0527 anyj0527 Awaiting requested review from anyj0527 anyj0527 is a code owner

@zhoonit zhoonit Awaiting requested review from zhoonit zhoonit is a code owner

@lhs8928 lhs8928 Awaiting requested review from lhs8928 lhs8928 is a code owner

@songgot songgot Awaiting requested review from songgot songgot is a code owner

@jihochu jihochu Awaiting requested review from jihochu jihochu is a code owner

@DonghakPark DonghakPark Awaiting requested review from DonghakPark DonghakPark is a code owner

@baek2sm baek2sm Awaiting requested review from baek2sm baek2sm is a code owner

@djeong20 djeong20 Awaiting requested review from djeong20 djeong20 is a code owner

@EunjuYang EunjuYang Awaiting requested review from EunjuYang EunjuYang is a code owner

Assignees
No one assigned
Labels
Need Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@skykongkong8 @taos-ci @SeoHyungjun