[CI] Add fp-16 build in github action #2641
Conversation
heka1024
requested review from
myungjoo,
jijoongmoon,
again4you,
jaeyun-jung,
leemgs,
wooksong,
helloahn,
kparichay,
gichan-jang,
anyj0527,
zhoonit,
lhs8928,
songgot,
jihochu,
DonghakPark,
SeoHyungjun,
baek2sm,
skykongkong8,
djeong20,
EunjuYang and
a team
as code owners
|
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2641. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/. |
| meson \ | ||
| --buildtype=plain \ | ||
| --prefix=/usr \ | ||
| --sysconfdir=/etc \ | ||
| --libdir=lib/x86_64-linux-gnu \ | ||
| --bindir=lib/nntrainer/bin \ | ||
| --includedir=include \ | ||
| -Dinstall-app=true \ | ||
| -Dreduce-tolerance=false \ | ||
| -Denable-debug=true \ | ||
| -Dml-api-support=enabled \ | ||
| -Denable-nnstreamer-tensor-filter=enabled \ | ||
| -Denable-nnstreamer-tensor-trainer=enabled \ | ||
| -Denable-nnstreamer-backbone=true \ | ||
| -Dcapi-ml-common-actual=capi-ml-common \ | ||
| -Dcapi-ml-inference-actual=capi-ml-inference \ | ||
| -Denable-capi=enabled \ | ||
| build |
There was a problem hiding this comment.
To make code more readable, I expand arguments of meson build.
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| matrix: | ||
| os: [ ubuntu-latest ] |
There was a problem hiding this comment.
I think tests on latest version of ubuntu is sufficient.
There was a problem hiding this comment.
Thank you for implementing CI.
However, since there are many devices that are still testing and running NNtrainer on 20.04, could you please use both 20.04 and 22.04?
I believe that it is good for stability to conduct explicit tests even if Ubuntu LTS changes to 24.04 in the future.
There was a problem hiding this comment.
@DonghakPark I changed os to 20.04 and 22.04. Thank you for the review.
| - run: ninja -C build | ||
| - name: run ninja test | ||
| run: cd ./build && ninja test | ||
| continue-on-error: true |
There was a problem hiding this comment.
If there is a more nice option than this one, please add a comment.
There was a problem hiding this comment.
You may handle fp16-enabled and fp16-disabled as another matrix-strategy entry to avoid writing duplicated scripts. Anyway, it can be done after this merged.
Closes nnstreamer#2560. You can now see the build results from Fp16 in a Github action. **Self evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: heka1024 <[email protected]>
Closes #2560. You can now see the build results from Fp16 in a Github action.
Self evaluation:
Signed-off-by: heka1024 [email protected]