action/ubuntu: fp16 on/off handled by matrix #2647
Conversation
To de-dup scripts handling fp16-enabled and fp16-disabled cases for meson-clean build, add another matrix entry. Reference: https://github.com/nnstreamer/nntrainer/pull/2641/files#r1646986341 Signed-off-by: MyungJoo Ham <[email protected]>
myungjoo
requested review from
jijoongmoon,
again4you,
jaeyun-jung,
leemgs,
wooksong,
helloahn,
kparichay,
gichan-jang,
anyj0527,
zhoonit,
lhs8928,
songgot,
jihochu,
DonghakPark,
SeoHyungjun,
baek2sm,
skykongkong8,
djeong20,
EunjuYang and
a team
as code owners
|
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2647. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/. |
There was a problem hiding this comment.
I think we said in #2560 (comment) that the Fp16 build should be optional. But I think this pull request make a build on fp16 as required. Should we make it required?
fp16 build should be kept optional. Users should be able to enable/disable fp16 for their own build. fp16 compatibility should be kept mandatory. Any commit should NEVER break fp16 support, which will keep users being able to enable/disable fp16 for their own build. Without this mandate, users won't be able to enable fp16 in the near future. |
To de-dup scripts handling fp16-enabled and fp16-disabled cases for meson-clean build, add another matrix entry.
Reference: https://github.com/nnstreamer/nntrainer/pull/2641/files#r1646986341
CC: @heka1024