-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Add PR review from clang-format #2659
[CI] Add PR review from clang-format #2659
Conversation
This PR enables the GitHub actions bot to suggest changes based on the clang-format directly. **Changes proposed in this PR:** - Add format-review options to enable Pull Request reviews from clang-format. - Upgrade the cpp-linter version to 2.9.0 to meet minimum version requirements. **Self-evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: Donghyeon Jeong <[email protected]>
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2659. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, it will guide for who are not familiar with clang-format how to edit it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@djeong20, 💯 All CI checkers are successfully verified. Thanks.
In order for the github-actions bot to properly comment, write permission should be granted to the GITHUB_TOKEN. ref: https://cpp-linter.github.io/cpp-linter-action/permissions/ Would it be possible for nntrainer to have Send write tokens to workflows from pull requests setting? @myungjoo @jijoongmoon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR enables the GitHub actions bot to suggest changes based on the clang-format directly.
Changes proposed in this PR:
Self-evaluation: